From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 2/2] drm/i915: Force reset on unready engine Date: Mon, 13 Aug 2018 11:18:07 +0300 Message-ID: <87pnym4r40.fsf@gaia.fi.intel.com> References: <20180810140036.24240-1-mika.kuoppala@linux.intel.com> <20180810140036.24240-2-mika.kuoppala@linux.intel.com> <153391040793.12983.11406349176984550701@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7FD9B89C51 for ; Mon, 13 Aug 2018 08:19:39 +0000 (UTC) In-Reply-To: <153391040793.12983.11406349176984550701@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUXVvdGlu ZyBNaWthIEt1b3BwYWxhICgyMDE4LTA4LTEwIDE1OjAwOjM2KQo+PiBJZiBlbmdpbmUgcmVwb3J0 cyB0aGF0IGl0IGlzIG5vdCByZWFkeSBmb3IgcmVzZXQsIHdlCj4+IGdpdmUgdXAuIEV2aWRlbmNl IHNob3dzIHRoYXQgZm9yY2luZyBhIHBlciBlbmdpbmUgcmVzZXQKPj4gb24gYW4gZW5naW5lIHdo aWNoIGlzIG5vdCByZXBvcnRpbmcgdG8gYmUgcmVhZHkgZm9yIHJlc2V0LAo+PiBjYW4gYnJpbmcg aXQgYmFjayBpbnRvIGEgd29ya2luZyBvcmRlci4gVGhlcmUgaXMgcmlzayB0aGF0Cj4+IHdlIGNv cnJ1cHQgdGhlIGNvbnRleHQgaW1hZ2UgY3VycmVudGx5IGV4ZWN1dGluZyBvbiB0aGF0Cj4+IGVu Z2luZS4gQnV0IHRoYXQgaXMgYSByaXNrIHdvcnRoIHRha2luZyBhcyBpZiB3ZSB1bmJsb2NrCj4+ IHRoZSBlbmdpbmUsIHdlIHByZXZlbnQgYSB3aG9sZSBkZXZpY2Ugd2VkZ2luZyBpbiBhIGNhc2UK Pj4gb2YgZnVsbCBncHUgcmVzZXQuCj4+IAo+PiBSZXNldCBpbmRpdmlkdWFsIGVuZ2luZSBldmVu IGlmIGl0IHJlcG9ydHMgdGhhdCBpdCBpcyBub3QKPj4gcHJlcGFyZWQgZm9yIHJlc2V0LCBidXQg b25seSBpZiB3ZSBhaW0gZm9yIGZ1bGwgZ3B1IHJlc2V0Cj4+IGFuZCBub3Qgb24gZmlyc3QgcmVz ZXQgYXR0ZW1wdC4KPj4gCj4+IHYyOiBmb3JjZSByZXNldCBvbmx5IG9uIGxhdGVyIGF0dGVtcHRz LCByZWFkYWJpbGl0eSAoQ2hyaXMpCj4+IAo+PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp cy13aWxzb24uY28udWs+Cj4+IFNpZ25lZC1vZmYtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3Vv cHBhbGFAbGludXguaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3VuY29yZS5jIHwgNDkgKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0KPj4gIDEgZmls ZSBjaGFuZ2VkLCAzOSBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPj4gCj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4+IGluZGV4IDAyN2QxNDU3NGJmYS4uZDI0MDI2ODM5 YjE3IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYwo+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYwo+PiBAQCAtMjA5OSw5 ICsyMDk5LDYgQEAgc3RhdGljIGludCBnZW44X3Jlc2V0X2VuZ2luZV9zdGFydChzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBSRVNFVF9DVExfUkVBRFlfVE9fUkVTRVQsCj4+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICA3MDAsIDAsCj4+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBOVUxMKTsKPj4gLSAgICAgICBpZiAocmV0KQo+PiAtICAg ICAgICAgICAgICAgRFJNX0VSUk9SKCIlczogcmVzZXQgcmVxdWVzdCB0aW1lb3V0XG4iLCBlbmdp bmUtPm5hbWUpOwo+PiAtCj4+ICAgICAgICAgcmV0dXJuIHJldDsKPj4gIH0KPj4gIAo+PiBAQCAt MjExMyw2ICsyMTEwLDQyIEBAIHN0YXRpYyB2b2lkIGdlbjhfcmVzZXRfZW5naW5lX2NhbmNlbChz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+ICAgICAgICAgICAgICAgICAgICAgICBf TUFTS0VEX0JJVF9ESVNBQkxFKFJFU0VUX0NUTF9SRVFVRVNUX1JFU0VUKSk7Cj4+ICB9Cj4+ICAK Pj4gK3N0YXRpYyBpbnQgcmVzZXRfZW5naW5lcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkx NSwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBlbmdpbmVfbWFzaywK Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCByZXRyeSkKPj4gK3sKPj4g KyAgICAgICBpZiAoSU5URUxfR0VOKGk5MTUpID49IDExKQo+PiArICAgICAgICAgICAgICAgcmV0 dXJuIGdlbjExX3Jlc2V0X2VuZ2luZXMoaTkxNSwgZW5naW5lX21hc2spOwo+PiArICAgICAgIGVs c2UKPj4gKyAgICAgICAgICAgICAgIHJldHVybiBnZW42X3Jlc2V0X2VuZ2luZXMoaTkxNSwgZW5n aW5lX21hc2ssIHJldHJ5KTsKPj4gK30KPj4gKwo+PiArc3RhdGljIGludCBnZW44X3ByZXBhcmVf ZW5naW5lX2Zvcl9yZXNldChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHJldHJ5KQo+ PiArewo+PiArICAgICAgIGNvbnN0IGJvb2wgZm9yY2VfcmVzZXRfb25fbm9uX3JlYWR5ID0gcmV0 cnkgPj0gMTsKPj4gKyAgICAgICBpbnQgcmV0Owo+PiArCj4+ICsgICAgICAgcmV0ID0gZ2VuOF9y ZXNldF9lbmdpbmVfc3RhcnQoZW5naW5lKTsKPj4gKwo+PiArICAgICAgIGlmIChyZXQgJiYgZm9y Y2VfcmVzZXRfb25fbm9uX3JlYWR5KSB7Cj4+ICsgICAgICAgICAgICAgICAvKgo+PiArICAgICAg ICAgICAgICAgICogVHJ5IHRvIHVuYmxvY2sgYSBzaW5nbGUgbm9uLXJlYWR5IGVuZ2luZSBieSBy aXNraW5nCj4+ICsgICAgICAgICAgICAgICAgKiBjb250ZXh0IGNvcnJ1cHRpb24uCj4+ICsgICAg ICAgICAgICAgICAgKi8KPj4gKyAgICAgICAgICAgICAgIHJldCA9IHJlc2V0X2VuZ2luZXMoZW5n aW5lLT5pOTE1LAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnRlbF9l bmdpbmVfZmxhZyhlbmdpbmUpLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICByZXRyeSk7Cj4+ICsgICAgICAgICAgICAgICBpZiAoIXJldCkKPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgcmV0ID0gZ2VuOF9yZXNldF9lbmdpbmVfc3RhcnQoZW5naW5lKTsKPj4gKwo+PiAr ICAgICAgICAgICAgICAgRFJNX0VSUk9SKCIlczogcmVzZXQgcmVxdWVzdCB0aW1lb3V0LCBmb3Jj aW5nIHJlc2V0ICglZClcbiIsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgZW5naW5lLT5u YW1lLCByZXQpOwo+Cj4gVGhpcyBsb29rcyBkdWJpb3VzIG5vdyA7KQo+Cj4gQWZ0ZXIgdGhlIGZv cmNlIHlvdSB0aGVuIGRvIGEgcmVzZXQgaW4gdGhlIGNhbGxlci4gVHdpY2UgdGhlIHJlc2V0IGZv cgo+IHR3aWNlIHRoZSB1bnByZXBhcmVkbmVzcy4KCkl0IGlzIGludGVudGlvbmFsLiBGaXJzdCB3 ZSBtYWtlIHRoZSBlbmdpbmUgdW5zdHVjayBhbmQgdGhlbiBkbwphIGZ1bGwgY3ljbGUgd2l0aCBy ZWFkeSB0byByZXNldCBpbnZvbHZlZC4gSSBkb24ndCBrbm93IGlmCml0IHJlYWxseSBtYXR0ZXJz IHRoby4gSXQgY291bGQgYmUgdGhhdCB0aGUgZW5naW5lIGlzIGFscmVhZHkKaW4gcHJpc3RpbmUg Y29uZGl0aW9uIGFmdGVyIGZpcnN0LgoKSSBjb25zaWRlcmVkIHRoZSBlbmdpbmUgcmVzZXQgaGVy ZSB0byBvbmx5IGJlIHRoZSBoYW1tZXIsCmFuZCB0aGVuIHRoZSByZXNldCBhZnRlcndhcmRzIHRv IGJlIHRoZSB2YWxpZGF0aW9uLgoKLU1pa2EKCj4KPj4gKyAgICAgICB9Cj4+ICsKPj4gKyAgICAg ICByZXR1cm4gcmV0Owo+PiArfQo+PiArCj4+ICBzdGF0aWMgaW50IGdlbjhfcmVzZXRfZW5naW5l cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHVuc2lnbmVkIGludCBlbmdpbmVfbWFzaywKPj4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHJldHJ5KQo+PiBAQCAtMjEyMiwxNiArMjE1NSwx MiBAQCBzdGF0aWMgaW50IGdlbjhfcmVzZXRfZW5naW5lcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4+ICAgICAgICAgaW50IHJldDsKPj4gIAo+PiAgICAgICAgIGZvcl9lYWNo X2VuZ2luZV9tYXNrZWQoZW5naW5lLCBkZXZfcHJpdiwgZW5naW5lX21hc2ssIHRtcCkgewo+PiAt ICAgICAgICAgICAgICAgaWYgKGdlbjhfcmVzZXRfZW5naW5lX3N0YXJ0KGVuZ2luZSkpIHsKPj4g LSAgICAgICAgICAgICAgICAgICAgICAgcmV0ID0gLUVJTzsKPj4gKyAgICAgICAgICAgICAgIHJl dCA9IGdlbjhfcHJlcGFyZV9lbmdpbmVfZm9yX3Jlc2V0KGVuZ2luZSwgcmV0cnkpOwo+PiArICAg ICAgICAgICAgICAgaWYgKHJldCkKPgo+IGlmIChyZXQgJiYgIWZvcmNlX3Jlc2V0X3VucmVhZCkK Pgo+PiAgICAgICAgICAgICAgICAgICAgICAgICBnb3RvIG5vdF9yZWFkeTsKPj4gLSAgICAgICAg ICAgICAgIH0KPj4gICAgICAgICB9Cj4+ICAKPj4gLSAgICAgICBpZiAoSU5URUxfR0VOKGRldl9w cml2KSA+PSAxMSkKPj4gLSAgICAgICAgICAgICAgIHJldCA9IGdlbjExX3Jlc2V0X2VuZ2luZXMo ZGV2X3ByaXYsIGVuZ2luZV9tYXNrKTsKPj4gLSAgICAgICBlbHNlCj4+IC0gICAgICAgICAgICAg ICByZXQgPSBnZW42X3Jlc2V0X2VuZ2luZXMoZGV2X3ByaXYsIGVuZ2luZV9tYXNrLCByZXRyeSk7 Cj4+ICsgICAgICAgcmV0ID0gcmVzZXRfZW5naW5lcyhkZXZfcHJpdiwgZW5naW5lX21hc2ssIHJl dHJ5KTsKPj4gIAo+PiAgbm90X3JlYWR5Ogo+PiAgICAgICAgIGZvcl9lYWNoX2VuZ2luZV9tYXNr ZWQoZW5naW5lLCBkZXZfcHJpdiwgZW5naW5lX21hc2ssIHRtcCkKPj4gLS0gCj4+IDIuMTcuMQo+ PiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==