All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Minas Harutyunyan <hminas@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Zhangfei Gao <zhangfei.gao@linaro.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Bruno Herrera <bruherrera@gmail.com>,
	linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFT PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere
Date: Fri, 27 Jul 2018 09:55:32 +0300	[thread overview]
Message-ID: <87pnz9yxp7.fsf@linux.intel.com> (raw)
In-Reply-To: <CAD=FV=WjMVhc=h+YJLmW6jQ0aS+qc1ZQU5DCx2F8B7hKc4v8ZA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2178 bytes --]


Hi,

Doug Anderson <dianders@chromium.org> writes:
> On Thu, Jul 26, 2018 at 3:59 AM, Felipe Balbi
> <felipe.balbi@linux.intel.com> wrote:
>> Douglas Anderson <dianders@chromium.org> writes:
>>
>>> While looking at a dwc2 recently, I noticed that some platforms still
>>> have the uframe scheduler off.  As far as I know, nothing good can
>>> come out of having the uframe scheduler off.  Let's turn it on
>>> everywhere.  Assuming this all works out then some time in the future
>>> we can gut all the old code that handles the old non-uframe scheduler
>>> and make everything simpler.
>>>
>>> NOTE: I don't have access to any of the platforms that I'm changing
>>> here, so I'm hoping to see a Tested-by from those on the list.
>>>
>>>
>>> Douglas Anderson (4):
>>>   usb: dwc2: Turn on uframe_sched on "bcm" platforms
>>>   usb: dwc2: Turn on uframe_sched on "his" platforms
>>>   usb: dwc2: Turn on uframe_sched on "amlogic" platforms
>>>   usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms
>>
>> care to resend without RFT prefix and with collected acks, tested-bys, etc?
>
> Done with a prefix of 'REPOST' to hopefully make it obvious nothing
> changed between the RFT and this version.  There were only two
> test-by, but as mentioned in the updated cover letter:
>
> Since there should be nothing platform specific about the uFrame
> scheduler presumably this should mean we're good to go?  Specificaly
> note that in at least one of the "Tested-by" reports this patch caused
> a notable improvement.
>
>
> BTW: I'm pleased to have you apply the patches, but I notice that
> get_maintainer no longer flags you as the person to post dwc2 patches
> to.  From linux-next:
>
> $ ./scripts/get_maintainer.pl -f drivers/usb/dwc2
> Minas Harutyunyan <hminas@synopsys.com> (maintainer:DESIGNWARE USB2
> DRD IP DRIVER)
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:USB SUBSYSTEM)
> linux-usb@vger.kernel.org (open list:DESIGNWARE USB2 DRD IP DRIVER)
> linux-kernel@vger.kernel.org (open list)

I need to add dwc2 to the gadget framework part of MAINTAINERS. I'll do
that at some point.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2018-07-27  6:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 16:21 [RFT PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Douglas Anderson
2018-07-26 10:59 ` Felipe Balbi
2018-07-26 20:11   ` Doug Anderson
2018-07-27  6:55     ` Felipe Balbi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-07-06 16:21 [RFT,1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms Doug Anderson
2018-07-06 16:21 ` [RFT PATCH 1/4] " Douglas Anderson
2018-07-06 16:21 [RFT,2/4] usb: dwc2: Turn on uframe_sched on "his" platforms Doug Anderson
2018-07-06 16:21 ` [RFT PATCH 2/4] " Douglas Anderson
2018-07-06 16:21 [RFT,3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms Doug Anderson
2018-07-06 16:21 ` [RFT PATCH 3/4] " Douglas Anderson
2018-07-06 16:21 [RFT,4/4] usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms Doug Anderson
2018-07-06 16:21 ` [RFT PATCH 4/4] " Douglas Anderson
2018-07-10 13:57 [RFT PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Stefan Wahren
2018-07-10 15:21 ` Doug Anderson
2018-07-11 11:29   ` Stefan Wahren
2018-07-10 23:34 [RFT,2/4] usb: dwc2: Turn on uframe_sched on "his" platforms John Stultz
2018-07-10 23:34 ` [RFT PATCH 2/4] " John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnz9yxp7.fsf@linux.intel.com \
    --to=felipe.balbi@linux.intel.com \
    --cc=bruherrera@gmail.com \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hminas@synopsys.com \
    --cc=jbrunet@baylibre.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.