From: ebiederm@xmission.com (Eric W. Biederman)
To: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Adrian Reber <adrian@lisas.de>,
LKML <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Pavel Emelyanov <xemul@virtuozzo.com>,
Andrei Vagin <avagin@virtuozzo.com>,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Linux Containers <containers@lists.linux-foundation.org>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE
Date: Sat, 14 Jul 2018 14:04:46 -0500 [thread overview]
Message-ID: <87pnzpvdtd.fsf@xmission.com> (raw)
In-Reply-To: <CAGXu5jJMBDd3-Yab78aYwQ1N6VG7=BjARoTF1pDygPhaWA9VNQ@mail.gmail.com> (Kees Cook's message of "Fri, 13 Jul 2018 21:44:15 -0700")
Kees Cook <keescook@chromium.org> writes:
> On Fri, Jul 13, 2018 at 1:55 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
>> On Thu, 12 Jul 2018 11:33:33 -0500 ebiederm@xmission.com (Eric W. Biederman) wrote:
>>> What is the value of disabling this functionality ever?
>>>
>>> Is there any reason why we don't just delete CONFIG_CHECKPOINT_RESTORE
>>> entirely?
>>
>> For the vast number of Linux machines which aren't servers? Check out
>> some defconfigs - only one of arm's 119 defconfigs selects it.
>
> Right, and I would bet the minification folks would like to keep it
> out of their builds too. I think we should keep the config.
I take it then you are volunteering to test with and without the config
option?
Even if the config option is kept I intend to rip it out every time I
wind up touching code with it in. Config options have a real cost in
testing and development.
For a config option that no one has come forward with an actual real
world use case for disabling, that cost seems much too high.
Eric
next prev parent reply other threads:[~2018-07-14 19:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 13:07 [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE Adrian Reber
2018-07-12 13:47 ` Oleg Nesterov
2018-07-12 13:47 ` Hendrik Brueckner
2018-07-12 13:51 ` Alice Frosi
2018-07-12 16:33 ` Eric W. Biederman
2018-07-13 8:35 ` Pavel Emelyanov
2018-07-13 13:46 ` Eric W. Biederman
2018-07-13 14:20 ` Adrian Reber
2018-07-13 20:55 ` Andrew Morton
2018-07-14 4:44 ` Kees Cook
2018-07-14 6:02 ` Josh Triplett
2018-07-14 19:04 ` Eric W. Biederman [this message]
2018-07-14 19:10 ` Josh Triplett
2018-07-14 19:39 ` Eric W. Biederman
2018-07-14 20:16 ` Josh Triplett
2018-07-14 20:19 ` Cyrill Gorcunov
2018-07-13 8:23 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnzpvdtd.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=adrian@lisas.de \
--cc=akpm@linux-foundation.org \
--cc=avagin@virtuozzo.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.