From: Juan Quintela <quintela@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>,
Thomas Huth <thuth@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 15/20] tests: New helper qtest_qmp_receive_success()
Date: Thu, 12 Jul 2018 13:22:59 +0200 [thread overview]
Message-ID: <87pnzslmuk.fsf@secure.mitica> (raw)
In-Reply-To: <20180712111221.20326-16-armbru@redhat.com> (Markus Armbruster's message of "Thu, 12 Jul 2018 13:12:16 +0200")
Markus Armbruster <armbru@redhat.com> wrote:
> Commit b21373d0713 copied wait_command() from tests/migration-test.c
> to tests/tpm-util.c. Replace both copies by new libqtest helper
> qtest_qmp_receive_success(). Also use it to simplify
> qtest_qmp_device_del().
>
> Bonus: gets rid of a non-literal format string. A step towards
> compile-time format string checking without triggering
> -Wformat-nonliteral.
>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2018-07-12 11:23 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 11:12 [Qemu-devel] [PATCH 00/20] tests: Compile-time format string checking for libqtest.h Markus Armbruster
2018-07-12 11:12 ` [Qemu-devel] [PATCH 01/20] libqtest: Document calling conventions Markus Armbruster
2018-07-12 11:12 ` [Qemu-devel] [PATCH 02/20] libqtest: Rename functions to send QMP messages Markus Armbruster
2018-07-12 14:21 ` Philippe Mathieu-Daudé
2018-07-12 11:12 ` [Qemu-devel] [PATCH 03/20] libqtest: Clean up how we read device_del messages Markus Armbruster
2018-07-12 14:22 ` Philippe Mathieu-Daudé
2018-07-12 16:24 ` Thomas Huth
2018-07-12 11:12 ` [Qemu-devel] [PATCH 04/20] libqtest: Clean up how we read the QMP greeting Markus Armbruster
2018-07-12 16:26 ` Thomas Huth
2018-07-16 6:16 ` Markus Armbruster
2018-07-12 11:12 ` [Qemu-devel] [PATCH 05/20] qobject: Replace qobject_from_jsonf() by qobject_from_jsonf_nofail() Markus Armbruster
2018-07-12 18:17 ` Thomas Huth
2018-07-16 6:17 ` Markus Armbruster
2018-07-12 11:12 ` [Qemu-devel] [PATCH 06/20] qobject: New qobject_from_vjsonf_nofail(), qdict_from_vjsonf_nofail() Markus Armbruster
2018-07-12 14:06 ` Philippe Mathieu-Daudé
2018-07-12 11:12 ` [Qemu-devel] [PATCH 07/20] libqtest: Simplify qmp_fd_vsend() a bit Markus Armbruster
2018-07-12 14:07 ` Philippe Mathieu-Daudé
2018-07-12 11:12 ` [Qemu-devel] [PATCH 08/20] test-qobject-input-visitor: Avoid format string ambiguity Markus Armbruster
2018-07-12 11:12 ` [Qemu-devel] [PATCH 09/20] qobject: qobject_from_jsonv() is dangerous, hide it away Markus Armbruster
2018-07-12 14:09 ` Philippe Mathieu-Daudé
2018-07-12 11:12 ` [Qemu-devel] [PATCH 10/20] tests: Pass literal format strings directly to qmp_FOO() Markus Armbruster
2018-07-12 14:03 ` Philippe Mathieu-Daudé
2018-07-12 11:12 ` [Qemu-devel] [PATCH 11/20] tests: Clean up string interpolation into QMP input (simple cases) Markus Armbruster
2018-07-12 14:30 ` Philippe Mathieu-Daudé
2018-07-16 6:27 ` Markus Armbruster
2018-07-12 11:12 ` [Qemu-devel] [PATCH 12/20] cpu-plug-test: Don't pass integers as strings to device_add Markus Armbruster
2018-07-12 14:31 ` Philippe Mathieu-Daudé
2018-07-12 15:38 ` Thomas Huth
2018-07-12 11:12 ` [Qemu-devel] [PATCH 13/20] tests: Clean up string interpolation around qtest_qmp_device_add() Markus Armbruster
2018-07-12 11:12 ` [Qemu-devel] [PATCH 14/20] migration-test: Make wait_command() return the "return" member Markus Armbruster
2018-07-12 11:21 ` Juan Quintela
2018-07-12 11:12 ` [Qemu-devel] [PATCH 15/20] tests: New helper qtest_qmp_receive_success() Markus Armbruster
2018-07-12 11:22 ` Juan Quintela [this message]
2018-07-13 1:35 ` Stefan Berger
2018-07-12 11:12 ` [Qemu-devel] [PATCH 16/20] migration-test: Make wait_command() cope with '%' Markus Armbruster
2018-07-12 11:23 ` Juan Quintela
2018-07-12 11:12 ` [Qemu-devel] [PATCH 17/20] migration-test: Clean up string interpolation into QMP, part 1 Markus Armbruster
2018-07-12 11:25 ` Juan Quintela
2018-07-16 6:37 ` Markus Armbruster
2018-07-12 11:12 ` [Qemu-devel] [PATCH 18/20] migration-test: Clean up string interpolation into QMP, part 2 Markus Armbruster
2018-07-12 11:27 ` Juan Quintela
2018-07-12 11:12 ` [Qemu-devel] [PATCH 19/20] migration-test: Clean up string interpolation into QMP, part 3 Markus Armbruster
2018-07-12 11:31 ` Juan Quintela
2018-07-12 11:12 ` [Qemu-devel] [PATCH 20/20] libqtest: Enable compile-time format string checking Markus Armbruster
2018-07-12 14:16 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnzslmuk.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.