All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Oscar Mateo <oscar.mateo@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 11/11] drm/i915/icl: Wa_1406463099
Date: Tue, 29 May 2018 15:40:03 +0300	[thread overview]
Message-ID: <87po1e7hzw.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <1527285939-20113-12-git-send-email-oscar.mateo@intel.com>

Oscar Mateo <oscar.mateo@intel.com> writes:

> Prevents an error in the GAM unit. Also known as WaGamTlbPendError
>
> References: HSDES#1406463099
> References: HSDES#1406465643
> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_reg.h          | 5 +++--
>  drivers/gpu/drm/i915/intel_workarounds.c | 7 +++++++
>  2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 42835d79..8a18447 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -2306,8 +2306,9 @@ enum i915_power_well_id {
>  #define   GAMW_ECO_ENABLE_64K_IPS_FIELD 0xF
>  
>  #define GAMT_CHKN_BIT_REG	_MMIO(0x4ab8)
> -#define   GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING	(1<<28)
> -#define   GAMT_CHKN_DISABLE_I2M_CYCLE_ON_WR_PORT	(1<<24)
> +#define   GAMT_CHKN_DISABLE_L3_COH_PIPE			(1 << 31)
> +#define   GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING	(1 << 28)
> +#define   GAMT_CHKN_DISABLE_I2M_CYCLE_ON_WR_PORT	(1 << 24)
>  
>  #if 0
>  #define PRB0_TAIL	_MMIO(0x2030)
> diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
> index 474e498..77929df 100644
> --- a/drivers/gpu/drm/i915/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/intel_workarounds.c
> @@ -859,6 +859,13 @@ static void icl_gt_workarounds_apply(struct drm_i915_private *dev_priv)
>  		   PMFLUSHDONE_LNICRSDROP |
>  		   PMFLUSH_GAPL3UNBLOCK |
>  		   PMFLUSHDONE_LNEBLK);
> +
> +	/* Wa_1406463099:icl
> +	 * Formerly known as WaGamTlbPendError
> +	 */
> +	I915_WRITE(GAMT_CHKN_BIT_REG,
> +		   I915_READ(GAMT_CHKN_BIT_REG) |
> +		   GAMT_CHKN_DISABLE_L3_COH_PIPE);
>  }
>  
>  void intel_gt_workarounds_apply(struct drm_i915_private *dev_priv)
> -- 
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-05-29 12:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 22:05 [PATCH v4 00/11] Workarounds for Icelake Oscar Mateo
2018-05-25 22:05 ` [PATCH 01/11] drm/i915/icl: WaDisableImprovedTdlClkGating Oscar Mateo
2018-05-29  8:51   ` Mika Kuoppala
2018-05-25 22:05 ` [PATCH 02/11] drm/i915/icl: WaEnableStateCacheRedirectToCS Oscar Mateo
2018-05-29  9:15   ` Mika Kuoppala
2018-05-25 22:05 ` [PATCH 03/11] drm/i915/icl: Wa_2006665173 Oscar Mateo
2018-05-29 10:37   ` Mika Kuoppala
2018-05-25 22:05 ` [PATCH 04/11] drm/i915/icl: WaEnableFloatBlendOptimization Oscar Mateo
2018-05-29 12:07   ` Mika Kuoppala
2018-05-29 12:47     ` Lionel Landwerlin
2018-05-29 19:13       ` Anuj Phogat
2018-07-23 12:03   ` Chris Wilson
2018-05-25 22:05 ` [PATCH 05/11] drm/i915/icl: WaSendPushConstantsFromMMIO Oscar Mateo
2018-05-25 22:05 ` [PATCH 06/11] drm/i915/icl: WaAllowUMDToModifyHalfSliceChicken2 Oscar Mateo
2018-05-25 22:05 ` [PATCH 07/11] drm/i915/icl: WaAllowUMDToModifyHalfSliceChicken7 Oscar Mateo
2018-05-25 22:05 ` [PATCH 08/11] drm/i915/icl: WaAllowUmdWriteTRTTRootTable Oscar Mateo
2018-05-25 22:05 ` [PATCH 09/11] drm/i915/icl: WaAllowUMDToModifySamplerMode Oscar Mateo
2018-05-25 22:05 ` [PATCH 10/11] drm/i915/icl: WaEnablePreemptionGranularityControlByUMD Oscar Mateo
2018-05-25 22:05 ` [PATCH 11/11] drm/i915/icl: Wa_1406463099 Oscar Mateo
2018-05-29 12:40   ` Mika Kuoppala [this message]
2018-05-25 22:57 ` ✓ Fi.CI.BAT: success for Workarounds for Icelake (rev4) Patchwork
2018-05-26  9:37 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-29 13:03 ` [PATCH v4 00/11] Workarounds for Icelake Mika Kuoppala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87po1e7hzw.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=oscar.mateo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.