From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report Date: Tue, 24 Apr 2018 18:20:38 +0200 Message-ID: <87po2obmp5.fsf@dusky.pond.sub.org> References: <1524156319-11465-1-git-send-email-ian.jackson@eu.citrix.com> <1524156319-11465-16-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fB0gN-00059q-LT for xen-devel@lists.xenproject.org; Tue, 24 Apr 2018 16:20:43 +0000 In-Reply-To: ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Thu, 19 Apr 2018 17:31:50 -0300") List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Juergen Gross , Stefano Stabellini , Ian Jackson , Michael Tokarev , qemu-devel@nongnu.org, Alistair Francis , Ross Lagerwall , Paolo Bonzini , Anthony PERARD , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org UGhpbGlwcGUgTWF0aGlldS1EYXVkw6kgPGY0YnVnQGFtc2F0Lm9yZz4gd3JpdGVzOgoKPiBPbiAw NC8xOS8yMDE4IDAxOjQ1IFBNLCBJYW4gSmFja3NvbiB3cm90ZToKPj4gcGVycm9yKCkgaXMgZGVm aW5lZCB0byBmcHJpbnRmKHN0ZGVyciwuLi4pLiAgSEFDS0lORyBzYXlzCj4+IGZwcmludGYoc3Rk ZXJyLC4uLikgaXMgd3JvbmcuICBTbyBwZXJyb3IoKSBpcyB0b28uCj4+IAo+PiBTaWduZWQtb2Zm LWJ5OiBJYW4gSmFja3NvbiA8SWFuLkphY2tzb25AZXUuY2l0cml4LmNvbT4KPj4gQ0M6IFBhb2xv IEJvbnppbmkgPHBib256aW5pQHJlZGhhdC5jb20+Cj4+IENDOiBNYXJrdXMgQXJtYnJ1c3RlciA8 YXJtYnJ1QHJlZGhhdC5jb20+Cj4+IENDOiBEYW5pZWwgUC4gQmVycmFuZ2UgPGJlcnJhbmdlQHJl ZGhhdC5jb20+Cj4+IENDOiBNaWNoYWVsIFRva2FyZXYgPG1qdEB0bHMubXNrLnJ1Pgo+PiBDQzog QWxpc3RhaXIgRnJhbmNpcyA8YWxpc3RhaXIuZnJhbmNpc0B4aWxpbnguY29tPgo+PiAtLS0KPj4g djc6IE5ldyBwYXRjaAo+PiAtLS0KPj4gIG9zLXBvc2l4LmMgfCA4ICsrKystLS0tCj4+ICAxIGZp bGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+PiAKPj4gZGlmZiAt LWdpdCBhL29zLXBvc2l4LmMgYi9vcy1wb3NpeC5jCj4+IGluZGV4IGQ0Y2Y0NjYuLjAxMDgwMjgg MTAwNjQ0Cj4+IC0tLSBhL29zLXBvc2l4LmMKPj4gKysrIGIvb3MtcG9zaXguYwo+PiBAQCAtMTI1 LDcgKzEyNSw3IEBAIHZvaWQgb3Nfc2V0X3Byb2NfbmFtZShjb25zdCBjaGFyICpzKQo+PiAgICAg IC8qIENvdWxkIHJld3JpdGUgYXJndlswXSB0b28sIGJ1dCB0aGF0J3MgYSBiaXQgbW9yZSBjb21w bGljYXRlZC4KPj4gICAgICAgICBUaGlzIHNpbXBsZSB3YXkgaXMgZW5vdWdoIGZvciBgdG9wJy4g Ki8KPj4gICAgICBpZiAocHJjdGwoUFJfU0VUX05BTUUsIG5hbWUpKSB7Cj4+IC0gICAgICAgIHBl cnJvcigidW5hYmxlIHRvIGNoYW5nZSBwcm9jZXNzIG5hbWUiKTsKPj4gKyAgICAgICAgZXJyb3Jf cmVwb3J0KCJ1bmFibGUgdG8gY2hhbmdlIHByb2Nlc3MgbmFtZTogJXMiLCBzdHJlcnJvcihlcnJu bykpOwo+PiAgICAgICAgICBleGl0KDEpOwo+PiAgICAgIH0KPj4gICNlbHNlCj4+IEBAIC0yNDcs NyArMjQ3LDcgQEAgc3RhdGljIHZvaWQgY2hhbmdlX3Jvb3Qodm9pZCkKPj4gICAgICAgICAgICAg IGV4aXQoMSk7Cj4+ICAgICAgICAgIH0KPj4gICAgICAgICAgaWYgKGNoZGlyKCIvIikpIHsKPj4g LSAgICAgICAgICAgIHBlcnJvcigibm90IGFibGUgdG8gY2hkaXIgdG8gLyIpOwo+PiArICAgICAg ICAgICAgZXJyb3JfcmVwb3J0KCJub3QgYWJsZSB0byBjaGRpciB0byAvOiAlcyIsIHN0cmVycm9y KGVycm5vKSk7Cj4+ICAgICAgICAgICAgICBleGl0KDEpOwo+PiAgICAgICAgICB9Cj4+ICAgICAg fQo+PiBAQCAtMzA5LDcgKzMwOSw3IEBAIHZvaWQgb3Nfc2V0dXBfcG9zdCh2b2lkKQo+PiAgCj4+ ICAgICAgaWYgKGRhZW1vbml6ZSkgewo+PiAgICAgICAgICBpZiAoY2hkaXIoIi8iKSkgewo+PiAt ICAgICAgICAgICAgcGVycm9yKCJub3QgYWJsZSB0byBjaGRpciB0byAvIik7Cj4+ICsgICAgICAg ICAgICBlcnJvcl9yZXBvcnQoIm5vdCBhYmxlIHRvIGNoZGlyIHRvIC86ICVzIiwgc3RyZXJyb3Io ZXJybm8pKTsKPj4gICAgICAgICAgICAgIGV4aXQoMSk7Cj4+ICAgICAgICAgIH0KPj4gICAgICAg ICAgVEZSKGZkID0gcWVtdV9vcGVuKCIvZGV2L251bGwiLCBPX1JEV1IpKTsKPj4gQEAgLTM4Myw3 ICszODMsNyBAQCBpbnQgb3NfbWxvY2sodm9pZCkKPj4gIAo+PiAgICAgIHJldCA9IG1sb2NrYWxs KE1DTF9DVVJSRU5UIHwgTUNMX0ZVVFVSRSk7Cj4+ICAgICAgaWYgKHJldCA8IDApIHsKPj4gLSAg ICAgICAgcGVycm9yKCJtbG9ja2FsbCIpOwo+PiArICAgICAgICBlcnJvcl9yZXBvcnQoIm1sb2Nr YWxsOiAlcyIsIHN0cmVycm9yKGVycm5vKSk7Cj4+ICAgICAgfQo+PiAgCj4+ICAgICAgcmV0dXJu IHJldDsKPgo+IFRoaW5raW5nIGxvdWRseSwgbWF5YmUgd2UgY2FuIHJlZmFjdG9yIGFzIGVycm9y X3JlcG9ydF9lcnJubyhjb25zdCBjaGFyCj4gKmRlc2MpLi4uCgpNYXliZS4gIElmIHlvdSB3YW50 IHRvIHRyeSwgbWFrZSBpdCBhIHNlcGFyYXRlIHNlcmllcyBub3QgYmxvY2tpbmcgdGhpcwpvbmUu Cgo+IEFueXdheToKPiBSZXZpZXdlZC1ieTogUGhpbGlwcGUgTWF0aGlldS1EYXVkw6kgPGY0YnVn QGFtc2F0Lm9yZz4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3Jn Cmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fB0gQ-0001rM-8i for qemu-devel@nongnu.org; Tue, 24 Apr 2018 12:20:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fB0gM-0002VS-7k for qemu-devel@nongnu.org; Tue, 24 Apr 2018 12:20:46 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48938 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fB0gL-0002V6-Qo for qemu-devel@nongnu.org; Tue, 24 Apr 2018 12:20:41 -0400 From: Markus Armbruster References: <1524156319-11465-1-git-send-email-ian.jackson@eu.citrix.com> <1524156319-11465-16-git-send-email-ian.jackson@eu.citrix.com> Date: Tue, 24 Apr 2018 18:20:38 +0200 In-Reply-To: ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Thu, 19 Apr 2018 17:31:50 -0300") Message-ID: <87po2obmp5.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Ian Jackson , qemu-devel@nongnu.org, Juergen Gross , Stefano Stabellini , Michael Tokarev , Alistair Francis , Ross Lagerwall , xen-devel@lists.xenproject.org, Anthony PERARD , Paolo Bonzini Philippe Mathieu-Daud=C3=A9 writes: > On 04/19/2018 01:45 PM, Ian Jackson wrote: >> perror() is defined to fprintf(stderr,...). HACKING says >> fprintf(stderr,...) is wrong. So perror() is too. >>=20 >> Signed-off-by: Ian Jackson >> CC: Paolo Bonzini >> CC: Markus Armbruster >> CC: Daniel P. Berrange >> CC: Michael Tokarev >> CC: Alistair Francis >> --- >> v7: New patch >> --- >> os-posix.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >>=20 >> diff --git a/os-posix.c b/os-posix.c >> index d4cf466..0108028 100644 >> --- a/os-posix.c >> +++ b/os-posix.c >> @@ -125,7 +125,7 @@ void os_set_proc_name(const char *s) >> /* Could rewrite argv[0] too, but that's a bit more complicated. >> This simple way is enough for `top'. */ >> if (prctl(PR_SET_NAME, name)) { >> - perror("unable to change process name"); >> + error_report("unable to change process name: %s", strerror(errn= o)); >> exit(1); >> } >> #else >> @@ -247,7 +247,7 @@ static void change_root(void) >> exit(1); >> } >> if (chdir("/")) { >> - perror("not able to chdir to /"); >> + error_report("not able to chdir to /: %s", strerror(errno)); >> exit(1); >> } >> } >> @@ -309,7 +309,7 @@ void os_setup_post(void) >>=20=20 >> if (daemonize) { >> if (chdir("/")) { >> - perror("not able to chdir to /"); >> + error_report("not able to chdir to /: %s", strerror(errno)); >> exit(1); >> } >> TFR(fd =3D qemu_open("/dev/null", O_RDWR)); >> @@ -383,7 +383,7 @@ int os_mlock(void) >>=20=20 >> ret =3D mlockall(MCL_CURRENT | MCL_FUTURE); >> if (ret < 0) { >> - perror("mlockall"); >> + error_report("mlockall: %s", strerror(errno)); >> } >>=20=20 >> return ret; > > Thinking loudly, maybe we can refactor as error_report_errno(const char > *desc)... Maybe. If you want to try, make it a separate series not blocking this one. > Anyway: > Reviewed-by: Philippe Mathieu-Daud=C3=A9