From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: drivers/gpu/drm/bridge/lvds-encoder.c broken in mainline Date: Mon, 13 Nov 2017 13:03:07 -0800 Message-ID: <87po8lnb78.fsf@anholt.net> References: <20171107150628.0939da18@karo-electronics.de> <87vaiky6qs.fsf@anholt.net> <20171109161514.6b5e4fa3@karo-electronics.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0700476425==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id D73276E78D for ; Mon, 13 Nov 2017 21:03:09 +0000 (UTC) In-Reply-To: <20171109161514.6b5e4fa3@karo-electronics.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lothar =?utf-8?Q?Wa=C3=9Fmann?= Cc: Daniel Vetter , dri-devel@lists.freedesktop.org, Boris Brezillon List-Id: dri-devel@lists.freedesktop.org --===============0700476425== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Lothar Wa=C3=9Fmann writes: > Hi, > > On Wed, 08 Nov 2017 10:18:03 -0800 Eric Anholt wrote: >> Lothar Wa=C3=9Fmann writes: >>=20 >> > Hi, >> > >> > drivers/gpu/drm/bridge/lvds-encoder.c driver is currently >> > dysfunctional due to: >> > |commit 13dfc0540a575b47b2d640b093ac16e9e09474f6 >> > |Author: Eric Anholt >> > |Date: Fri Jun 2 13:25:14 2017 -0700 >> > | >> > | drm/bridge: Refactor out the panel wrapper from the lvds-encoder = bridge. >> > >> > Also, there is no in-kernel user of this driver, so that it obviously >> > doesn't get tested in any way. There is only one dts file (r8a7779-mar= zen.dts) >> > that instantiates this driver, but it has an incomplete OF graph. The = missing >> > link for the OF graph is provided by either r8a77xx-aa104xd12-panel.dt= si or >> > r8a77xx-aa121td01-panel.dtsi, but those files are referenced nowhere in >> > the kernel source. >> > >> > Should the driver be removed or moved to staging, until it is properly >> > fixed? >>=20 >> I can't see any behavior change about the DT handling in that commit, >> and I didn't intend for there to be any. Could you help me understand >> what went wrong? >> > With the offending commit applied, the lvds-encoder driver is being > attached to the device associated with the lcd-panel driver's of_node > (panel-simple in my case) rather than the lvds-encoder's of_node. Anyone have any thoughts on best handling this? Slip another bridge in attached to this of_node that chains to panel-bridge's bridge, or just have a panel-bridge entrypoint for what node to register the bridge on? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAloKCIsACgkQtdYpNtH8 nugCqA/9EOrgC73sWUe2XFaeWnLuyoU84P4xT4asBYQFGXGBtRvgB94lwX/KPgzT P/jmJTBHa7PwXTxH1nBcDwFu7DAc7DBfKyFb7zujEFaf/ifM+pjbrhSGTPTmxTps Tza4nepL/EklFh+NIEmZu5nuc2wp1Pz7hKyrEjdYXNdx79DJ7RXs/ia8qQro1voI Pnlrm48j4CLSg/UlJFRPD+AQNr93wAbnOo8cVB9WAIHdHNeDcp0GNzxrZSbvpzgY pSqfW5SklB/wSiXWZD3QqXgOCqIRc2I27itbZHS7lbxsgCCVYx7IEQ7rDBOeuFzS NCPWaQ6AvE1TTUP8fButsKaXbi0p1QDw6EwnaxeXV0Q8o0+Y49vZPspF6N0jBLk9 8+a5RP8TTRWPSL+j0UTDzBlJSMMm5Gh4ooh/aJofsHPzrfuLanhV2pXiIVhQZvYJ 7tw8ciBbI3uUdW8enenNNKQOQDxM2wLn4qdSoyxfQK+YWtDiCiRq+/czs18jN+vp nLB+bRD+ygqaSkOKJc+ugJIE47r7qwSzLT1yZ72osqRPmZIJq4E6d6/cFuPVraYJ YSXsASwBFVgWDcOWvc+UVPIVYlOkl43WgLp+WAybQ9nysXSnNpbkctEdaTL1tKNv S45QZYLpo3GHiIc0TkRPqhcFxIuX9DEaeqDtr5HUhDN2+DG7L2M= =Al0c -----END PGP SIGNATURE----- --=-=-=-- --===============0700476425== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0700476425==--