* drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
@ 2017-10-23 19:38 David Binderman
2017-10-24 8:54 ` Jani Nikula
0 siblings, 1 reply; 6+ messages in thread
From: David Binderman @ 2017-10-23 19:38 UTC (permalink / raw)
To: patrik.r.jakobsson@gmail.com, airlied@linux.ie,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Hello there,
Source code is
if ((temp & PIPEACONF_PIPE_STATE) == 1)
break;
but
$ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print`
drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE (1 << 30)
$
Suggest new code
if ((temp & PIPEACONF_PIPE_STATE) != 0)
break;
Regards
David Binderman
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
2017-10-23 19:38 drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare] David Binderman
@ 2017-10-24 8:54 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2017-10-24 8:54 UTC (permalink / raw)
To: David Binderman, patrik.r.jakobsson@gmail.com, airlied@linux.ie,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
On Mon, 23 Oct 2017, David Binderman <dcb314@hotmail.com> wrote:
> Hello there,
>
> Source code is
>
> if ((temp & PIPEACONF_PIPE_STATE) == 1)
> break;
>
> but
>
> $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print`
> drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE (1 << 30)
> $
>
> Suggest new code
>
> if ((temp & PIPEACONF_PIPE_STATE) != 0)
> break;
Suggest looking at latest sources. ;)
Fixed by 67a3b63a54cb ("drm: gma500: fix logic error").
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
@ 2017-10-24 8:54 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2017-10-24 8:54 UTC (permalink / raw)
To: David Binderman, patrik.r.jakobsson@gmail.com, airlied@linux.ie,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
On Mon, 23 Oct 2017, David Binderman <dcb314@hotmail.com> wrote:
> Hello there,
>
> Source code is
>
> if ((temp & PIPEACONF_PIPE_STATE) == 1)
> break;
>
> but
>
> $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print`
> drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE (1 << 30)
> $
>
> Suggest new code
>
> if ((temp & PIPEACONF_PIPE_STATE) != 0)
> break;
Suggest looking at latest sources. ;)
Fixed by 67a3b63a54cb ("drm: gma500: fix logic error").
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
2017-10-24 8:54 ` Jani Nikula
(?)
@ 2017-10-24 9:07 ` David Binderman
2017-10-24 9:46 ` Jani Nikula
-1 siblings, 1 reply; 6+ messages in thread
From: David Binderman @ 2017-10-24 9:07 UTC (permalink / raw)
To: Jani Nikula, patrik.r.jakobsson@gmail.com, airlied@linux.ie,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
[-- Attachment #1.1: Type: text/plain, Size: 1343 bytes --]
Hello there,
Code I looked at is in linux-4.14-rc6, released 20171023, so reasonably
up to date.
I did a further check on github.com/torvalds/linux and the code
looks wrong there, too.
So I don't see the fix you mentioned in either of the places I looked.
Regards
David Binderman
________________________________
From: Jani Nikula <jani.nikula@linux.intel.com>
Sent: 24 October 2017 08:54
To: David Binderman; patrik.r.jakobsson@gmail.com; airlied@linux.ie; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
Subject: Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
On Mon, 23 Oct 2017, David Binderman <dcb314@hotmail.com> wrote:
> Hello there,
>
> Source code is
>
> if ((temp & PIPEACONF_PIPE_STATE) == 1)
> break;
>
> but
>
> $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print`
> drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE (1 << 30)
> $
>
> Suggest new code
>
> if ((temp & PIPEACONF_PIPE_STATE) != 0)
> break;
Suggest looking at latest sources. ;)
Fixed by 67a3b63a54cb ("drm: gma500: fix logic error").
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
[-- Attachment #1.2: Type: text/html, Size: 2648 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
2017-10-24 9:07 ` David Binderman
@ 2017-10-24 9:46 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2017-10-24 9:46 UTC (permalink / raw)
To: David Binderman, patrik.r.jakobsson@gmail.com, airlied@linux.ie,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
On Tue, 24 Oct 2017, David Binderman <dcb314@hotmail.com> wrote:
> Hello there,
>
>
> Code I looked at is in linux-4.14-rc6, released 20171023, so reasonably
>
> up to date.
>
>
> I did a further check on github.com/torvalds/linux and the code
>
> looks wrong there, too.
>
>
> So I don't see the fix you mentioned in either of the places I looked.
It's in drm-next branch of [1] heading for v4.15. Please see MAINTAINERS
in the kernel source root for all the trees.
BR,
Jani.
[1] https://cgit.freedesktop.org/~airlied/linux/
>
>
> Regards
>
>
> David Binderman
>
> ________________________________
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: 24 October 2017 08:54
> To: David Binderman; patrik.r.jakobsson@gmail.com; airlied@linux.ie; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
> Subject: Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
>
> On Mon, 23 Oct 2017, David Binderman <dcb314@hotmail.com> wrote:
>> Hello there,
>>
>> Source code is
>>
>> if ((temp & PIPEACONF_PIPE_STATE) == 1)
>> break;
>>
>> but
>>
>> $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print`
>> drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE (1 << 30)
>> $
>>
>> Suggest new code
>>
>> if ((temp & PIPEACONF_PIPE_STATE) != 0)
>> break;
>
> Suggest looking at latest sources. ;)
>
> Fixed by 67a3b63a54cb ("drm: gma500: fix logic error").
>
> BR,
> Jani.
>
> --
> Jani Nikula, Intel Open Source Technology Center
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
@ 2017-10-24 9:46 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2017-10-24 9:46 UTC (permalink / raw)
To: David Binderman, patrik.r.jakobsson@gmail.com, airlied@linux.ie,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
On Tue, 24 Oct 2017, David Binderman <dcb314@hotmail.com> wrote:
> Hello there,
>
>
> Code I looked at is in linux-4.14-rc6, released 20171023, so reasonably
>
> up to date.
>
>
> I did a further check on github.com/torvalds/linux and the code
>
> looks wrong there, too.
>
>
> So I don't see the fix you mentioned in either of the places I looked.
It's in drm-next branch of [1] heading for v4.15. Please see MAINTAINERS
in the kernel source root for all the trees.
BR,
Jani.
[1] https://cgit.freedesktop.org/~airlied/linux/
>
>
> Regards
>
>
> David Binderman
>
> ________________________________
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: 24 October 2017 08:54
> To: David Binderman; patrik.r.jakobsson@gmail.com; airlied@linux.ie; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
> Subject: Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
>
> On Mon, 23 Oct 2017, David Binderman <dcb314@hotmail.com> wrote:
>> Hello there,
>>
>> Source code is
>>
>> if ((temp & PIPEACONF_PIPE_STATE) == 1)
>> break;
>>
>> but
>>
>> $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print`
>> drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE (1 << 30)
>> $
>>
>> Suggest new code
>>
>> if ((temp & PIPEACONF_PIPE_STATE) != 0)
>> break;
>
> Suggest looking at latest sources. ;)
>
> Fixed by 67a3b63a54cb ("drm: gma500: fix logic error").
>
> BR,
> Jani.
>
> --
> Jani Nikula, Intel Open Source Technology Center
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-24 21:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-23 19:38 drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare] David Binderman
2017-10-24 8:54 ` Jani Nikula
2017-10-24 8:54 ` Jani Nikula
2017-10-24 9:07 ` David Binderman
2017-10-24 9:46 ` Jani Nikula
2017-10-24 9:46 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.