From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare] Date: Tue, 24 Oct 2017 11:54:05 +0300 Message-ID: <87po9dhqoi.fsf@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: David Binderman , "patrik.r.jakobsson@gmail.com" , "airlied@linux.ie" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" List-Id: dri-devel@lists.freedesktop.org On Mon, 23 Oct 2017, David Binderman wrote: > Hello there, > > Source code is > > if ((temp & PIPEACONF_PIPE_STATE) == 1) > break; > > but > > $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print` > drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE (1 << 30) > $ > > Suggest new code > > if ((temp & PIPEACONF_PIPE_STATE) != 0) > break; Suggest looking at latest sources. ;) Fixed by 67a3b63a54cb ("drm: gma500: fix logic error"). BR, Jani. -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932454AbdJXIwm (ORCPT ); Tue, 24 Oct 2017 04:52:42 -0400 Received: from mga09.intel.com ([134.134.136.24]:32628 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbdJXIwj (ORCPT ); Tue, 24 Oct 2017 04:52:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,427,1503385200"; d="scan'208";a="913091436" From: Jani Nikula To: David Binderman , "patrik.r.jakobsson\@gmail.com" , "airlied\@linux.ie" , "dri-devel\@lists.freedesktop.org" , "linux-kernel\@vger.kernel.org" Subject: Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare] In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Tue, 24 Oct 2017 11:54:05 +0300 Message-ID: <87po9dhqoi.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Oct 2017, David Binderman wrote: > Hello there, > > Source code is > > if ((temp & PIPEACONF_PIPE_STATE) == 1) > break; > > but > > $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print` > drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE (1 << 30) > $ > > Suggest new code > > if ((temp & PIPEACONF_PIPE_STATE) != 0) > break; Suggest looking at latest sources. ;) Fixed by 67a3b63a54cb ("drm: gma500: fix logic error"). BR, Jani. -- Jani Nikula, Intel Open Source Technology Center