All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
To: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>,
	Loic Poulain
	<loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
	bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v5 2/2] ARM: dts: bcm2837-rpi-3-b: Add bcm43438 serial slave
Date: Fri, 06 Oct 2017 15:03:58 -0700	[thread overview]
Message-ID: <87poa0djch.fsf@anholt.net> (raw)
In-Reply-To: <C1D28787-A7C3-4A7A-8EAC-7E7994E54B29-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 2353 bytes --]

Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> writes:

> Hi,
>
>> Add BCM43438 (bluetooth) as a slave device of uart0 (pl011/ttyAMA0).
>> This allows to automatically insert the bcm43438 to the bluetooth
>> subsystem instead of relying on userspace helpers (hciattach).
>> 
>> Overwrite chosen/stdout-path to use 8250 aux uart as console.
>> 
>> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> Signed-off-by: Loic Poulain <loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>> arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>> 
>> v2: dt-bindings as separate patch
>>     rebase on upcoming pi3 dts changes
>> v3: changes in bcm serdev drivers:
>>     name refactoring and additional comments
>>     Add generic host_set_baudrate method
>>     Use agnostic device_property_read
>> v4: changes in doc and dts:
>>     Add additional params to broadcom bt dt-bindings
>>     Set the max baudrate to 2000000 instead of 921600
>>     use chosen/stdout-path instead of console=
>>     remove useless earlyprintk
>>     same changes in bcm283x.dtsi
>> v5: remove 1/4 dt-bindings and 4/4 hci_bcm serdev support
>>     1/4 and 4/4 merged in bluetooth-next tree
>> 
>> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> index 20725ca..e4488cb 100644
>> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> @@ -8,6 +8,11 @@
>> 	compatible = "raspberrypi,3-model-b", "brcm,bcm2837";
>> 	model = "Raspberry Pi 3 Model B";
>> 
>> +	chosen {
>> +		/* 8250 auxiliar UART instead of pl011 */
>> +		stdout-path = "serial1:115200n8";
>> +	};
>> +
>> 	memory {
>> 		reg = <0 0x40000000>;
>> 	};
>> @@ -24,6 +29,11 @@
>> 	pinctrl-names = "default";
>> 	pinctrl-0 = <&uart0_gpio32 &gpclk2_gpio43>;
>> 	status = "okay";
>> +
>> +	bluetooth {
>> +		compatible = "brcm,bcm43438-bt";
>> +		max-speed = <2000000>;
>> +	};
>> };
>> 
>
> the driver for this is already in Linus’ tree. And I would really prefer that we get the DT changes merged in as well.

Now that the separated stdout patch is ready to go, I've applied this
for -next (dropping the chosen node) and I'm sending the PR for both.

Thanks so much for working on this!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  parent reply	other threads:[~2017-10-06 22:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30 20:42 [PATCH v5 1/2] ARM: dts: bcm283x: Use stdout-path instead of console bootarg Loic Poulain
     [not found] ` <1504125721-4760-1-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-30 20:42   ` [PATCH v5 2/2] ARM: dts: bcm2837-rpi-3-b: Add bcm43438 serial slave Loic Poulain
     [not found]     ` <1504125721-4760-2-git-send-email-loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-08 12:53       ` Marcel Holtmann
     [not found]         ` <C1D28787-A7C3-4A7A-8EAC-7E7994E54B29-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-10-06 22:03           ` Eric Anholt [this message]
2017-09-08 12:52   ` [PATCH v5 1/2] ARM: dts: bcm283x: Use stdout-path instead of console bootarg Marcel Holtmann
     [not found]     ` <19D1F3B6-A05B-425B-A06D-AD44EEE39BFE-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-09-08 17:53       ` Eric Anholt
     [not found]         ` <874lsdnkk5.fsf-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
2017-09-08 18:04           ` Marcel Holtmann
     [not found]             ` <C7897D52-34DE-4EAD-BA79-67ED91929D85-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-09-08 18:23               ` Florian Fainelli
     [not found]                 ` <9153f30c-adf5-8563-8333-3ff2e2e46dc9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-08 18:35                   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87poa0djch.fsf@anholt.net \
    --to=eric-whkq6xtqapystnjn9+bgxg@public.gmane.org \
    --cc=bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
    --cc=rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.