Re: [PATCH 2/3] usb: xhci: Add DbC support in xHCI driver

[Felipe Balbi <felipe.balbi@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]


Hi,

Lu Baolu <baolu.lu@linux.intel.com> writes:
> +static void xhci_dbc_stop(struct xhci_hcd *xhci)
> +{
> +	struct xhci_dbc		*dbc = xhci->dbc;
> +
> +	WARN_ON(!dbc);
> +
> +	cancel_delayed_work_sync(&dbc->event_work);
> +
> +	if (dbc->gs_port_num != GSPORT_INVAL) {
> +		gserial_disconnect(&dbc->gs_port);
> +		gserial_free_line(dbc->gs_port_num);

why are you tying host stack to the gadget framework?

With this, you're forcing every single PC in the world to compile the
gadget framework, that's a bit much don't you think?

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]