From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result Date: Wed, 19 Jul 2017 11:49:47 +0300 Message-ID: <87pocwhkus.fsf@intel.com> References: <20170718142536.2306-1-paul.kocialkowski@linux.intel.com> <20170718192036.GB6173@intel.com> <1500453187.1329.3.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1500453187.1329.3.camel@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Kocialkowski , Manasi Navare Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAxOSBKdWwgMjAxNywgUGF1bCBLb2NpYWxrb3dza2kgPHBhdWwua29jaWFsa293c2tp QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gVHVlLCAyMDE3LTA3LTE4IGF0IDEyOjIwIC0w NzAwLCBNYW5hc2kgTmF2YXJlIHdyb3RlOgo+PiBPbiBUdWUsIEp1bCAxOCwgMjAxNyBhdCAwNToy NTozNlBNICswMzAwLCBQYXVsIEtvY2lhbGtvd3NraSB3cm90ZToKPj4gPiBUaGlzIGFkZHMgdGhl IGNvbm5lY3RvciBuYW1lIHdoZW4gcHJpbnRpbmcgYSBkZWJ1ZyBtZXNzYWdlIGFib3V0IHRoZQo+ PiA+IERQCj4+ID4gbGluayB0cmFpbmluZyByZXN1bHQuIEl0IGlzIHVzZWZ1bCB0byBmaWd1cmUg b3V0IHdoYXQgY29ubmVjdG9yIGlzCj4+ID4gZmFpbGluZyB3aGVuIG11bHRpcGxlIERQIGNvbm5l Y3RvcnMgYXJlIHVzZWQuCj4+ID4gCj4+IAo+PiBUaGFua3MgZm9yIHRoZSBwYXRjaCwgdGhpcyBk b2VzIG1ha2Ugc2Vuc2UgZHVyaW5nIHRoZSBsaW5rIHRyYWluaW5nCj4+IGZhaWx1cmUgZGVidWdn aW5nIHRvIGtub3cgdGhlIGNvbm5lY3RvciBuYW1lLgo+PiBXaGlsZSBhdCBpdCBmZWVsIGZyZWUg dG8gY2hhbmdlICJGYWlsZWQiLCAiTGluayBSYXRlLCBMYW5lIENvdW50IiwgdG8KPj4gdXBwZXIg Y2FzZQo+PiBpbiB0aGUgZmFpbHVyZV9oYW5kbGluZyBjYXNlIHRvIGJlIGNvbnNpc3RlbnQgd2l0 aCB0aGUgcGFzcyBjYXNlLgo+Cj4gVGhhbmtzIGZvciB0aGUgcmV2aWV3IQo+Cj4gTm93IHRoYXQg dGhlIHBhdGNoIHdhcyBtZXJnZWQsIGRvIHlvdSBmZWVsIGxpa2UgSSBzaG91bGQgbWFrZSBhIGZv bGxvdy0KPiB1cCBwYXRjaCB0byBmaXggY29uc2lzdGVuY3kgaW4gdGhlIHVwcGVyIGNhc2UgdXNl IG9yIGlzIGl0IGVub3VnaCBvZiBhCj4gZGV0YWlsIHRoYXQgd2UgY2FuIGp1c3QgZm9yZ2V0IGFi b3V0IGl0PwoKSWYgaXQgYm90aGVycyB5b3UsIHNlbmQgYSBwYXRjaCwgb3RoZXJ3aXNlIHdhaXQg Zm9yIGl0IHRvIGJvdGhlciBzb21lb25lCmVsc2UgZW5vdWdoIHRvIHNlbmQgYSBwYXRjaC4gOykK CkJ1dCBwbGVhc2UgYXZvaWQgdGhlIG92ZXJ1c2Ugb2YgYWxsIGNhcHMgZm9yIHJlZ3VsYXIgd29y ZHMsIG9yCmNhcGl0YWxpemF0aW9uIGV4Y2VwdCBhdCB0aGUgYmVnaW5uaW5nIG9mIHNlbnRlbmNl cy4gSSdkIGdvIHdpdGgKc29tZXRoaW5nIGxpa2UgdGhpcyBhbGwgb3ZlciB0aGUgcGxhY2U6Cgoi TGluayB0cmFpbmluZyBmYWlsZWQsIGxpbmsgcmF0ZSAlZCwgbGFuZSBjb3VudCAlZFxuIgoKQnV0 IGl0IGhhc24ndCBib3RoZXJlZCBtZSBlbm91Z2ggdG8gc2VuZCBhIHBhdGNoLiA7KQoKQlIsCkph bmkuCgoKCj4KPj4gUmV2aWV3ZWQtYnk6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBp bnRlbC5jb20+Cj4+IAo+PiBNYW5hc2kKPj4gCj4+ID4gU2lnbmVkLW9mZi1ieTogUGF1bCBLb2Np YWxrb3dza2kgPHBhdWwua29jaWFsa293c2tpQGxpbnV4LmludGVsLmNvbT4KPj4gPiAtLS0KPj4g PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5jIHwgOCArKysr KystLQo+PiA+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQo+PiA+IAo+PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9s aW5rX3RyYWluaW5nLmMKPj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX2xpbmtf dHJhaW5pbmcuYwo+PiA+IGluZGV4IGI3OWMxYzBlNDA0Yy4uMDU5MDdmYThhNTUzIDEwMDY0NAo+ PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX2xpbmtfdHJhaW5pbmcuYwo+ PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX2xpbmtfdHJhaW5pbmcuYwo+ PiA+IEBAIC0zMjEsMTIgKzMyMSwxNiBAQCBpbnRlbF9kcF9zdGFydF9saW5rX3RyYWluKHN0cnVj dCBpbnRlbF9kcAo+PiA+ICppbnRlbF9kcCkKPj4gPiAgCWlmICghaW50ZWxfZHBfbGlua190cmFp bmluZ19jaGFubmVsX2VxdWFsaXphdGlvbihpbnRlbF9kcCkpCj4+ID4gIAkJZ290byBmYWlsdXJl X2hhbmRsaW5nOwo+PiA+ICAKPj4gPiAtCURSTV9ERUJVR19LTVMoIkxpbmsgVHJhaW5pbmcgUGFz c2VkIGF0IExpbmsgUmF0ZSA9ICVkLCBMYW5lCj4+ID4gY291bnQgPSAlZCIsCj4+ID4gKwlEUk1f REVCVUdfS01TKCJbQ09OTkVDVE9SOiVkOiVzXSBMaW5rIFRyYWluaW5nIFBhc3NlZCBhdAo+PiA+ IExpbmsgUmF0ZSA9ICVkLCBMYW5lIGNvdW50ID0gJWQiLAo+PiA+ICsJCSAgICAgIGludGVsX2Nv bm5lY3Rvci0+YmFzZS5iYXNlLmlkLAo+PiA+ICsJCSAgICAgIGludGVsX2Nvbm5lY3Rvci0+YmFz ZS5uYW1lLAo+PiA+ICAJCSAgICAgIGludGVsX2RwLT5saW5rX3JhdGUsIGludGVsX2RwLT5sYW5l X2NvdW50KTsKPj4gPiAgCXJldHVybjsKPj4gPiAgCj4+ID4gICBmYWlsdXJlX2hhbmRsaW5nOgo+ PiA+IC0JRFJNX0RFQlVHX0tNUygiTGluayBUcmFpbmluZyBmYWlsZWQgYXQgbGluayByYXRlID0g JWQsIGxhbmUKPj4gPiBjb3VudCA9ICVkIiwKPj4gPiArCURSTV9ERUJVR19LTVMoIltDT05ORUNU T1I6JWQ6JXNdIExpbmsgVHJhaW5pbmcgZmFpbGVkIGF0Cj4+ID4gbGluayByYXRlID0gJWQsIGxh bmUgY291bnQgPSAlZCIsCj4+ID4gKwkJICAgICAgaW50ZWxfY29ubmVjdG9yLT5iYXNlLmJhc2Uu aWQsCj4+ID4gKwkJICAgICAgaW50ZWxfY29ubmVjdG9yLT5iYXNlLm5hbWUsCj4+ID4gIAkJICAg ICAgaW50ZWxfZHAtPmxpbmtfcmF0ZSwgaW50ZWxfZHAtPmxhbmVfY291bnQpOwo+PiA+ICAJaWYg KCFpbnRlbF9kcF9nZXRfbGlua190cmFpbl9mYWxsYmFja192YWx1ZXMoaW50ZWxfZHAsCj4+ID4g IAkJCQkJCSAgICAgaW50ZWxfZHAtCj4+ID4gPmxpbmtfcmF0ZSwKPj4gPiAtLSAKPj4gPiAyLjEz LjIKPj4gPiAKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBD ZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753320AbdGSIt5 (ORCPT ); Wed, 19 Jul 2017 04:49:57 -0400 Received: from mga01.intel.com ([192.55.52.88]:37079 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbdGSItv (ORCPT ); Wed, 19 Jul 2017 04:49:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,380,1496127600"; d="scan'208";a="880393106" From: Jani Nikula To: Paul Kocialkowski , Manasi Navare Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , David Airlie Subject: Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result In-Reply-To: <1500453187.1329.3.camel@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170718142536.2306-1-paul.kocialkowski@linux.intel.com> <20170718192036.GB6173@intel.com> <1500453187.1329.3.camel@linux.intel.com> Date: Wed, 19 Jul 2017 11:49:47 +0300 Message-ID: <87pocwhkus.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Jul 2017, Paul Kocialkowski wrote: > On Tue, 2017-07-18 at 12:20 -0700, Manasi Navare wrote: >> On Tue, Jul 18, 2017 at 05:25:36PM +0300, Paul Kocialkowski wrote: >> > This adds the connector name when printing a debug message about the >> > DP >> > link training result. It is useful to figure out what connector is >> > failing when multiple DP connectors are used. >> > >> >> Thanks for the patch, this does make sense during the link training >> failure debugging to know the connector name. >> While at it feel free to change "Failed", "Link Rate, Lane Count", to >> upper case >> in the failure_handling case to be consistent with the pass case. > > Thanks for the review! > > Now that the patch was merged, do you feel like I should make a follow- > up patch to fix consistency in the upper case use or is it enough of a > detail that we can just forget about it? If it bothers you, send a patch, otherwise wait for it to bother someone else enough to send a patch. ;) But please avoid the overuse of all caps for regular words, or capitalization except at the beginning of sentences. I'd go with something like this all over the place: "Link training failed, link rate %d, lane count %d\n" But it hasn't bothered me enough to send a patch. ;) BR, Jani. > >> Reviewed-by: Manasi Navare >> >> Manasi >> >> > Signed-off-by: Paul Kocialkowski >> > --- >> > drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++-- >> > 1 file changed, 6 insertions(+), 2 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c >> > b/drivers/gpu/drm/i915/intel_dp_link_training.c >> > index b79c1c0e404c..05907fa8a553 100644 >> > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c >> > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c >> > @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp >> > *intel_dp) >> > if (!intel_dp_link_training_channel_equalization(intel_dp)) >> > goto failure_handling; >> > >> > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane >> > count = %d", >> > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at >> > Link Rate = %d, Lane count = %d", >> > + intel_connector->base.base.id, >> > + intel_connector->base.name, >> > intel_dp->link_rate, intel_dp->lane_count); >> > return; >> > >> > failure_handling: >> > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane >> > count = %d", >> > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at >> > link rate = %d, lane count = %d", >> > + intel_connector->base.base.id, >> > + intel_connector->base.name, >> > intel_dp->link_rate, intel_dp->lane_count); >> > if (!intel_dp_get_link_train_fallback_values(intel_dp, >> > intel_dp- >> > >link_rate, >> > -- >> > 2.13.2 >> > -- Jani Nikula, Intel Open Source Technology Center