Re: [Qemu-devel] [PATCH v3 2/3] migration: introduce qemu_ufd_copy_ioctl helper

[Juan Quintela <quintela@redhat.com>]

Alexey Perevalov <a.perevalov@samsung.com> wrote:
> Just for placing auxilary operations inside helper,
> auxilary operations like: track received pages,
> notify about copying operation in futher patches.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Signed-off-by: Alexey Perevalov <a.perevalov@samsung.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>



> +static int qemu_ufd_copy_ioctl(int userfault_fd, void *host_addr,
> +        void *from_addr, uint64_t pagesize)

from_addr is a void*

> -        if (ioctl(mis->userfault_fd, UFFDIO_ZEROPAGE, &zero_struct)) {
> +        if (qemu_ufd_copy_ioctl(mis->userfault_fd, host, 0, getpagesize())) {

And you pass 0 here, better NULL no?

If you have to respin, please change it.  You can maintain the reviewed-by.

>              int e = errno;
>              error_report("%s: %s zero host: %p",
>                           __func__, strerror(e), host);