From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 3/3] drm/i915: Micro-optimise hotpath through intel_ring_begin() Date: Thu, 04 May 2017 15:59:05 +0300 Message-ID: <87pofon5gm.fsf@gaia.fi.intel.com> References: <20170503100649.28102-1-chris@chris-wilson.co.uk> <20170503100649.28102-3-chris@chris-wilson.co.uk> <87shkkn7ni.fsf@gaia.fi.intel.com> <20170504122714.GF24019@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id D88A46E1BE for ; Thu, 4 May 2017 12:59:14 +0000 (UTC) In-Reply-To: <20170504122714.GF24019@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gT24gVGh1 LCBNYXkgMDQsIDIwMTcgYXQgMDM6MTE6NDVQTSArMDMwMCwgTWlrYSBLdW9wcGFsYSB3cm90ZToK Pj4gQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKPj4gCj4+ ID4gVHlwaWNhbGx5LCB0aGVyZSBpcyBzcGFjZSBhdmFpbGFibGUgd2l0aGluIHRoZSByaW5nIGFu ZCBpZiBub3Qgd2UgaGF2ZQo+PiA+IHRvIHdhaXQgKGJ5IGRlZmluaXRpb24gYSBzbG93IHBhdGgp LiBSZWFycmFuZ2UgdGhlIGNvZGUgdG8gcmVkdWNlIHRoZQo+PiA+IG51bWJlciBvZiBicmFuY2hl cyBhbmQgc3RhY2sgc2l6ZSBmb3IgdGhlIGhvdHBhdGgsIGFjY29tb2RhdGluZyBhIHNsaWdodAo+ PiA+IGdyb3d0aCBmb3IgdGhlIHdhaXQuCj4+ID4KPj4gPiB2MjogRml4IHRoZSBuZXcgYXNzZXJ0 IHRoYXQgcGFja2V0cyBhcmUgbm90IGxhcmdlciB0aGFuIHRoZSBhY3R1YWwgcmluZy4KPj4gPgo+ PiA+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVr Pgo+PiA+IC0tLQo+PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMg fCA2MyArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPj4gPiAgMSBmaWxlIGNoYW5n ZWQsIDMzIGluc2VydGlvbnMoKyksIDMwIGRlbGV0aW9ucygtKQo+PiA+Cj4+ID4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+PiA+IGluZGV4IGM0NmU1NDM5ZDM3OS4uNTMx MjNjMWNmY2M1IDEwMDY0NAo+PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jp bmdidWZmZXIuYwo+PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZm ZXIuYwo+PiA+IEBAIC0xNjU0LDcgKzE2NTQsNyBAQCBzdGF0aWMgaW50IHJpbmdfcmVxdWVzdF9h bGxvYyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4+ID4gIAlyZXR1cm4g MDsKPj4gPiAgfQo+PiA+ICAKPj4gPiAtc3RhdGljIGludCB3YWl0X2Zvcl9zcGFjZShzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwgaW50IGJ5dGVzKQo+PiA+ICtzdGF0aWMgbm9pbmxp bmUgaW50IHdhaXRfZm9yX3NwYWNlKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLCBp bnQgYnl0ZXMpCj4+ID4gIHsKPj4gPiAgCXN0cnVjdCBpbnRlbF9yaW5nICpyaW5nID0gcmVxLT5y aW5nOwo+PiA+ICAJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICp0YXJnZXQ7Cj4+ID4gQEAg LTE3MDIsNDkgKzE3MDIsNTIgQEAgc3RhdGljIGludCB3YWl0X2Zvcl9zcGFjZShzdHJ1Y3QgZHJt X2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwgaW50IGJ5dGVzKQo+PiA+ICB1MzIgKmludGVsX3Jpbmdf YmVnaW4oc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXEsIGludCBudW1fZHdvcmRzKQo+ PiA+ICB7Cj4+ID4gIAlzdHJ1Y3QgaW50ZWxfcmluZyAqcmluZyA9IHJlcS0+cmluZzsKPj4gPiAt CWludCByZW1haW5fYWN0dWFsID0gcmluZy0+c2l6ZSAtIHJpbmctPmVtaXQ7Cj4+ID4gLQlpbnQg cmVtYWluX3VzYWJsZSA9IHJpbmctPmVmZmVjdGl2ZV9zaXplIC0gcmluZy0+ZW1pdDsKPj4gPiAt CWludCBieXRlcyA9IG51bV9kd29yZHMgKiBzaXplb2YodTMyKTsKPj4gPiAtCWludCB0b3RhbF9i eXRlcywgd2FpdF9ieXRlczsKPj4gPiAtCWJvb2wgbmVlZF93cmFwID0gZmFsc2U7Cj4+ID4gKwlj b25zdCB1bnNpZ25lZCBpbnQgcmVtYWluX3VzYWJsZSA9IHJpbmctPmVmZmVjdGl2ZV9zaXplIC0g cmluZy0+ZW1pdDsKPj4gPiArCWNvbnN0IHVuc2lnbmVkIGludCBieXRlcyA9IG51bV9kd29yZHMg KiBzaXplb2YodTMyKTsKPj4gPiArCXVuc2lnbmVkIGludCBuZWVkX3dyYXAgPSAwOwo+PiA+ICsJ dW5zaWduZWQgaW50IHRvdGFsX2J5dGVzOwo+PiA+ICAJdTMyICpjczsKPj4gPiAgCj4+ID4gIAl0 b3RhbF9ieXRlcyA9IGJ5dGVzICsgcmVxLT5yZXNlcnZlZF9zcGFjZTsKPj4gPiArCUdFTV9CVUdf T04odG90YWxfYnl0ZXMgPiByaW5nLT5lZmZlY3RpdmVfc2l6ZSk7Cj4+ID4gIAo+PiA+IC0JaWYg KHVubGlrZWx5KGJ5dGVzID4gcmVtYWluX3VzYWJsZSkpIHsKPj4gPiAtCQkvKgo+PiA+IC0JCSAq IE5vdCBlbm91Z2ggc3BhY2UgZm9yIHRoZSBiYXNpYyByZXF1ZXN0LiBTbyBuZWVkIHRvIGZsdXNo Cj4+ID4gLQkJICogb3V0IHRoZSByZW1haW5kZXIgYW5kIHRoZW4gd2FpdCBmb3IgYmFzZSArIHJl c2VydmVkLgo+PiA+IC0JCSAqLwo+PiA+IC0JCXdhaXRfYnl0ZXMgPSByZW1haW5fYWN0dWFsICsg dG90YWxfYnl0ZXM7Cj4+ID4gLQkJbmVlZF93cmFwID0gdHJ1ZTsKPj4gPiAtCX0gZWxzZSBpZiAo dW5saWtlbHkodG90YWxfYnl0ZXMgPiByZW1haW5fdXNhYmxlKSkgewo+PiA+IC0JCS8qCj4+ID4g LQkJICogVGhlIGJhc2UgcmVxdWVzdCB3aWxsIGZpdCBidXQgdGhlIHJlc2VydmVkIHNwYWNlCj4+ ID4gLQkJICogZmFsbHMgb2ZmIHRoZSBlbmQuIFNvIHdlIGRvbid0IG5lZWQgYW4gaW1tZWRpYXRl IHdyYXAKPj4gPiAtCQkgKiBhbmQgb25seSBuZWVkIHRvIGVmZmVjdGl2ZWx5IHdhaXQgZm9yIHRo ZSByZXNlcnZlZAo+PiA+IC0JCSAqIHNpemUgc3BhY2UgZnJvbSB0aGUgc3RhcnQgb2YgcmluZ2J1 ZmZlci4KPj4gPiAtCQkgKi8KPj4gPiAtCQl3YWl0X2J5dGVzID0gcmVtYWluX2FjdHVhbCArIHJl cS0+cmVzZXJ2ZWRfc3BhY2U7Cj4+ID4gLQl9IGVsc2Ugewo+PiA+IC0JCS8qIE5vIHdyYXBwaW5n IHJlcXVpcmVkLCBqdXN0IHdhaXRpbmcuICovCj4+ID4gLQkJd2FpdF9ieXRlcyA9IHRvdGFsX2J5 dGVzOwo+PiA+ICsJaWYgKHVubGlrZWx5KHRvdGFsX2J5dGVzID4gcmVtYWluX3VzYWJsZSkpIHsK Pj4gPiArCQljb25zdCBpbnQgcmVtYWluX2FjdHVhbCA9IHJpbmctPnNpemUgLSByaW5nLT5lbWl0 Owo+PiA+ICsKPj4gPiArCQlpZiAoYnl0ZXMgPiByZW1haW5fdXNhYmxlKSB7Cj4+ID4gKwkJCS8q Cj4+ID4gKwkJCSAqIE5vdCBlbm91Z2ggc3BhY2UgZm9yIHRoZSBiYXNpYyByZXF1ZXN0LiBTbyBu ZWVkIHRvCj4+ID4gKwkJCSAqIGZsdXNoIG91dCB0aGUgcmVtYWluZGVyIGFuZCB0aGVuIHdhaXQg Zm9yCj4+ID4gKwkJCSAqIGJhc2UgKyByZXNlcnZlZC4KPj4gPiArCQkJICovCj4+ID4gKwkJCXRv dGFsX2J5dGVzICs9IHJlbWFpbl9hY3R1YWw7Cj4+ID4gKwkJCW5lZWRfd3JhcCA9IHJlbWFpbl9h Y3R1YWwgfCAxOwo+PiAKPj4gWW91ciByZW1haW5fYWN0dWFsIHNob3VsZCBuZXZlciByZWFjaCB6 ZXJvLiBTbyBpbiBoZXJlCj4+IGZvcmNpbmcgdGhlIGxvd2VzdCBiaXQgb24sIGFuZCBsYXRlciBv ZmYsIHNlZW1zIHN1cGVyZmx1b3VzLgo+Cj4gV2h5IGNhbid0IHdlIGZpbGwgdXAgdG8gdGhlIGxh c3QgYnl0ZSB3aXRoIGNvbW1hbmRzPyByZW1haW5fYWN0dWFsIGlzCj4ganVzdCAoc2l6ZSAtIHRh aWwpIGFuZCB3ZSBkb24ndCBmb3JjZSBhIHdyYXAgdW50aWwgZW1pdCBjcm9zc2VzIHRoZQo+IGJv dW5kYXJ5IChhbmQgbm90IGJlZm9yZSkuIFdlIGhpdCByZW1haW5fYWN0dWFsID09IDAgaW4gcHJh Y3RpY2UuCj4gLUNocmlzCgpNeSBtaXN0YWtlLCB3YXMgdGhpbmtpbmcgcG9zdHdyYXAuCgpudW1f ZHdvcmRzIGFuZCBzZWNvbmQgcGFyYW1ldGVyIHRvIHdhaXRfZm9yX3NwYWNlIHNob3VsZCBiZSB1 bnNpZ25lZC4KClJldmlld2VkLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGludGVs LmNvbT4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==