From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [RFC PATCH 2/3] drm/panel: sharp-lq101r1sx01: Use panel-common
 helpers
Date: Tue, 21 Mar 2017 14:06:26 -0700
Message-ID: <87poha1grx.fsf@eliezer.anholt.net>
References: <20170316220837.17347-1-seanpaul@chromium.org>
 <20170316220837.17347-3-seanpaul@chromium.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0712464294=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from anholt.net (anholt.net [50.246.234.109])
 by gabe.freedesktop.org (Postfix) with ESMTP id E36556E1A1
 for <dri-devel@lists.freedesktop.org>; Tue, 21 Mar 2017 21:06:30 +0000 (UTC)
In-Reply-To: <20170316220837.17347-3-seanpaul@chromium.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Sean Paul <seanpaul@chromium.org>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

--===============0712464294==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Sean Paul <seanpaul@chromium.org> writes:

> Instead of duplicating common code from panel-simple, use the panel-commo=
n helpers.
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
>  drivers/gpu/drm/panel/Kconfig                   |  1 +
>  drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 79 +++++++------------=
------
>  2 files changed, 24 insertions(+), 56 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index be8590724042..98db78d22a13 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -73,6 +73,7 @@ config DRM_PANEL_SHARP_LQ101R1SX01
>  	depends on OF
>  	depends on DRM_MIPI_DSI
>  	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_PANEL_COMMON
>  	help
>  	  Say Y here if you want to enable support for Sharp LQ101R1SX01
>  	  TFT-LCD modules. The panel has a 2560x1600 resolution and uses
> diff --git a/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c b/drivers/gp=
u/drm/panel/panel-sharp-lq101r1sx01.c
> index 3cce3ca19601..fb2bf67449ab 100644
> --- a/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c
> +++ b/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c
> @@ -6,11 +6,8 @@
>   * published by the Free Software Foundation.
>   */
>=20=20
> -#include <linux/backlight.h>
> -#include <linux/gpio/consumer.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
> -#include <linux/regulator/consumer.h>
>=20=20
>  #include <drm/drmP.h>
>  #include <drm/drm_crtc.h>
> @@ -19,17 +16,17 @@
>=20=20
>  #include <video/mipi_display.h>
>=20=20
> +#include "panel-common.h"
> +
>  struct sharp_panel {
>  	struct drm_panel base;
> +	struct panel_common common;
> +
>  	/* the datasheet refers to them as DSI-LINK1 and DSI-LINK2 */
>  	struct mipi_dsi_device *link1;
>  	struct mipi_dsi_device *link2;
>=20=20
> -	struct backlight_device *backlight;
> -	struct regulator *supply;
> -
>  	bool prepared;
> -	bool enabled;
>=20=20
>  	const struct drm_display_mode *mode;
>  };
> @@ -93,17 +90,7 @@ static int sharp_panel_disable(struct drm_panel *panel)
>  {
>  	struct sharp_panel *sharp =3D to_sharp_panel(panel);
>=20=20
> -	if (!sharp->enabled)
> -		return 0;
> -
> -	if (sharp->backlight) {
> -		sharp->backlight->props.power =3D FB_BLANK_POWERDOWN;
> -		backlight_update_status(sharp->backlight);
> -	}
> -
> -	sharp->enabled =3D false;
> -
> -	return 0;
> +	return panel_common_disable(&sharp->common, 0);
>  }
>=20=20
>  static int sharp_panel_unprepare(struct drm_panel *panel)
> @@ -126,11 +113,13 @@ static int sharp_panel_unprepare(struct drm_panel *=
panel)
>=20=20
>  	msleep(120);
>=20=20
> -	regulator_disable(sharp->supply);
> +	err =3D panel_common_unprepare(&sharp->common, 0);
> +	if (err < 0)
> +		dev_err(panel->dev, "failed common unprepare: %d\n", err);
>=20=20
>  	sharp->prepared =3D false;
>=20=20
> -	return 0;
> +	return err;
>  }
>=20=20
>  static int sharp_setup_symmetrical_split(struct mipi_dsi_device *left,
> @@ -176,17 +165,15 @@ static int sharp_panel_prepare(struct drm_panel *pa=
nel)
>  	if (sharp->prepared)
>  		return 0;
>=20=20
> -	err =3D regulator_enable(sharp->supply);
> -	if (err < 0)
> -		return err;
> -
>  	/*
>  	 * According to the datasheet, the panel needs around 10 ms to fully
>  	 * power up. At least another 120 ms is required before exiting sleep
>  	 * mode to make sure the panel is ready. Throw in another 20 ms for
>  	 * good measure.
>  	 */
> -	msleep(150);
> +	err =3D panel_common_prepare(&sharp->common, 150);
> +	if (err < 0)
> +		return err;

Aside: I like how 120 + 20 =3D 150, because always round up your delays :)

>=20=20
>  	err =3D mipi_dsi_dcs_exit_sleep_mode(sharp->link1);
>  	if (err < 0) {
> @@ -252,7 +239,7 @@ static int sharp_panel_prepare(struct drm_panel *pane=
l)
>  	return 0;
>=20=20
>  poweroff:
> -	regulator_disable(sharp->supply);
> +	panel_common_unprepare(&sharp->common, 0);
>  	return err;
>  }
>=20=20
> @@ -260,17 +247,7 @@ static int sharp_panel_enable(struct drm_panel *pane=
l)
>  {
>  	struct sharp_panel *sharp =3D to_sharp_panel(panel);
>=20=20
> -	if (sharp->enabled)
> -		return 0;
> -
> -	if (sharp->backlight) {
> -		sharp->backlight->props.power =3D FB_BLANK_UNBLANK;
> -		backlight_update_status(sharp->backlight);
> -	}
> -
> -	sharp->enabled =3D true;
> -
> -	return 0;
> +	return panel_common_enable(&sharp->common, 0);
>  }
>=20=20
>  static const struct drm_display_mode default_mode =3D {
> @@ -324,23 +301,15 @@ MODULE_DEVICE_TABLE(of, sharp_of_match);
>=20=20
>  static int sharp_panel_add(struct sharp_panel *sharp)
>  {
> -	struct device_node *np;
>  	int err;
>=20=20
>  	sharp->mode =3D &default_mode;
> +	sharp->prepared =3D false;
>=20=20
> -	sharp->supply =3D devm_regulator_get(&sharp->link1->dev, "power");
> -	if (IS_ERR(sharp->supply))
> -		return PTR_ERR(sharp->supply);
> -
> -	np =3D of_parse_phandle(sharp->link1->dev.of_node, "backlight", 0);
> -	if (np) {
> -		sharp->backlight =3D of_find_backlight_by_node(np);
> -		of_node_put(np);
> -
> -		if (!sharp->backlight)
> -			return -EPROBE_DEFER;
> -	}
> +	err =3D panel_common_init(&sharp->link1->dev, &sharp->common, "supply",
> +				"gpio", "backlight");
> +	if (err < 0)
> +		return err;

Looks like you've incidentally changed the regulator name from "power"
to "supply".  Seems like it should be a called out in the commit
message, if intentional.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljRldIACgkQtdYpNtH8
nuhtCw/8DBW/+G5CBfz8Bqs3fbzxpzZ2hE+GZ9f/Dmok9vRiXM/+x8jebFtMJax2
Azx16UKHlw/uIowVBST0OrpwKnR/Cr7VTpTwWmZxrp574sAJ/0G6KltQFEtteB9k
E2oc8ChSGqNgF3QAnMKN4eAo8V7yR3trmGiwUX4LnFInshbJbzHaPBgAvr42XPWE
F+Z6EdF2+QNBvfprBFYH3YKqT43xzmiTF3TtA5r7AzwV8N063QL+LKD8pi+LHaL3
WOjeYS1gdvkmo9Ts3mbzTLn7qpT41kaiEbvBwgTdxUFx/6xzsM8Ak5e3sWdxWi0X
nnwYvDWIVZp8DYC6BZlUW9eB8OG3AKb36ZL4SZShG55MhBOtJoHRKgLuRdXjdiYs
d7k3CK8AzfvhK2ja7gJATPHo0VWnF0tsX264Stbfn9Gnft/NGxyxB2SLUihKnA9h
9ONeMM8dSosj/8zD1OQP7A6eTOBRB8p425ygjaurBiIry+pNWj0GxF2knUomr9d8
ApV6frBihnmcQe7L5Ohxlc9g+OzELpT+89pRkCleyqUfz6Z4qOyIJkdfYn5cVFaR
4Iu12IBzoLtbpHSE/kjIYTWqjXn2k1zhUX2metM6neDGed81H2xFJvVIJtVa7rzP
awisJYXCHJRpHKHpfGrVcvE3m7BkSKtK0/LtUoNfsdVi0fsUOrg=
=4JyM
-----END PGP SIGNATURE-----
--=-=-=--

--===============0712464294==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============0712464294==--