From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfnhW-0005Tg-VI for qemu-devel@nongnu.org; Mon, 20 Feb 2017 08:08:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cfnhT-0002GR-P8 for qemu-devel@nongnu.org; Mon, 20 Feb 2017 08:08:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55778) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cfnhT-0002ER-JN for qemu-devel@nongnu.org; Mon, 20 Feb 2017 08:08:19 -0500 From: Markus Armbruster References: <20170217093416.27688-1-marcandre.lureau@redhat.com> Date: Mon, 20 Feb 2017 14:08:15 +0100 In-Reply-To: <20170217093416.27688-1-marcandre.lureau@redhat.com> (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Fri, 17 Feb 2017 13:34:16 +0400") Message-ID: <87poid103k.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qapi2texi: replace quotation by bold section name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org Marc-Andr=C3=A9 Lureau writes: > When we build qemu-qmp-ref.txt this causes texinfo to complain several > times: > "Negative repeat count does nothing at > /usr/share/texinfo/Texinfo/Convert/Line.pm line 124." > > It also doesn't display correctly, because the "Notes" text disappears > entirely in the HTML version because it thinks there's no actual > quotation text. > > The text file output formatting is also not good. > > To solve those problems, remove usage of @quotation, and simply use bold > face for the section name. > > Reported-by: Peter Maydell > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > scripts/qapi2texi.py | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/scripts/qapi2texi.py b/scripts/qapi2texi.py > index 83ded95c2d..c1071c62c6 100755 > --- a/scripts/qapi2texi.py > +++ b/scripts/qapi2texi.py > @@ -159,12 +159,10 @@ def texi_body(doc): > func =3D texi_example >=20=20 > if name: > - # FIXME the indentation produced by @quotation in .txt and > - # .html output is confusing > - body +=3D "\n@quotation %s\n%s\n@end quotation" % \ > - (name, func(doc)) > - else: > - body +=3D func(doc) > + # prefer @b over @strong, so txt doesn't translate it to *Fo= o:* > + body +=3D "\n\n@b{%s:}\n" % name The second newline is sometimes needed to make a paragraph, and at other times it's redundant and somewhat ugly. Tolerable, as this file isn't for humans. > + > + body +=3D func(doc) >=20=20 > return body Reviewed-by: Markus Armbruster