From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Allow the user to override default firmware file names
Date: Mon, 06 Feb 2017 16:41:48 +0200 [thread overview]
Message-ID: <87poiv9yab.fsf@intel.com> (raw)
In-Reply-To: <20170206130529.11693-1-chris@chris-wilson.co.uk>
On Mon, 06 Feb 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Make the actual path we attempt to load for each of (DMC, GuC, HuC)
> overidable by the user. This helps testing new firmware releases.
And old firmware releases, and potentially helps bisect the kernel by
eliminating firmware changes.
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/i915_params.c | 12 ++++++++++++
> drivers/gpu/drm/i915/i915_params.h | 3 +++
> drivers/gpu/drm/i915/intel_csr.c | 9 ++++++++-
> drivers/gpu/drm/i915/intel_guc_loader.c | 4 ++++
> drivers/gpu/drm/i915/intel_huc.c | 8 ++++++++
> 5 files changed, 35 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index f1fa51190dc6..d7001c0effa5 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -243,3 +243,15 @@ MODULE_PARM_DESC(enable_dpcd_backlight,
> module_param_named(enable_gvt, i915.enable_gvt, bool, 0400);
> MODULE_PARM_DESC(enable_gvt,
> "Enable support for Intel GVT-g graphics virtualization host support(default:false)");
> +
> +module_param_named(dmc_firmware, i915.dmc_firmware_path, charp, 0400);
> +MODULE_PARM_DESC(dmc_firmare,
> + "Provide an alternate name for the DMC firmware file");
> +
> +module_param_named(guc_firmware, i915.guc_firmware_path, charp, 0400);
> +MODULE_PARM_DESC(guc_firmare,
> + "Provide an alternate name for the GuC firmware file");
> +
> +module_param_named(huc_firmware, i915.huc_firmware_path, charp, 0400);
> +MODULE_PARM_DESC(huc_firmare,
> + "Provide an alternate name for the HuC firmware file");
Please make them _unsafe. With that,
Acked-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-02-06 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 13:05 [PATCH] drm/i915: Allow the user to override default firmware file names Chris Wilson
2017-02-06 13:52 ` Michal Wajdeczko
2017-02-06 14:18 ` Chris Wilson
2017-02-06 14:41 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poiv9yab.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.