diff for duplicates of <87poj9ndj9.fsf@codeaurora.org> diff --git a/a/1.txt b/N1/1.txt index bc4c635..80f3a44 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -Pali Roh=C3=A1r <pali.rohar@gmail.com> writes: +Pali Rohár <pali.rohar@gmail.com> writes: > This patch implements parsing MAC address from NVS data which are sent to > wl1251 chip. Calibration NVS data could contain valid MAC address and it @@ -9,8 +9,7 @@ Pali Roh=C3=A1r <pali.rohar@gmail.com> writes: > permanent MAC address is needed. > > Calibration NVS data for wl1251 are model specific. Every one device with -> wl1251 chip should have been calibrated in factory and needs to provide o= -wn +> wl1251 chip should have been calibrated in factory and needs to provide own > calibration data. > > Default example wl1251-nvs.bin data found in linux-firmware repository and @@ -20,7 +19,7 @@ wn > Format of calibration NVS data can be found at: > http://notaz.gp2x.de/misc/pnd/wl1251/nvs_map.txt > -> Signed-off-by: Pali Roh=C3=A1r <pali.rohar@gmail.com> +> Signed-off-by: Pali Rohár <pali.rohar@gmail.com> [...] @@ -33,16 +32,15 @@ wn > + return -ENODATA; > + > + /* length is 2 and data address is 0x546c (mask is 0xfffe) */ -> + if (wl->nvs[0x19] !=3D 2 || wl->nvs[0x1a] !=3D 0x6d || wl->nvs[0x1b] != -=3D 0x54) +> + if (wl->nvs[0x19] != 2 || wl->nvs[0x1a] != 0x6d || wl->nvs[0x1b] != 0x54) > + return -EINVAL; > + > + /* MAC is stored in reverse order */ -> + for (i =3D 0; i < ETH_ALEN; i++) -> + mac[i] =3D wl->nvs[0x1c + ETH_ALEN - i - 1]; +> + for (i = 0; i < ETH_ALEN; i++) +> + mac[i] = wl->nvs[0x1c + ETH_ALEN - i - 1]; No magic numbers, please. Replace all nvs offsets with proper defines to make the code more readable. ---=20 +-- Kalle Valo diff --git a/a/content_digest b/N1/content_digest index 1d553f8..eeba5dc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -21,7 +21,7 @@ " netdev@vger.kernel.org\0" "\00:1\0" "b\0" - "Pali Roh=C3=A1r <pali.rohar@gmail.com> writes:\n" + "Pali Roh\303\241r <pali.rohar@gmail.com> writes:\n" "\n" "> This patch implements parsing MAC address from NVS data which are sent to\n" "> wl1251 chip. Calibration NVS data could contain valid MAC address and it\n" @@ -32,8 +32,7 @@ "> permanent MAC address is needed.\n" ">\n" "> Calibration NVS data for wl1251 are model specific. Every one device with\n" - "> wl1251 chip should have been calibrated in factory and needs to provide o=\n" - "wn\n" + "> wl1251 chip should have been calibrated in factory and needs to provide own\n" "> calibration data.\n" ">\n" "> Default example wl1251-nvs.bin data found in linux-firmware repository and\n" @@ -43,7 +42,7 @@ "> Format of calibration NVS data can be found at:\n" "> http://notaz.gp2x.de/misc/pnd/wl1251/nvs_map.txt\n" ">\n" - "> Signed-off-by: Pali Roh=C3=A1r <pali.rohar@gmail.com>\n" + "> Signed-off-by: Pali Roh\303\241r <pali.rohar@gmail.com>\n" "\n" "[...]\n" "\n" @@ -56,18 +55,17 @@ "> +\t\treturn -ENODATA;\n" "> +\n" "> +\t/* length is 2 and data address is 0x546c (mask is 0xfffe) */\n" - "> +\tif (wl->nvs[0x19] !=3D 2 || wl->nvs[0x1a] !=3D 0x6d || wl->nvs[0x1b] !=\n" - "=3D 0x54)\n" + "> +\tif (wl->nvs[0x19] != 2 || wl->nvs[0x1a] != 0x6d || wl->nvs[0x1b] != 0x54)\n" "> +\t\treturn -EINVAL;\n" "> +\n" "> +\t/* MAC is stored in reverse order */\n" - "> +\tfor (i =3D 0; i < ETH_ALEN; i++)\n" - "> +\t\tmac[i] =3D wl->nvs[0x1c + ETH_ALEN - i - 1];\n" + "> +\tfor (i = 0; i < ETH_ALEN; i++)\n" + "> +\t\tmac[i] = wl->nvs[0x1c + ETH_ALEN - i - 1];\n" "\n" "No magic numbers, please. Replace all nvs offsets with proper defines to\n" "make the code more readable.\n" "\n" - "--=20\n" + "-- \n" Kalle Valo -19e6b403bf53105b9b4d350d36f49fc85bbb45484406d828b008c41d15142ac2 +cad903dff68bc7dc72fac50e8e50a32495b8deb02813e168e47bc769cb0e761f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.