From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] x86/gpu: GLK uses the same GMS values as SKL Date: Wed, 25 Jan 2017 13:33:29 +0200 Message-ID: <87pojb4bna.fsf@intel.com> References: <1485283642-14401-1-git-send-email-paulo.r.zanoni@intel.com> <20170125072903.GA20432@gmail.com> <87sho74br5.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 040346E984 for ; Wed, 25 Jan 2017 11:33:33 +0000 (UTC) In-Reply-To: <87sho74br5.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ingo Molnar , Paulo Zanoni Cc: Ander Conselvan de Oliveira , Daniel Vetter , intel-gfx@lists.freedesktop.org, x86@kernel.org, linux-kernel@vger.kernel.org, Rodrigo Vivi , Dhinakaran Pandiyan , "H . Peter Anvin" List-Id: intel-gfx@lists.freedesktop.org CihOb3cgd2l0aG91dCB0aGUgdHlwbyBpbiBEYW5pZWwncyBhZGRyZXNzOyBhcG9sb2dpZXMgZm9y IHRoZSBleHRyYQpub2lzZS4pCgpPbiBXZWQsIDI1IEphbiAyMDE3LCBKYW5pIE5pa3VsYSA8amFu aS5uaWt1bGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiBPbiBXZWQsIDI1IEphbiAyMDE3LCBJ bmdvIE1vbG5hciA8bWluZ29Aa2VybmVsLm9yZz4gd3JvdGU6Cj4+ICogUGF1bG8gWmFub25pIDxw YXVsby5yLnphbm9uaUBpbnRlbC5jb20+IHdyb3RlOgo+Pgo+Pj4gU28gZG9uJ3QgZm9yZ2V0IHRv IHJlc2VydmUgaXRzIHN0b2xlbiBtZW1vcnkgYml0cy4KPj4+IAo+Pj4gQ2M6IEluZ28gTW9sbmFy IDxtaW5nb0BrZXJuZWwub3JnPgo+Pj4gQ2M6IEguIFBldGVyIEFudmluIDxocGFAenl0b3IuY29t Pgo+Pj4gQ2M6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSA8YW5kZXIuY29uc2VsdmFuLmRl Lm9saXZlaXJhQGludGVsLmNvbT4KPj4+IENjOiB4ODZAa2VybmVsLm9yZwo+Pj4gUmV2aWV3ZWQt Ynk6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSA8YW5kZXIuY29uc2VsdmFuLmRlLm9saXZl aXJhQGludGVsLmNvbT4KPj4+IFNpZ25lZC1vZmYtYnk6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56 YW5vbmlAaW50ZWwuY29tPgo+Pj4gLS0tCj4+PiAgYXJjaC94ODYva2VybmVsL2Vhcmx5LXF1aXJr cy5jIHwgMSArCj4+PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4+PiAKPj4+IEZv dW5kIGJ5IGNvZGUgaW5zcGVjdGlvbi4gVGhpcyBpcyBjb21wbGV0ZWx5IHVudGVzdGVkIHNpbmNl IEkgZG9uJ3QgaGF2ZQo+Pj4gR0xLIGhhcmR3YXJlLgo+Pj4gCj4+PiBkaWZmIC0tZ2l0IGEvYXJj aC94ODYva2VybmVsL2Vhcmx5LXF1aXJrcy5jIGIvYXJjaC94ODYva2VybmVsL2Vhcmx5LXF1aXJr cy5jCj4+PiBpbmRleCA2YTA4ZTI1Li4yM2M0ZjFjIDEwMDY0NAo+Pj4gLS0tIGEvYXJjaC94ODYv a2VybmVsL2Vhcmx5LXF1aXJrcy5jCj4+PiArKysgYi9hcmNoL3g4Ni9rZXJuZWwvZWFybHktcXVp cmtzLmMKPj4+IEBAIC01MjYsNiArNTI2LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBwY2lfZGV2 aWNlX2lkIGludGVsX2Vhcmx5X2lkc1tdIF9faW5pdGNvbnN0ID0gewo+Pj4gIAlJTlRFTF9TS0xf SURTKCZnZW45X2Vhcmx5X29wcyksCj4+PiAgCUlOVEVMX0JYVF9JRFMoJmdlbjlfZWFybHlfb3Bz KSwKPj4+ICAJSU5URUxfS0JMX0lEUygmZ2VuOV9lYXJseV9vcHMpLAo+Pj4gKwlJTlRFTF9HTEtf SURTKCZnZW45X2Vhcmx5X29wcyksCj4+PiAgfTsKPj4KPj4gVGhlcmUncyBubyBJTlRFTF9HTEtf SURTKCkgdXBzdHJlYW0gLSBpcyB0aGVyZSBhbnkgZGVwZW5kZW5jeSBoZXJlIG9uIG90aGVyIAo+ PiBjaGFuZ2VzIHRvIHRoZSBpOTE1IEdQVSBkcml2ZXI/Cj4KPiBJdCdzIGluIG91ciAtbmV4dC4g QWNrIGZvciBtZXJnaW5nIHRoaXMgdGhyb3VnaCBkcm0taW50ZWwgYWxvbmcgd2l0aCB0aGUKPiBk ZXBzPwo+Cj4gQlIsCj4gSmFuaS4KPgo+Pgo+PiBUaGFua3MsCj4+Cj4+IAlJbmdvCj4+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IEludGVsLWdmeCBt YWlsaW5nIGxpc3QKPj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkph bmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751444AbdAYLde (ORCPT ); Wed, 25 Jan 2017 06:33:34 -0500 Received: from mga05.intel.com ([192.55.52.43]:22593 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbdAYLdd (ORCPT ); Wed, 25 Jan 2017 06:33:33 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,283,1477983600"; d="scan'208";a="813134395" From: Jani Nikula To: Ingo Molnar , Paulo Zanoni Cc: Ander Conselvan de Oliveira , "H . Peter Anvin" , intel-gfx@lists.freedesktop.org, x86@kernel.org, linux-kernel@vger.kernel.org, Dhinakaran Pandiyan , Rodrigo Vivi , Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL In-Reply-To: <87sho74br5.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1485283642-14401-1-git-send-email-paulo.r.zanoni@intel.com> <20170125072903.GA20432@gmail.com> <87sho74br5.fsf@intel.com> Date: Wed, 25 Jan 2017 13:33:29 +0200 Message-ID: <87pojb4bna.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (Now without the typo in Daniel's address; apologies for the extra noise.) On Wed, 25 Jan 2017, Jani Nikula wrote: > On Wed, 25 Jan 2017, Ingo Molnar wrote: >> * Paulo Zanoni wrote: >> >>> So don't forget to reserve its stolen memory bits. >>> >>> Cc: Ingo Molnar >>> Cc: H. Peter Anvin >>> Cc: Ander Conselvan de Oliveira >>> Cc: x86@kernel.org >>> Reviewed-by: Ander Conselvan de Oliveira >>> Signed-off-by: Paulo Zanoni >>> --- >>> arch/x86/kernel/early-quirks.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> Found by code inspection. This is completely untested since I don't have >>> GLK hardware. >>> >>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c >>> index 6a08e25..23c4f1c 100644 >>> --- a/arch/x86/kernel/early-quirks.c >>> +++ b/arch/x86/kernel/early-quirks.c >>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = { >>> INTEL_SKL_IDS(&gen9_early_ops), >>> INTEL_BXT_IDS(&gen9_early_ops), >>> INTEL_KBL_IDS(&gen9_early_ops), >>> + INTEL_GLK_IDS(&gen9_early_ops), >>> }; >> >> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other >> changes to the i915 GPU driver? > > It's in our -next. Ack for merging this through drm-intel along with the > deps? > > BR, > Jani. > >> >> Thanks, >> >> Ingo >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center