From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7PHM-00073L-10 for qemu-devel@nongnu.org; Thu, 17 Nov 2016 11:11:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7PHH-00026L-Ub for qemu-devel@nongnu.org; Thu, 17 Nov 2016 11:11:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29093) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7PHH-00026B-P4 for qemu-devel@nongnu.org; Thu, 17 Nov 2016 11:11:07 -0500 From: Markus Armbruster References: <1478694124-15803-1-git-send-email-david@gibson.dropbear.id.au> <1478694124-15803-2-git-send-email-david@gibson.dropbear.id.au> Date: Thu, 17 Nov 2016 17:11:04 +0100 In-Reply-To: <1478694124-15803-2-git-send-email-david@gibson.dropbear.id.au> (David Gibson's message of "Wed, 9 Nov 2016 23:22:02 +1100") Message-ID: <87polucciv.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCHv2 1/3] Split serial-isa into its own config option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: edgar.iglesias@gmail.com, michael@walle.cc, proljc@gmail.com, borntraeger@de.ibm.com, cornelia.huck@de.ibm.com, kbastian@mail.uni-paderborn.de, jcmvbkbc@gmail.com, veroniabahaa@gmail.com, peter.maydell@linaro.org, mst@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, pbonzini@redhat.com David Gibson writes: > At present, the core device model code for 8250-like serial ports > (serial.c) and the code for serial ports attached to ISA-style legacy IO > (serial-isa.c) are both controlled by the CONFIG_SERIAL variable. > > There are lots and lots of embedded platforms that have 8250-like serial > ports but have never had anything resembling ISA legacy IO. Therefore, > split serial-isa into its own CONFIG_SERIAL_ISA option so it can be > disabled for platforms where it's not appropriate. > > For now, I enabled CONFIG_SERIAL_ISA in every default-config where > CONFIG_SERIAL is enabled, excepting microblaze, or32, and xtensa. As best > as I can tell, those platforms never used legacy ISA, and also don't > include PCI support (which would allow connection of a PCI->ISA bridge > and/or a southbridge including legacy ISA serial ports). I poked them with nm, and the result supports your claims. > Signed-off-by: David Gibson > Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster