From: ebiederm@xmission.com (Eric W. Biederman)
To: Arnd Bergmann <arnd@arndb.de>
Cc: kernel-build-reports@lists.linaro.org,
Olof's autobuilder <build@lixom.net>,
olof@lixom.net, stable <stable@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: stable-rc build: 72 warnings 1 failures (stable-rc/v4.4.30-35-gf821e08)
Date: Tue, 08 Nov 2016 18:45:53 -0600 [thread overview]
Message-ID: <87pom5qy4e.fsf@xmission.com> (raw)
In-Reply-To: <2049467.HlUiazMrKa@wuerfel> (Arnd Bergmann's message of "Tue, 08 Nov 2016 23:14:20 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> On Tuesday, November 8, 2016 9:16:28 AM CET Olof's autobuilder wrote:
>> Here are the build results from automated periodic testing.
>>
>> The tree being built was stable-rc, found at:
>>
>> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable-rc.git/
>>
>> Topmost commit:
>>
>> f821e08 Linux 4.4.31-rc1
>>
>> Build logs (stderr only) can be found at the following link (experimental):
>>
>> http://arm-soc.lixom.net/buildlogs/stable-rc/v4.4.30-35-gf821e08/
>
> These seem to be largely caused by building with gcc-6. It's probably
> a good idea to keep supporting that configuration though and
> backport the fixes. Here are the upstream commit IDs I've found.
>
>> -------------------------------------------------------------------------------
>>
>> Failed defconfigs:
>> powerpc.pasemi_defconfig
>>
>> -------------------------------------------------------------------------------
>>
>
>> 1 fs/devpts/inode.c:462:23: warning: self-comparison always evaluates to false [-Wtautological-compare]
>
> I think this was accidentally fixed by eedf265aa003 ("devpts: Make each mount of
> devpts an independent filesystem."), which unfortunately is not a
> candidate for stable
Well eedf265aa003 ("devpts: Make each mount of devpts an independent
filesystem.") does contain a somewhat serious bug fix, and it was tested
to ensure it works everywhere so that might possibly be a canidate for
stable.
Certainly that is a change I would aim at vendor trees that care about
containers.
>> 1 net/netfilter/xt_owner.c:27:23: warning: self-comparison always evaluates to false [-Wtautological-compare]
>
> Apparently also fixed as a side-effect of a larger patch:
>
> 9847371a84b0 ("netfilter: Allow xt_owner in any user namespace")
>
> This one might be appropriate for a stable backport, Eric Biederman
> would know for sure.
Well it is a feature patch. This sounds like an error message that is
only generated when user namespace support is disabled. And we are
making it go away by making the code more expensive.
I am not a great fan of that warning being on by default, as it seems to
encourage more expensive code to be generated by macros. Has that
warning caught any real bugs yet?
Eric
next prev parent reply other threads:[~2016-11-09 0:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5822086c.4666420a.e9479.80e9@mx.google.com>
2016-11-08 22:14 ` stable-rc build: 72 warnings 1 failures (stable-rc/v4.4.30-35-gf821e08) Arnd Bergmann
2016-11-08 22:17 ` Olof Johansson
2016-11-08 23:26 ` Olof Johansson
2016-11-09 0:07 ` Arnd Bergmann
2016-11-09 9:44 ` Greg KH
2016-11-09 10:02 ` Greg KH
2016-11-09 0:45 ` Eric W. Biederman [this message]
2016-11-09 15:44 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pom5qy4e.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=arnd@arndb.de \
--cc=build@lixom.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-build-reports@lists.linaro.org \
--cc=olof@lixom.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.