From: Markus Armbruster <armbru@redhat.com>
To: riku.voipio@linaro.org
Cc: qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] build-sys: fix make install regression
Date: Tue, 20 Sep 2016 12:05:12 +0200 [thread overview]
Message-ID: <87ponysx7r.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1474362094-2293-1-git-send-email-riku.voipio@linaro.org> (riku voipio's message of "Tue, 20 Sep 2016 12:01:34 +0300")
riku.voipio@linaro.org writes:
> From: Riku Voipio <riku.voipio@linaro.org>
>
> Since bd6092e Replace qmp-commands.hx by docs/qmp-commands.txt
> make install fails if building out of source-tree.
>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 81ca388..444ae37 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -431,7 +431,7 @@ endif
> install-doc: $(DOCS)
> $(INSTALL_DIR) "$(DESTDIR)$(qemu_docdir)"
> $(INSTALL_DATA) qemu-doc.html qemu-tech.html "$(DESTDIR)$(qemu_docdir)"
> - $(INSTALL_DATA) docs/qmp-commands.txt "$(DESTDIR)$(qemu_docdir)"
> + $(INSTALL_DATA) $(SRC_PATH)/docs/qmp-commands.txt "$(DESTDIR)$(qemu_docdir)"
> ifdef CONFIG_POSIX
> $(INSTALL_DIR) "$(DESTDIR)$(mandir)/man1"
> $(INSTALL_DATA) qemu.1 "$(DESTDIR)$(mandir)/man1"
I grepped through the tree, and this is the only oversight. Well,
there's a QMP/qmp-commands.txt in docs/xen-save-devices-state.txt, but
that's due to commit eb02dc0. I'll post the obvious patch. Meanwhile:
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Peter, would you be willing to apply this directly as a build fix, or
would you prefer a pull request?
next prev parent reply other threads:[~2016-09-20 10:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 9:01 [Qemu-devel] [PATCH] build-sys: fix make install regression riku.voipio
2016-09-20 9:15 ` Marc-André Lureau
2016-09-20 10:05 ` Markus Armbruster [this message]
2016-09-20 10:57 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ponysx7r.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.