From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [FIXUP] drm: remove `const` attribute to hint at caller that they now own the memory Date: Tue, 16 Aug 2016 14:04:21 +0300 Message-ID: <87pop9t1oq.fsf@intel.com> References: <20160815135207.GG6232@phenom.ffwll.local> <20160815152955.24843-1-eric.engestrom@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160815152955.24843-1-eric.engestrom@imgtec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Eric Engestrom , linux-kernel@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org ClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKCk9uIE1v biwgMTUgQXVnIDIwMTYsIEVyaWMgRW5nZXN0cm9tIDxlcmljLmVuZ2VzdHJvbUBpbWd0ZWMuY29t PiB3cm90ZToKPiBTaWduZWQtb2ZmLWJ5OiBFcmljIEVuZ2VzdHJvbSA8ZXJpYy5lbmdlc3Ryb21A aW1ndGVjLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3YxMF8w LmMgICAgICAgICAgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2RjZV92MTFf MC5jICAgICAgICAgIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2Vfdjhf MC5jICAgICAgICAgICB8IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyAgICAg ICAgICAgICAgICAgICAgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jICAgICAg ICAgICAgICAgICAgICAgIHwgOCArKysrLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJj Yy5jICAgICAgICAgICAgICAgICAgICB8IDQgKystLQo+ICBkcml2ZXJzL2dwdS9kcm0vaGlzaWxp Y29uL2tpcmluL2tpcmluX2RybV9hZGUuYyB8IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kZWJ1Z2ZzLmMgICAgICAgICAgICAgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2F0b21pY19wbGFuZS5jICAgICAgIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMgICAgICAgICAgICB8IDQgKystLQo+ICBkcml2ZXJzL2dwdS9kcm0v cmFkZW9uL2F0b21iaW9zX2NydGMuYyAgICAgICAgICB8IDQgKystLQo+ICBpbmNsdWRlL2RybS9k cm1fZm91cmNjLmggICAgICAgICAgICAgICAgICAgICAgICB8IDIgKy0KPiAgMTIgZmlsZXMgY2hh bmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3YxMF8wLmMgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9kY2VfdjEwXzAuYwo+IGluZGV4IDBiZjg5NTkuLjc0MWRhMzYgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3YxMF8wLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2VfdjEwXzAuYwo+IEBAIC0yMDcxLDcgKzIwNzEsNyBA QCBzdGF0aWMgaW50IGRjZV92MTBfMF9jcnRjX2RvX3NldF9iYXNlKHN0cnVjdCBkcm1fY3J0YyAq Y3J0YywKPiAgCXUzMiB0bXAsIHZpZXdwb3J0X3csIHZpZXdwb3J0X2g7Cj4gIAlpbnQgcjsKPiAg CWJvb2wgYnlwYXNzX2x1dCA9IGZhbHNlOwo+IC0JY29uc3QgY2hhciAqZm9ybWF0X25hbWU7Cj4g KwljaGFyICpmb3JtYXRfbmFtZTsKPiAgCj4gIAkvKiBubyBmYiBib3VuZCAqLwo+ICAJaWYgKCFh dG9taWMgJiYgIWNydGMtPnByaW1hcnktPmZiKSB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2RjZV92MTFfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv ZGNlX3YxMV8wLmMKPiBpbmRleCAxNTU4YTk3Li4yMjgyZWI2IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2RjZV92MTFfMC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvZGNlX3YxMV8wLmMKPiBAQCAtMjA0Niw3ICsyMDQ2LDcgQEAgc3RhdGljIGlu dCBkY2VfdjExXzBfY3J0Y19kb19zZXRfYmFzZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gIAl1 MzIgdG1wLCB2aWV3cG9ydF93LCB2aWV3cG9ydF9oOwo+ICAJaW50IHI7Cj4gIAlib29sIGJ5cGFz c19sdXQgPSBmYWxzZTsKPiAtCWNvbnN0IGNoYXIgKmZvcm1hdF9uYW1lOwo+ICsJY2hhciAqZm9y bWF0X25hbWU7Cj4gIAo+ICAJLyogbm8gZmIgYm91bmQgKi8KPiAgCWlmICghYXRvbWljICYmICFj cnRjLT5wcmltYXJ5LT5mYikgewo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9kY2VfdjhfMC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3Y4XzAuYwo+ IGluZGV4IDcxYTAzNzUuLjhiN2FkMzQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvZGNlX3Y4XzAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Rj ZV92OF8wLmMKPiBAQCAtMTk1Miw3ICsxOTUyLDcgQEAgc3RhdGljIGludCBkY2VfdjhfMF9jcnRj X2RvX3NldF9iYXNlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCXUzMiB2aWV3cG9ydF93LCB2 aWV3cG9ydF9oOwo+ICAJaW50IHI7Cj4gIAlib29sIGJ5cGFzc19sdXQgPSBmYWxzZTsKPiAtCWNv bnN0IGNoYXIgKmZvcm1hdF9uYW1lOwo+ICsJY2hhciAqZm9ybWF0X25hbWU7Cj4gIAo+ICAJLyog bm8gZmIgYm91bmQgKi8KPiAgCWlmICghYXRvbWljICYmICFjcnRjLT5wcmltYXJ5LT5mYikgewo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jIGIvZHJpdmVycy9ncHUv ZHJtL2RybV9hdG9taWMuYwo+IGluZGV4IDA4NzM5MWYuLjVjYjJlMjIgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljLmMKPiBAQCAtODM3LDcgKzgzNyw3IEBAIHN0YXRpYyBpbnQgZHJtX2F0b21pY19wbGFu ZV9jaGVjayhzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgCS8qIENoZWNrIHdoZXRoZXIgdGhp cyBwbGFuZSBzdXBwb3J0cyB0aGUgZmIgcGl4ZWwgZm9ybWF0LiAqLwo+ICAJcmV0ID0gZHJtX3Bs YW5lX2NoZWNrX3BpeGVsX2Zvcm1hdChwbGFuZSwgc3RhdGUtPmZiLT5waXhlbF9mb3JtYXQpOwo+ ICAJaWYgKHJldCkgewo+IC0JCWNvbnN0IGNoYXIgKmZvcm1hdF9uYW1lID0gZHJtX2dldF9mb3Jt YXRfbmFtZShzdGF0ZS0+ZmItPnBpeGVsX2Zvcm1hdCk7Cj4gKwkJY2hhciAqZm9ybWF0X25hbWUg PSBkcm1fZ2V0X2Zvcm1hdF9uYW1lKHN0YXRlLT5mYi0+cGl4ZWxfZm9ybWF0KTsKPiAgCQlEUk1f REVCVUdfQVRPTUlDKCJJbnZhbGlkIHBpeGVsIGZvcm1hdCAlc1xuIiwgZm9ybWF0X25hbWUpOwo+ ICAJCWtmcmVlKGZvcm1hdF9uYW1lKTsKPiAgCQlyZXR1cm4gcmV0Owo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4g aW5kZXggN2RhNWQzMy4uMzBhYjI4YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gQEAgLTI1OTIsNyAr MjU5Miw3IEBAIHN0YXRpYyBpbnQgX19zZXRwbGFuZV9pbnRlcm5hbChzdHJ1Y3QgZHJtX3BsYW5l ICpwbGFuZSwKPiAgCS8qIENoZWNrIHdoZXRoZXIgdGhpcyBwbGFuZSBzdXBwb3J0cyB0aGUgZmIg cGl4ZWwgZm9ybWF0LiAqLwo+ICAJcmV0ID0gZHJtX3BsYW5lX2NoZWNrX3BpeGVsX2Zvcm1hdChw bGFuZSwgZmItPnBpeGVsX2Zvcm1hdCk7Cj4gIAlpZiAocmV0KSB7Cj4gLQkJY29uc3QgY2hhciAq Zm9ybWF0X25hbWUgPSBkcm1fZ2V0X2Zvcm1hdF9uYW1lKGZiLT5waXhlbF9mb3JtYXQpOwo+ICsJ CWNoYXIgKmZvcm1hdF9uYW1lID0gZHJtX2dldF9mb3JtYXRfbmFtZShmYi0+cGl4ZWxfZm9ybWF0 KTsKPiAgCQlEUk1fREVCVUdfS01TKCJJbnZhbGlkIHBpeGVsIGZvcm1hdCAlc1xuIiwgZm9ybWF0 X25hbWUpOwo+ICAJCWtmcmVlKGZvcm1hdF9uYW1lKTsKPiAgCQlnb3RvIG91dDsKPiBAQCAtMjkw Myw3ICsyOTAzLDcgQEAgaW50IGRybV9tb2RlX3NldGNydGMoc3RydWN0IGRybV9kZXZpY2UgKmRl diwgdm9pZCAqZGF0YSwKPiAgCQkJcmV0ID0gZHJtX3BsYW5lX2NoZWNrX3BpeGVsX2Zvcm1hdChj cnRjLT5wcmltYXJ5LAo+ICAJCQkJCQkJICAgZmItPnBpeGVsX2Zvcm1hdCk7Cj4gIAkJCWlmIChy ZXQpIHsKPiAtCQkJCWNvbnN0IGNoYXIgKmZvcm1hdF9uYW1lID0gZHJtX2dldF9mb3JtYXRfbmFt ZShmYi0+cGl4ZWxfZm9ybWF0KTsKPiArCQkJCWNoYXIgKmZvcm1hdF9uYW1lID0gZHJtX2dldF9m b3JtYXRfbmFtZShmYi0+cGl4ZWxfZm9ybWF0KTsKPiAgCQkJCURSTV9ERUJVR19LTVMoIkludmFs aWQgcGl4ZWwgZm9ybWF0ICVzXG4iLCBmb3JtYXRfbmFtZSk7Cj4gIAkJCQlrZnJlZShmb3JtYXRf bmFtZSk7Cj4gIAkJCQlnb3RvIG91dDsKPiBAQCAtMzI4MSw3ICszMjgxLDcgQEAgaW50IGRybV9t b2RlX2FkZGZiKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIHN0YXRpYyBpbnQgZm9ybWF0X2No ZWNrKGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9mYl9jbWQyICpyKQo+ICB7Cj4gIAl1aW50MzJfdCBm b3JtYXQgPSByLT5waXhlbF9mb3JtYXQgJiB+RFJNX0ZPUk1BVF9CSUdfRU5ESUFOOwo+IC0JY29u c3QgY2hhciAqZm9ybWF0X25hbWU7Cj4gKwljaGFyICpmb3JtYXRfbmFtZTsKPiAgCj4gIAlzd2l0 Y2ggKGZvcm1hdCkgewo+ICAJY2FzZSBEUk1fRk9STUFUX0M4Ogo+IEBAIC0zMzU5LDcgKzMzNTks NyBAQCBzdGF0aWMgaW50IGZyYW1lYnVmZmVyX2NoZWNrKGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9m Yl9jbWQyICpyKQo+ICAKPiAgCXJldCA9IGZvcm1hdF9jaGVjayhyKTsKPiAgCWlmIChyZXQpIHsK PiAtCQljb25zdCBjaGFyICpmb3JtYXRfbmFtZSA9IGRybV9nZXRfZm9ybWF0X25hbWUoci0+cGl4 ZWxfZm9ybWF0KTsKPiArCQljaGFyICpmb3JtYXRfbmFtZSA9IGRybV9nZXRfZm9ybWF0X25hbWUo ci0+cGl4ZWxfZm9ybWF0KTsKPiAgCQlEUk1fREVCVUdfS01TKCJiYWQgZnJhbWVidWZmZXIgZm9y bWF0ICVzXG4iLCBmb3JtYXRfbmFtZSk7Cj4gIAkJa2ZyZWUoZm9ybWF0X25hbWUpOwo+ICAJCXJl dHVybiByZXQ7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZm91cmNjLmMgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jCj4gaW5kZXggMzgyMTZhMS4uNDFkMDZkNiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2RybV9mb3VyY2MuYwo+IEBAIC00Miw3ICs0Miw3IEBAIHN0YXRpYyBjaGFyIHByaW50 YWJsZV9jaGFyKGludCBjKQo+ICAgKiBOb3RlIHRoYXQgdGhlIGJ1ZmZlciByZXR1cm5lZCBieSB0 aGlzIGZ1bmN0aW9uIGlzIG93bmVkIGJ5IHRoZSBjYWxsZXIKPiAgICogYW5kIHdpbGwgbmVlZCB0 byBiZSBmcmVlZC4KPiAgICovCj4gLWNvbnN0IGNoYXIgKmRybV9nZXRfZm9ybWF0X25hbWUodWlu dDMyX3QgZm9ybWF0KQo+ICtjaGFyICpkcm1fZ2V0X2Zvcm1hdF9uYW1lKHVpbnQzMl90IGZvcm1h dCkKPiAgewo+ICAJY2hhciAqYnVmID0ga21hbGxvYygzMiwgR0ZQX0tFUk5FTCk7Cj4gIAo+IEBA IC03MSw3ICs3MSw3IEBAIEVYUE9SVF9TWU1CT0woZHJtX2dldF9mb3JtYXRfbmFtZSk7Cj4gIHZv aWQgZHJtX2ZiX2dldF9icHBfZGVwdGgodWludDMyX3QgZm9ybWF0LCB1bnNpZ25lZCBpbnQgKmRl cHRoLAo+ICAJCQkgIGludCAqYnBwKQo+ICB7Cj4gLQljb25zdCBjaGFyICpmb3JtYXRfbmFtZTsK PiArCWNoYXIgKmZvcm1hdF9uYW1lOwo+ICAKPiAgCXN3aXRjaCAoZm9ybWF0KSB7Cj4gIAljYXNl IERSTV9GT1JNQVRfQzg6Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24v a2lyaW4va2lyaW5fZHJtX2FkZS5jIGIvZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9raXJpbi9r aXJpbl9kcm1fYWRlLmMKPiBpbmRleCBhYzdmYTAyLi5lYWEzZGY3IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9oaXNpbGljb24va2lyaW4va2lyaW5fZHJtX2FkZS5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2hpc2lsaWNvbi9raXJpbi9raXJpbl9kcm1fYWRlLmMKPiBAQCAtNjA4LDcg KzYwOCw3IEBAIHN0YXRpYyB2b2lkIGFkZV9yZG1hX3NldCh2b2lkIF9faW9tZW0gKmJhc2UsIHN0 cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ICAJCQkgdTMyIGNoLCB1MzIgeSwgdTMyIGluX2gs IHUzMiBmbXQpCj4gIHsKPiAgCXN0cnVjdCBkcm1fZ2VtX2NtYV9vYmplY3QgKm9iaiA9IGRybV9m Yl9jbWFfZ2V0X2dlbV9vYmooZmIsIDApOwo+IC0JY29uc3QgY2hhciAqZm9ybWF0X25hbWU7Cj4g KwljaGFyICpmb3JtYXRfbmFtZTsKPiAgCXUzMiByZWdfY3RybCwgcmVnX2FkZHIsIHJlZ19zaXpl LCByZWdfc3RyaWRlLCByZWdfc3BhY2UsIHJlZ19lbjsKPiAgCXUzMiBzdHJpZGUgPSBmYi0+cGl0 Y2hlc1swXTsKPiAgCXUzMiBhZGRyID0gKHUzMilvYmotPnBhZGRyICsgeSAqIHN0cmlkZTsKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IGluZGV4IDkwNDcyMGIuLmU1Y2RkZWEgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IEBAIC0zMTA5LDcgKzMxMDksNyBA QCBzdGF0aWMgdm9pZCBpbnRlbF9wbGFuZV9pbmZvKHN0cnVjdCBzZXFfZmlsZSAqbSwgc3RydWN0 IGludGVsX2NydGMgKmludGVsX2NydGMpCj4gIAlmb3JfZWFjaF9pbnRlbF9wbGFuZV9vbl9jcnRj KGRldiwgaW50ZWxfY3J0YywgaW50ZWxfcGxhbmUpIHsKPiAgCQlzdHJ1Y3QgZHJtX3BsYW5lX3N0 YXRlICpzdGF0ZTsKPiAgCQlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSA9ICZpbnRlbF9wbGFuZS0+ YmFzZTsKPiAtCQljb25zdCBjaGFyICpmb3JtYXRfbmFtZTsKPiArCQljaGFyICpmb3JtYXRfbmFt ZTsKPiAgCj4gIAkJaWYgKCFwbGFuZS0+c3RhdGUpIHsKPiAgCQkJc2VxX3B1dHMobSwgInBsYW5l LT5zdGF0ZSBpcyBOVUxMIVxuIik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2F0b21pY19wbGFuZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWlj X3BsYW5lLmMKPiBpbmRleCBlMDYxMzFhLi4yOGZlMDBkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfYXRvbWljX3BsYW5lLmMKPiBAQCAtMTU3LDcgKzE1Nyw3IEBAIHN0YXRpYyBp bnQgaW50ZWxfcGxhbmVfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICAJ CWNydGNfc3RhdGUtPmJhc2UuZW5hYmxlID8gY3J0Y19zdGF0ZS0+cGlwZV9zcmNfaCA6IDA7Cj4g IAo+ICAJaWYgKHN0YXRlLT5mYiAmJiBpbnRlbF9yb3RhdGlvbl85MF9vcl8yNzAoc3RhdGUtPnJv dGF0aW9uKSkgewo+IC0JCWNvbnN0IGNoYXIgKmZvcm1hdF9uYW1lOwo+ICsJCWNoYXIgKmZvcm1h dF9uYW1lOwo+ICAJCWlmICghKHN0YXRlLT5mYi0+bW9kaWZpZXJbMF0gPT0gSTkxNV9GT1JNQVRf TU9EX1lfVElMRUQgfHwKPiAgCQkJc3RhdGUtPmZiLT5tb2RpZmllclswXSA9PSBJOTE1X0ZPUk1B VF9NT0RfWWZfVElMRUQpKSB7Cj4gIAkJCURSTV9ERUJVR19LTVMoIlkvWWYgdGlsaW5nIHJlcXVp cmVkIGZvciA5MC8yNzAhXG4iKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4g aW5kZXggYWFhZGExNS4uYjFkNzAxZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPiBAQCAtMTIyNjQsNyArMTIyNjQsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9kdW1wX3Bp cGVfY29uZmlnKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAKPiAgCURSTV9ERUJVR19LTVMo InBsYW5lcyBvbiB0aGlzIGNydGNcbiIpOwo+ICAJbGlzdF9mb3JfZWFjaF9lbnRyeShwbGFuZSwg JmRldi0+bW9kZV9jb25maWcucGxhbmVfbGlzdCwgaGVhZCkgewo+IC0JCWNvbnN0IGNoYXIgKmZv cm1hdF9uYW1lOwo+ICsJCWNoYXIgKmZvcm1hdF9uYW1lOwo+ICAJCWludGVsX3BsYW5lID0gdG9f aW50ZWxfcGxhbmUocGxhbmUpOwo+ICAJCWlmIChpbnRlbF9wbGFuZS0+cGlwZSAhPSBjcnRjLT5w aXBlKQo+ICAJCQljb250aW51ZTsKPiBAQCAtMTQ5MjIsNyArMTQ5MjIsNyBAQCBzdGF0aWMgaW50 IGludGVsX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCXVuc2ln bmVkIGludCBhbGlnbmVkX2hlaWdodDsKPiAgCWludCByZXQ7Cj4gIAl1MzIgcGl0Y2hfbGltaXQs IHN0cmlkZV9hbGlnbm1lbnQ7Cj4gLQljb25zdCBjaGFyICpmb3JtYXRfbmFtZTsKPiArCWNoYXIg KmZvcm1hdF9uYW1lOwo+ICAKPiAgCVdBUk5fT04oIW11dGV4X2lzX2xvY2tlZCgmZGV2LT5zdHJ1 Y3RfbXV0ZXgpKTsKPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vYXRv bWJpb3NfY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9hdG9tYmlvc19jcnRjLmMKPiBp bmRleCA5ODFjYTNmLi5hODljNDgwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRl b24vYXRvbWJpb3NfY3J0Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9hdG9tYmlv c19jcnRjLmMKPiBAQCAtMTE1NCw3ICsxMTU0LDcgQEAgc3RhdGljIGludCBkY2U0X2NydGNfZG9f c2V0X2Jhc2Uoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJdTMyIHRtcCwgdmlld3BvcnRfdywg dmlld3BvcnRfaDsKPiAgCWludCByOwo+ICAJYm9vbCBieXBhc3NfbHV0ID0gZmFsc2U7Cj4gLQlj b25zdCBjaGFyICpmb3JtYXRfbmFtZTsKPiArCWNoYXIgKmZvcm1hdF9uYW1lOwo+ICAKPiAgCS8q IG5vIGZiIGJvdW5kICovCj4gIAlpZiAoIWF0b21pYyAmJiAhY3J0Yy0+cHJpbWFyeS0+ZmIpIHsK PiBAQCAtMTQ3MSw3ICsxNDcxLDcgQEAgc3RhdGljIGludCBhdml2b19jcnRjX2RvX3NldF9iYXNl KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCXUzMiB2aWV3cG9ydF93LCB2aWV3cG9ydF9oOwo+ ICAJaW50IHI7Cj4gIAlib29sIGJ5cGFzc19sdXQgPSBmYWxzZTsKPiAtCWNvbnN0IGNoYXIgKmZv cm1hdF9uYW1lOwo+ICsJY2hhciAqZm9ybWF0X25hbWU7Cj4gIAo+ICAJLyogbm8gZmIgYm91bmQg Ki8KPiAgCWlmICghYXRvbWljICYmICFjcnRjLT5wcmltYXJ5LT5mYikgewo+IGRpZmYgLS1naXQg YS9pbmNsdWRlL2RybS9kcm1fZm91cmNjLmggYi9pbmNsdWRlL2RybS9kcm1fZm91cmNjLmgKPiBp bmRleCAwMzBkMjJkLi5iMTA2MzM3IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9mb3Vy Y2MuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9mb3VyY2MuaAo+IEBAIC0zMiw2ICszMiw2IEBA IGludCBkcm1fZm9ybWF0X2hvcnpfY2hyb21hX3N1YnNhbXBsaW5nKHVpbnQzMl90IGZvcm1hdCk7 Cj4gIGludCBkcm1fZm9ybWF0X3ZlcnRfY2hyb21hX3N1YnNhbXBsaW5nKHVpbnQzMl90IGZvcm1h dCk7Cj4gIGludCBkcm1fZm9ybWF0X3BsYW5lX3dpZHRoKGludCB3aWR0aCwgdWludDMyX3QgZm9y bWF0LCBpbnQgcGxhbmUpOwo+ICBpbnQgZHJtX2Zvcm1hdF9wbGFuZV9oZWlnaHQoaW50IGhlaWdo dCwgdWludDMyX3QgZm9ybWF0LCBpbnQgcGxhbmUpOwo+IC1jb25zdCBjaGFyICpkcm1fZ2V0X2Zv cm1hdF9uYW1lKHVpbnQzMl90IGZvcm1hdCkgX19tYWxsb2M7Cj4gK2NoYXIgKmRybV9nZXRfZm9y bWF0X25hbWUodWludDMyX3QgZm9ybWF0KSBfX21hbGxvYzsKPiAgCj4gICNlbmRpZiAvKiBfX0RS TV9GT1VSQ0NfSF9fICovCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hu b2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753450AbcHPLKr (ORCPT ); Tue, 16 Aug 2016 07:10:47 -0400 Received: from mga09.intel.com ([134.134.136.24]:45336 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753281AbcHPLKp (ORCPT ); Tue, 16 Aug 2016 07:10:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,529,1464678000"; d="scan'208";a="1041985197" From: Jani Nikula To: Eric Engestrom , linux-kernel@vger.kernel.org Cc: Daniel Vetter , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: Re: [FIXUP] drm: remove `const` attribute to hint at caller that they now own the memory In-Reply-To: <20160815152955.24843-1-eric.engestrom@imgtec.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20160815135207.GG6232@phenom.ffwll.local> <20160815152955.24843-1-eric.engestrom@imgtec.com> User-Agent: Notmuch/0.22.1+63~g648dcc7 (https://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 16 Aug 2016 14:04:21 +0300 Message-ID: <87pop9t1oq.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Jani Nikula On Mon, 15 Aug 2016, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- > drivers/gpu/drm/drm_atomic.c | 2 +- > drivers/gpu/drm/drm_crtc.c | 8 ++++---- > drivers/gpu/drm/drm_fourcc.c | 4 ++-- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +- > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- > drivers/gpu/drm/i915/intel_atomic_plane.c | 2 +- > drivers/gpu/drm/i915/intel_display.c | 4 ++-- > drivers/gpu/drm/radeon/atombios_crtc.c | 4 ++-- > include/drm/drm_fourcc.h | 2 +- > 12 files changed, 18 insertions(+), 18 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c > index 0bf8959..741da36 100644 > --- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c > @@ -2071,7 +2071,7 @@ static int dce_v10_0_crtc_do_set_base(struct drm_crtc *crtc, > u32 tmp, viewport_w, viewport_h; > int r; > bool bypass_lut = false; > - const char *format_name; > + char *format_name; > > /* no fb bound */ > if (!atomic && !crtc->primary->fb) { > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c > index 1558a97..2282eb6 100644 > --- a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c > @@ -2046,7 +2046,7 @@ static int dce_v11_0_crtc_do_set_base(struct drm_crtc *crtc, > u32 tmp, viewport_w, viewport_h; > int r; > bool bypass_lut = false; > - const char *format_name; > + char *format_name; > > /* no fb bound */ > if (!atomic && !crtc->primary->fb) { > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c > index 71a0375..8b7ad34 100644 > --- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c > @@ -1952,7 +1952,7 @@ static int dce_v8_0_crtc_do_set_base(struct drm_crtc *crtc, > u32 viewport_w, viewport_h; > int r; > bool bypass_lut = false; > - const char *format_name; > + char *format_name; > > /* no fb bound */ > if (!atomic && !crtc->primary->fb) { > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index 087391f..5cb2e22 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -837,7 +837,7 @@ static int drm_atomic_plane_check(struct drm_plane *plane, > /* Check whether this plane supports the fb pixel format. */ > ret = drm_plane_check_pixel_format(plane, state->fb->pixel_format); > if (ret) { > - const char *format_name = drm_get_format_name(state->fb->pixel_format); > + char *format_name = drm_get_format_name(state->fb->pixel_format); > DRM_DEBUG_ATOMIC("Invalid pixel format %s\n", format_name); > kfree(format_name); > return ret; > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 7da5d33..30ab28b 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -2592,7 +2592,7 @@ static int __setplane_internal(struct drm_plane *plane, > /* Check whether this plane supports the fb pixel format. */ > ret = drm_plane_check_pixel_format(plane, fb->pixel_format); > if (ret) { > - const char *format_name = drm_get_format_name(fb->pixel_format); > + char *format_name = drm_get_format_name(fb->pixel_format); > DRM_DEBUG_KMS("Invalid pixel format %s\n", format_name); > kfree(format_name); > goto out; > @@ -2903,7 +2903,7 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data, > ret = drm_plane_check_pixel_format(crtc->primary, > fb->pixel_format); > if (ret) { > - const char *format_name = drm_get_format_name(fb->pixel_format); > + char *format_name = drm_get_format_name(fb->pixel_format); > DRM_DEBUG_KMS("Invalid pixel format %s\n", format_name); > kfree(format_name); > goto out; > @@ -3281,7 +3281,7 @@ int drm_mode_addfb(struct drm_device *dev, > static int format_check(const struct drm_mode_fb_cmd2 *r) > { > uint32_t format = r->pixel_format & ~DRM_FORMAT_BIG_ENDIAN; > - const char *format_name; > + char *format_name; > > switch (format) { > case DRM_FORMAT_C8: > @@ -3359,7 +3359,7 @@ static int framebuffer_check(const struct drm_mode_fb_cmd2 *r) > > ret = format_check(r); > if (ret) { > - const char *format_name = drm_get_format_name(r->pixel_format); > + char *format_name = drm_get_format_name(r->pixel_format); > DRM_DEBUG_KMS("bad framebuffer format %s\n", format_name); > kfree(format_name); > return ret; > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > index 38216a1..41d06d6 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -42,7 +42,7 @@ static char printable_char(int c) > * Note that the buffer returned by this function is owned by the caller > * and will need to be freed. > */ > -const char *drm_get_format_name(uint32_t format) > +char *drm_get_format_name(uint32_t format) > { > char *buf = kmalloc(32, GFP_KERNEL); > > @@ -71,7 +71,7 @@ EXPORT_SYMBOL(drm_get_format_name); > void drm_fb_get_bpp_depth(uint32_t format, unsigned int *depth, > int *bpp) > { > - const char *format_name; > + char *format_name; > > switch (format) { > case DRM_FORMAT_C8: > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c > index ac7fa02..eaa3df7 100644 > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c > @@ -608,7 +608,7 @@ static void ade_rdma_set(void __iomem *base, struct drm_framebuffer *fb, > u32 ch, u32 y, u32 in_h, u32 fmt) > { > struct drm_gem_cma_object *obj = drm_fb_cma_get_gem_obj(fb, 0); > - const char *format_name; > + char *format_name; > u32 reg_ctrl, reg_addr, reg_size, reg_stride, reg_space, reg_en; > u32 stride = fb->pitches[0]; > u32 addr = (u32)obj->paddr + y * stride; > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index 904720b..e5cddea 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -3109,7 +3109,7 @@ static void intel_plane_info(struct seq_file *m, struct intel_crtc *intel_crtc) > for_each_intel_plane_on_crtc(dev, intel_crtc, intel_plane) { > struct drm_plane_state *state; > struct drm_plane *plane = &intel_plane->base; > - const char *format_name; > + char *format_name; > > if (!plane->state) { > seq_puts(m, "plane->state is NULL!\n"); > diff --git a/drivers/gpu/drm/i915/intel_atomic_plane.c b/drivers/gpu/drm/i915/intel_atomic_plane.c > index e06131a..28fe00d 100644 > --- a/drivers/gpu/drm/i915/intel_atomic_plane.c > +++ b/drivers/gpu/drm/i915/intel_atomic_plane.c > @@ -157,7 +157,7 @@ static int intel_plane_atomic_check(struct drm_plane *plane, > crtc_state->base.enable ? crtc_state->pipe_src_h : 0; > > if (state->fb && intel_rotation_90_or_270(state->rotation)) { > - const char *format_name; > + char *format_name; > if (!(state->fb->modifier[0] == I915_FORMAT_MOD_Y_TILED || > state->fb->modifier[0] == I915_FORMAT_MOD_Yf_TILED)) { > DRM_DEBUG_KMS("Y/Yf tiling required for 90/270!\n"); > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index aaada15..b1d701f 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -12264,7 +12264,7 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc, > > DRM_DEBUG_KMS("planes on this crtc\n"); > list_for_each_entry(plane, &dev->mode_config.plane_list, head) { > - const char *format_name; > + char *format_name; > intel_plane = to_intel_plane(plane); > if (intel_plane->pipe != crtc->pipe) > continue; > @@ -14922,7 +14922,7 @@ static int intel_framebuffer_init(struct drm_device *dev, > unsigned int aligned_height; > int ret; > u32 pitch_limit, stride_alignment; > - const char *format_name; > + char *format_name; > > WARN_ON(!mutex_is_locked(&dev->struct_mutex)); > > diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c > index 981ca3f..a89c480 100644 > --- a/drivers/gpu/drm/radeon/atombios_crtc.c > +++ b/drivers/gpu/drm/radeon/atombios_crtc.c > @@ -1154,7 +1154,7 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc, > u32 tmp, viewport_w, viewport_h; > int r; > bool bypass_lut = false; > - const char *format_name; > + char *format_name; > > /* no fb bound */ > if (!atomic && !crtc->primary->fb) { > @@ -1471,7 +1471,7 @@ static int avivo_crtc_do_set_base(struct drm_crtc *crtc, > u32 viewport_w, viewport_h; > int r; > bool bypass_lut = false; > - const char *format_name; > + char *format_name; > > /* no fb bound */ > if (!atomic && !crtc->primary->fb) { > diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h > index 030d22d..b106337 100644 > --- a/include/drm/drm_fourcc.h > +++ b/include/drm/drm_fourcc.h > @@ -32,6 +32,6 @@ int drm_format_horz_chroma_subsampling(uint32_t format); > int drm_format_vert_chroma_subsampling(uint32_t format); > int drm_format_plane_width(int width, uint32_t format, int plane); > int drm_format_plane_height(int height, uint32_t format, int plane); > -const char *drm_get_format_name(uint32_t format) __malloc; > +char *drm_get_format_name(uint32_t format) __malloc; > > #endif /* __DRM_FOURCC_H__ */ -- Jani Nikula, Intel Open Source Technology Center