All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Nikolaus Rath <Nikolaus@rath.org>
Cc: fuse-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org,
	"Miklos Szeredi" <miklos@szeredi.hu>,
	"Michael j Theall" <mtheall@us.ibm.com>,
	"Jean-Pierre André" <jean-pierre.andre@wanadoo.fr>,
	"Seth Forshee" <seth.forshee@canonical.com>
Subject: Re: [RFC v3 0/2] Support for posix acls in fuse
Date: Mon, 08 Aug 2016 19:27:50 -0500	[thread overview]
Message-ID: <87popilrax.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <874m6u3j1p.fsf@thinkpad.rath.org> (Nikolaus Rath's message of "Mon, 08 Aug 2016 17:03:30 -0700")

Nikolaus Rath <Nikolaus@rath.org> writes:

> On Aug 01 2016, Seth Forshee <seth.forshee@canonical.com> wrote:
>>  - Remove passthrough of acl xattrs when fuse acl support is disabled or
>>    default_permissions is not used.
>>
>> This last change is user visible, but as fuse filesystems cannot
>> meaninfully support acls today it's not really a regression.
>
> Are you sure about that? I believe there are FUSE file systems out there
> that are parsing/constructing the kernel's xattr representation and
> (together with no_default_permissions) support ACLs. Or is there another
> problem?

fuse_permission does not have a mode where it always call into the
filesystem.  Without FUSE_DEFAULT_PERMISSIONS set the underlying
filesystem is at most called when the syscalls chdir, access, and
execve are called. (Basically

Which means there is no way to enforce any kind of general acls in fuse
without changes.

That said I we seem to have figured out an implmenetation where
passthrough is maintained for the time being when posix acl support is
not enabled.  And Miklos figures libfuse needs to parse the the xattr
anyway so that the filesystems can have atomic mode changes instead of
having two separate calls, one to setattr and another to setxattr.

So I don't believe when the dust settles there is any danger of
regression, despite the code not yet working in a way that enforces
acls.


Eric

  reply	other threads:[~2016-08-09  0:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01 21:27 [RFC v3 0/2] Support for posix acls in fuse Seth Forshee
2016-08-01 21:27 ` [RFC v3 1/2] fuse: Use generic xattr ops Seth Forshee
2016-08-04 11:09   ` Miklos Szeredi
2016-08-04 14:12     ` Seth Forshee
2016-08-01 21:27 ` [RFC v3 2/2] fuse: Add posix acl support Seth Forshee
2016-08-04 12:11   ` Miklos Szeredi
     [not found]     ` <CAJfpegtzeJid8tHkz66scDcpCjNEEwtBb4m8MQqq7u+SCdj3dQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-04 12:40       ` Ravishankar N
2016-08-04 14:11     ` Seth Forshee
2016-08-05 23:07       ` Eric W. Biederman
2016-08-06  1:52         ` Seth Forshee
2016-08-06 21:09           ` Miklos Szeredi
2016-08-07  3:46             ` Seth Forshee
2016-08-07 12:59               ` Eric W. Biederman
     [not found]                 ` <87popkrazt.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-08-07 13:51                   ` Seth Forshee
2016-08-16 20:59     ` Seth Forshee
2016-08-17 12:01       ` Miklos Szeredi
2016-08-01 23:03 ` [RFC v3 0/2] Support for posix acls in fuse Nikolaus Rath
2016-08-02  3:39   ` Seth Forshee
2016-08-02 15:13     ` [fuse-devel] " Michael Theall
2016-08-09  0:00       ` Nikolaus Rath
2016-08-09  0:03 ` Nikolaus Rath
2016-08-09  0:27   ` Eric W. Biederman [this message]
2016-08-09 22:44     ` Nikolaus Rath
2016-08-09  7:06   ` Jean-Pierre André

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87popilrax.fsf@x220.int.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=Nikolaus@rath.org \
    --cc=fuse-devel@lists.sourceforge.net \
    --cc=jean-pierre.andre@wanadoo.fr \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=mtheall@us.ibm.com \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.