From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/6] lib: string: add function strtolower() Date: Fri, 01 Jul 2016 13:52:34 +0300 Message-ID: <87poqxpr4d.fsf@intel.com> References: <1467330612-26242-1-git-send-email-mmayer@broadcom.com> <1467330612-26242-2-git-send-email-mmayer@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1467330612-26242-2-git-send-email-mmayer@broadcom.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrew Morton , Al Viro , Rasmus Villemoes , Chris Metcalf , Kees Cook Cc: devel@driverdev.osuosl.org, linux-scsi@vger.kernel.org, nouveau@lists.freedesktop.org, speakup@linux-speakup.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org, target-devel@vger.kernel.org, Markus Mayer , devel@acpica.org List-Id: linux-acpi@vger.kernel.org T24gRnJpLCAwMSBKdWwgMjAxNiwgTWFya3VzIE1heWVyIDxtbWF5ZXJAYnJvYWRjb20uY29tPiB3 cm90ZToKPiBBZGQgYSBmdW5jdGlvbiBjYWxsZWQgc3RydG9sb3dlcigpIHRvIGNvbnZlcnQgc3Ry aW5ncyB0byBsb3dlciBjYXNlCj4gaW4tcGxhY2UsIG92ZXJ3cml0aW5nIHRoZSBvcmlnaW5hbCBz dHJpbmcuCj4KPiBUaGlzIHNlZW1zIHRvIGJlIGEgcmVjdXJyaW5nIHJlcXVpcmVtZW50IGluIHRo ZSBrZXJuZWwgdGhhdCBpcwo+IGN1cnJlbnRseSBiZWluZyBzb2x2ZWQgYnkgc2V2ZXJhbCBkdXBs aWNhdGVkIGltcGxlbWVudGF0aW9ucyBkb2luZyB0aGUKPiBzYW1lIHRoaW5nLgo+Cj4gU2lnbmVk LW9mZi1ieTogTWFya3VzIE1heWVyIDxtbWF5ZXJAYnJvYWRjb20uY29tPgo+IC0tLQo+ICBpbmNs dWRlL2xpbnV4L3N0cmluZy5oIHwgIDEgKwo+ICBsaWIvc3RyaW5nLmMgICAgICAgICAgIHwgMTQg KysrKysrKysrKysrKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspCj4KPiBk aWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9zdHJpbmcuaCBiL2luY2x1ZGUvbGludXgvc3RyaW5n LmgKPiBpbmRleCAyNmI2ZjZhLi5hYWQ2MDVlIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvbGludXgv c3RyaW5nLmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L3N0cmluZy5oCj4gQEAgLTExNiw2ICsxMTYs NyBAQCBleHRlcm4gdm9pZCAqIG1lbWNocihjb25zdCB2b2lkICosaW50LF9fa2VybmVsX3NpemVf dCk7Cj4gICNlbmRpZgo+ICB2b2lkICptZW1jaHJfaW52KGNvbnN0IHZvaWQgKnMsIGludCBjLCBz aXplX3Qgbik7Cj4gIGNoYXIgKnN0cnJlcGxhY2UoY2hhciAqcywgY2hhciBvbGQsIGNoYXIgbmV3 KTsKPiArY2hhciAqc3RydG9sb3dlcihjaGFyICpzKTsKPiAgCj4gIGV4dGVybiB2b2lkIGtmcmVl X2NvbnN0KGNvbnN0IHZvaWQgKngpOwo+ICAKPiBkaWZmIC0tZ2l0IGEvbGliL3N0cmluZy5jIGIv bGliL3N0cmluZy5jCj4gaW5kZXggZWQ4MzU2Mi4uNmUzYjU2MCAxMDA2NDQKPiAtLS0gYS9saWIv c3RyaW5nLmMKPiArKysgYi9saWIvc3RyaW5nLmMKPiBAQCAtOTUyLDMgKzk1MiwxNyBAQCBjaGFy ICpzdHJyZXBsYWNlKGNoYXIgKnMsIGNoYXIgb2xkLCBjaGFyIG5ldykKPiAgCXJldHVybiBzOwo+ ICB9Cj4gIEVYUE9SVF9TWU1CT0woc3RycmVwbGFjZSk7Cj4gKwoKVGhpcyBuZWVkcyBhIGtlcm5l bC1kb2MgY29tbWVudCByaWdodCBoZXJlLgoKPiArY2hhciAqc3RydG9sb3dlcihjaGFyICpzKQo+ ICt7Cj4gKwljaGFyICpwOwo+ICsKPiArICAgICAgICBpZiAodW5saWtlbHkoIXMpKQo+ICsgICAg ICAgICAgICAgICAgcmV0dXJuIE5VTEw7CgpVc2luZyBzcGFjZXMgZm9yIGluZGVudGF0aW9uPyBT ZWUgc2NyaXB0cy9jaGVja3BhdGNoLnBsLgoKPiArCj4gKwlmb3IgKHAgPSBzOyAqcDsgcCsrKQo+ ICsJCSpwID0gdG9sb3dlcigqcCk7Cj4gKwo+ICsJcmV0dXJuIHM7CgpXaHkgZG9lcyBpdCByZXR1 cm4gYSB2YWx1ZT8gQ291bGQgYmUgdm9pZD8KCkJSLApKYW5pLgoKPiArfQo+ICtFWFBPUlRfU1lN Qk9MKHN0cnRvbG93ZXIpOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNo bm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752240AbcGAKwn (ORCPT ); Fri, 1 Jul 2016 06:52:43 -0400 Received: from mga14.intel.com ([192.55.52.115]:28199 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751879AbcGAKwj (ORCPT ); Fri, 1 Jul 2016 06:52:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,556,1459839600"; d="scan'208";a="1013418115" From: Jani Nikula To: Markus Mayer , Andrew Morton , Al Viro , Rasmus Villemoes , Chris Metcalf , Kees Cook Cc: devel@driverdev.osuosl.org, linux-scsi@vger.kernel.org, nouveau@lists.freedesktop.org, speakup@linux-speakup.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org, target-devel@vger.kernel.org, Markus Mayer , devel@acpica.org Subject: Re: [PATCH 1/6] lib: string: add function strtolower() In-Reply-To: <1467330612-26242-2-git-send-email-mmayer@broadcom.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1467330612-26242-1-git-send-email-mmayer@broadcom.com> <1467330612-26242-2-git-send-email-mmayer@broadcom.com> User-Agent: Notmuch/0.22+12~gbdd9442 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Fri, 01 Jul 2016 13:52:34 +0300 Message-ID: <87poqxpr4d.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 01 Jul 2016, Markus Mayer wrote: > Add a function called strtolower() to convert strings to lower case > in-place, overwriting the original string. > > This seems to be a recurring requirement in the kernel that is > currently being solved by several duplicated implementations doing the > same thing. > > Signed-off-by: Markus Mayer > --- > include/linux/string.h | 1 + > lib/string.c | 14 ++++++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/include/linux/string.h b/include/linux/string.h > index 26b6f6a..aad605e 100644 > --- a/include/linux/string.h > +++ b/include/linux/string.h > @@ -116,6 +116,7 @@ extern void * memchr(const void *,int,__kernel_size_t); > #endif > void *memchr_inv(const void *s, int c, size_t n); > char *strreplace(char *s, char old, char new); > +char *strtolower(char *s); > > extern void kfree_const(const void *x); > > diff --git a/lib/string.c b/lib/string.c > index ed83562..6e3b560 100644 > --- a/lib/string.c > +++ b/lib/string.c > @@ -952,3 +952,17 @@ char *strreplace(char *s, char old, char new) > return s; > } > EXPORT_SYMBOL(strreplace); > + This needs a kernel-doc comment right here. > +char *strtolower(char *s) > +{ > + char *p; > + > + if (unlikely(!s)) > + return NULL; Using spaces for indentation? See scripts/checkpatch.pl. > + > + for (p = s; *p; p++) > + *p = tolower(*p); > + > + return s; Why does it return a value? Could be void? BR, Jani. > +} > +EXPORT_SYMBOL(strtolower); -- Jani Nikula, Intel Open Source Technology Center