All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Dexuan Cui <decui@microsoft.com>
Cc: "devel\@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"KY Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: [PATCH] tools: hv: lsvmbus: add pci pass-through UUID
Date: Mon, 25 Apr 2016 12:51:12 +0200	[thread overview]
Message-ID: <87potex8pr.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <BLUPR03MB14105BE3B5A6C1F83FB41DD0BF600@BLUPR03MB1410.namprd03.prod.outlook.com> (Dexuan Cui's message of "Sat, 23 Apr 2016 01:21:42 +0000")

Dexuan Cui <decui@microsoft.com> writes:

>> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
>> Sent: Saturday, April 23, 2016 0:21
>> To: devel@linuxdriverproject.org
>> Cc: linux-kernel@vger.kernel.org; KY Srinivasan <kys@microsoft.com>; Haiyang
>> Zhang <haiyangz@microsoft.com>; Dexuan Cui <decui@microsoft.com>
>> Subject: [PATCH] tools: hv: lsvmbus: add pci pass-through UUID
>> 
>> lsvmbus keeps its own copy of all VMBus UUIDs, add PCIe pass-through
>> device there to not report 'Unknown' for such devices.
>> 
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>> ---
>>  tools/hv/lsvmbus | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/tools/hv/lsvmbus b/tools/hv/lsvmbus
>> index 162a378..e223284 100644
>> --- a/tools/hv/lsvmbus
>> +++ b/tools/hv/lsvmbus
>> @@ -35,6 +35,7 @@ vmbus_dev_dict = {
>>  	'{ba6163d9-04a1-4d29-b605-72e2ffb1dc7f}' : 'Synthetic SCSI Controller',
>>  	'{2f9bcc4a-0069-4af3-b76b-6fd0be528cda}' : 'Synthetic fiber channel
>> adapter',
>>  	'{8c2eaf3d-32a7-4b09-ab99-bd1f1c86b501}' : 'Synthetic RDMA adapter',
>> +        '{44c4f61d-4444-4400-9d52-802e27ede19f}' : 'PCI Express pass-through',
> Please use TAB rather than 8 space chars here. :-)
>

Oops, I was pretty sure checkpatch.pl catches such issues but apparently
it doesn't work for python scripts. And my text editor failed me as well)

>>  	'{276aacf4-ac15-426c-98dd-7521ad3f01fe}' : '[Reserved system device]',
>>  	'{f8e65716-3cb3-4a06-9a60-1889c5cccab5}' : '[Reserved system
>> device]',
>>  	'{3375baf4-9e15-4b30-b765-67acb10d607b}' : '[Reserved system
>> device]',
>> --
>
> Looks good to me except for the space/TAB issue.

Sure, will send v2.

-- 
  Vitaly

      reply	other threads:[~2016-04-25 10:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 16:20 [PATCH] tools: hv: lsvmbus: add pci pass-through UUID Vitaly Kuznetsov
2016-04-23  1:21 ` Dexuan Cui
2016-04-25 10:51   ` Vitaly Kuznetsov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87potex8pr.fsf@vitty.brq.redhat.com \
    --to=vkuznets@redhat.com \
    --cc=decui@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.