From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH] hw/9pfs: Add CephFS support in VirtFS Date: Sun, 17 Apr 2016 00:23:09 +0530 Message-ID: <87potp9yi2.fsf@skywalker.in.ibm.com> References: <1457971368-1335-1-git-send-email-scaleqiao@gmail.com> <20160407175030.5b6f2edb@bahia.huguette.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20160407175030.5b6f2edb@bahia.huguette.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: "Qemu-devel" To: Greg Kurz , Jevon Qiao Cc: haomaiwang@gmail.com, mst@redhat.com, qemu-devel@nongnu.org, sage@newdream.net, ceph-devel@vger.kernel.org, gfarnum@redhat.com List-Id: ceph-devel.vger.kernel.org Greg Kurz writes: > On Tue, 15 Mar 2016 00:02:48 +0800 > Jevon Qiao wrote: > >> Ceph as a promising unified distributed storage system is widely used in the >> world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and >> object (S3/Swift) are unsurprisingly looking at Manila and CephFS to round out >> a unified storage solution. Since the typical hypervisor people are using is >> Qemu/KVM, it is necessary to provide a high performance, easy to use, file >> system service in it. VirtFS aims to offers paravirtualized system services and >> simple passthrough for directories from host to guest, which currently only >> support local file system, this patch wants to add CephFS support in VirtFS. >> >> Signed-off-by: Jevon Qiao >> --- > > Jevon, > > There's still work to be done on this patch. > > One general remark is that there are far too many traces: it obfuscates the code > and does not bring much benefit in my opinion. If you look at the other fsdev > drivers, you see they don't do traces at all ! > > Also, I've found several errors where the code simply cannot work... please run > a file/io oriented testsuite in the guest to check all the fsdev operations are > working as expected... maybe some tests from LTP ? Also use this http://tuxera.com/sw/qa/pjd-fstest-20090130-RC.tgz -aneesh From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arsT1-0006kw-53 for qemu-devel@nongnu.org; Sun, 17 Apr 2016 15:34:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1arsSw-00031x-5d for qemu-devel@nongnu.org; Sun, 17 Apr 2016 15:34:47 -0400 Received: from e28smtp04.in.ibm.com ([125.16.236.4]:43230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arsSv-000316-FE for qemu-devel@nongnu.org; Sun, 17 Apr 2016 15:34:42 -0400 Received: from localhost by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 18 Apr 2016 01:04:37 +0530 Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay02.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u3HJYWb561079594 for ; Mon, 18 Apr 2016 01:04:32 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u3HJYVQ2010704 for ; Mon, 18 Apr 2016 01:04:33 +0530 From: "Aneesh Kumar K.V" In-Reply-To: <20160407175030.5b6f2edb@bahia.huguette.org> References: <1457971368-1335-1-git-send-email-scaleqiao@gmail.com> <20160407175030.5b6f2edb@bahia.huguette.org> Date: Sun, 17 Apr 2016 00:23:09 +0530 Message-ID: <87potp9yi2.fsf@skywalker.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] hw/9pfs: Add CephFS support in VirtFS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz , Jevon Qiao Cc: haomaiwang@gmail.com, mst@redhat.com, qemu-devel@nongnu.org, sage@newdream.net, ceph-devel@vger.kernel.org, gfarnum@redhat.com Greg Kurz writes: > On Tue, 15 Mar 2016 00:02:48 +0800 > Jevon Qiao wrote: > >> Ceph as a promising unified distributed storage system is widely used in the >> world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and >> object (S3/Swift) are unsurprisingly looking at Manila and CephFS to round out >> a unified storage solution. Since the typical hypervisor people are using is >> Qemu/KVM, it is necessary to provide a high performance, easy to use, file >> system service in it. VirtFS aims to offers paravirtualized system services and >> simple passthrough for directories from host to guest, which currently only >> support local file system, this patch wants to add CephFS support in VirtFS. >> >> Signed-off-by: Jevon Qiao >> --- > > Jevon, > > There's still work to be done on this patch. > > One general remark is that there are far too many traces: it obfuscates the code > and does not bring much benefit in my opinion. If you look at the other fsdev > drivers, you see they don't do traces at all ! > > Also, I've found several errors where the code simply cannot work... please run > a file/io oriented testsuite in the guest to check all the fsdev operations are > working as expected... maybe some tests from LTP ? Also use this http://tuxera.com/sw/qa/pjd-fstest-20090130-RC.tgz -aneesh