From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933798AbcDFKVF (ORCPT ); Wed, 6 Apr 2016 06:21:05 -0400 Received: from mga09.intel.com ([134.134.136.24]:39610 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752775AbcDFKVD (ORCPT ); Wed, 6 Apr 2016 06:21:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,447,1455004800"; d="asc'?scan'208";a="939397680" From: Felipe Balbi To: Greg Kroah-Hartman , Lu Baolu Cc: Oliver Neukum , Mathias Nyman , Lee Jones , Heikki Krogerus , Chanwoo Choi , MyungJoo Ham , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux In-Reply-To: <20160406092950.GC29930@kroah.com> References: <1457423628-3183-1-git-send-email-baolu.lu@linux.intel.com> <1457423628-3183-4-git-send-email-baolu.lu@linux.intel.com> <1457613583.2411.11.camel@suse.com> <20160310235716.GB2586@kroah.com> <5704A59C.8040500@linux.intel.com> <20160406092950.GC29930@kroah.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Wed, 06 Apr 2016 13:19:04 +0300 Message-ID: <87pou32g6f.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Greg Kroah-Hartman writes: >> On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: >> > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: >> >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: >> >> >> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-platform b/Document= ation/ABI/testing/sysfs-bus-platform >> >>> index 5172a61..a2261cb 100644 >> >>> --- a/Documentation/ABI/testing/sysfs-bus-platform >> >>> +++ b/Documentation/ABI/testing/sysfs-bus-platform >> >>> @@ -18,3 +18,18 @@ Description: >> >>> devices to opt-out of driver binding using a driver_override >> >>> name such as "none". Only a single driver may be specified in >> >>> the override, there is no support for parsing delimiters. >> >>> + >> >>> +What: /sys/bus/platform/devices/.../intel_mux >> >> Hi, >> >> >> >> is there any reason to call this "intel_mux"? We want a common interf= ace >> >> for such things. So how about "role_mux" or "master_slave_mux"? >> > I agree, don't make this intel specific, as it shouldn't be. right, we can easily change the name. What happens when e.g. AMD/NVidia/TI/MediaTek/Allwinner/etc come up with a similar setup which can't be supported by Intel's mux driver ? (see more below, agreeing on a name here doesn't seem to be enough) >> By the way, do you expect a class for port mux in sysfs? > > Why would you create a class? What is that going to do here? well, you said you didn't want this to be Intel-specific. We could just change the name and remove "intel_" from it, but then we would fall into this situation where possibly different mux drivers might be needed. That almost requires some small abstraction between sysfs and the actual implementation, does it not ? A bus_type doesn't fit here and a simple 'agreement' that mux drivers will create a sysfs file named 'mux' is too fragile. Thus... > What happened to getting internal help in designing this api? This > shouldn't be my job :) I looked at this Baolu but, at least to me, it's unclear what you're hinting here. Sure, the API is a bit odd in that we register a mux and unregister a device (that has been fixed), but is there anything else ? We're not asking that you design the API for us, rather just make your comments a little clearer. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXBOKZAAoJEIaOsuA1yqRE3YoP/2+LJk/CzUkvz9iSQ0I1dRRr GEv9jeQ9spkAMzGy9DM14vzzGAM4JbrmqjIGdS5D9wAbNlANJfUxM7FJ0dUkzqff P46eSxKkmb6otsAepHqbewLUnopCdxMeDHwIpwVW1bIlBABoiNw16coCu/czyGjw g+kRZO6Yx9celVepkmTuH3pxt8PDIKSTPGiIr80PNIfzaCxYBzUw0xKmhZynKK9D kI5X/v3beqOOG8RqgVLF6pvvHcJQfVkyFfKGcfNDWRg7ueKVH4UyuaIUzMhyRMD2 uUPEBKHYi7hEdFpmXtQfW9Igr0/Qwxx2MMJLwt1CnHOuDPfYWPtC/f76wxC2mTla jqBZixBo6zDH8xpnLnGFdEHUbRcbKUJug4SGs8+j/Zyo5KM3EXsvKc1XtA3gr7FL OHcklZNHRdUjSes6RXZdhbXvJx8LvP43Ebv9n71Co/PQYyU5b9jSHGbOBvxE3/9o Vte89gAPX68T/GT9V0IKcgfb+U/rHAKbSaTH1peV5vyeDPtU7ZrF7WF2DxVkVFtZ 2VX2haM5sBKI0gg6Ai3FpoLYB2//R9P0Qs8XKs8wX56BhAUFvQ60ti+xpArE/IoE sRLxZ4V7W48uGFc0vctkwNYdnrQ+v+Cl9+pdxkhjNpQbxtKGjPEbL0QhOKq0M5KM lwicGte5iTpFtnZ4foik =0Qyw -----END PGP SIGNATURE----- --=-=-=--