From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Tue, 29 Mar 2016 12:43:18 +0000 Subject: Re: [Intel-gfx] [PATCH 1/5] drm: Add new DCS commands in the enum list Message-Id: <87poud315l.fsf@intel.com> List-Id: References: <1459157327-2443-1-git-send-email-m.deepak@intel.com> In-Reply-To: <1459157327-2443-1-git-send-email-m.deepak@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Deepak M , Daniel Vetter , Andrzej Hajda On Mon, 28 Mar 2016, Deepak M wrote: > Adding new DCS commands which are specified in the > DCS 1.3 spec related to CABC. > > v2: Sorted the Macro`s by value (Andrzej) Yeah, well, the *new* ones are now sorted, but I'm pretty sure Andrzej did mean to keep the whole enum sorted. While at it, the comment could be /* MIPI DCS 1.3 */ to be specific and useful. > > Cc: Andrzej Hajda > Cc: Thierry Reding > Cc: David Airlie > Cc: Ville Syrjälä > Cc: Daniel Vetter > Suggested-by: Jani Nikula > Signed-off-by: Deepak M > --- > include/video/mipi_display.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h > index ddcc8ca..6831c84 100644 > --- a/include/video/mipi_display.h > +++ b/include/video/mipi_display.h > @@ -117,6 +117,14 @@ enum { > MIPI_DCS_GET_SCANLINE = 0x45, > MIPI_DCS_READ_DDB_START = 0xA1, > MIPI_DCS_READ_DDB_CONTINUE = 0xA8, > + MIPI_DCS_SET_DISPLAY_BRIGHTNESS = 0x51, /*Spec 1.3*/ > + MIPI_DCS_GET_DISPLAY_BRIGHTNESS = 0x52, /*Spec 1.3*/ > + MIPI_DCS_WRITE_CONTROL_DISPLAY = 0x53, /*Spec 1.3*/ > + MIPI_DCS_GET_CONTROL_DISPLAY = 0x54, /*Spec 1.3*/ > + MIPI_DCS_WRITE_POWER_SAVE = 0x55, /*Spec 1.3*/ > + MIPI_DCS_GET_POWER_SAVE = 0x56, /*Spec 1.3*/ > + MIPI_DCS_SET_CABC_MIN_BRIGHTNESS = 0x5E, /*Spec 1.3*/ > + MIPI_DCS_GET_CABC_MIN_BRIGHTNESS = 0x5F, /*Spec 1.3*/ > }; > > /* MIPI DCS pixel formats */ -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [Intel-gfx] [PATCH 1/5] drm: Add new DCS commands in the enum list Date: Tue, 29 Mar 2016 15:43:18 +0300 Message-ID: <87poud315l.fsf@intel.com> References: <1459157327-2443-1-git-send-email-m.deepak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1459157327-2443-1-git-send-email-m.deepak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Deepak M , Daniel Vetter , Andrzej Hajda List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAyOCBNYXIgMjAxNiwgRGVlcGFrIE0gPG0uZGVlcGFrQGludGVsLmNvbT4gd3JvdGU6 Cj4gQWRkaW5nIG5ldyBEQ1MgY29tbWFuZHMgd2hpY2ggYXJlIHNwZWNpZmllZCBpbiB0aGUKPiBE Q1MgMS4zIHNwZWMgcmVsYXRlZCB0byBDQUJDLgo+Cj4gdjI6IFNvcnRlZCB0aGUgTWFjcm9gcyBi eSB2YWx1ZSAoQW5kcnplaikKClllYWgsIHdlbGwsIHRoZSAqbmV3KiBvbmVzIGFyZSBub3cgc29y dGVkLCBidXQgSSdtIHByZXR0eSBzdXJlIEFuZHJ6ZWoKZGlkIG1lYW4gdG8ga2VlcCB0aGUgd2hv bGUgZW51bSBzb3J0ZWQuCgpXaGlsZSBhdCBpdCwgdGhlIGNvbW1lbnQgY291bGQgYmUgLyogTUlQ SSBEQ1MgMS4zICovIHRvIGJlIHNwZWNpZmljIGFuZAp1c2VmdWwuCgo+Cj4gQ2M6IEFuZHJ6ZWog SGFqZGEgPGEuaGFqZGFAc2Ftc3VuZy5jb20+Cj4gQ2M6IFRoaWVycnkgUmVkaW5nIDx0aGllcnJ5 LnJlZGluZ0BnbWFpbC5jb20+Cj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4K PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBD YzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gU3VnZ2VzdGVkLWJ5 OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IERl ZXBhayBNIDxtLmRlZXBha0BpbnRlbC5jb20+Cj4gLS0tCj4gIGluY2x1ZGUvdmlkZW8vbWlwaV9k aXNwbGF5LmggfCA4ICsrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKykK Pgo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3ZpZGVvL21pcGlfZGlzcGxheS5oIGIvaW5jbHVkZS92 aWRlby9taXBpX2Rpc3BsYXkuaAo+IGluZGV4IGRkY2M4Y2EuLjY4MzFjODQgMTAwNjQ0Cj4gLS0t IGEvaW5jbHVkZS92aWRlby9taXBpX2Rpc3BsYXkuaAo+ICsrKyBiL2luY2x1ZGUvdmlkZW8vbWlw aV9kaXNwbGF5LmgKPiBAQCAtMTE3LDYgKzExNywxNCBAQCBlbnVtIHsKPiAgCU1JUElfRENTX0dF VF9TQ0FOTElORQkJPSAweDQ1LAo+ICAJTUlQSV9EQ1NfUkVBRF9EREJfU1RBUlQJCT0gMHhBMSwK PiAgCU1JUElfRENTX1JFQURfRERCX0NPTlRJTlVFCT0gMHhBOCwKPiArCU1JUElfRENTX1NFVF9E SVNQTEFZX0JSSUdIVE5FU1MgPSAweDUxLCAvKlNwZWMgMS4zKi8KPiArCU1JUElfRENTX0dFVF9E SVNQTEFZX0JSSUdIVE5FU1MgPSAweDUyLCAvKlNwZWMgMS4zKi8KPiArCU1JUElfRENTX1dSSVRF X0NPTlRST0xfRElTUExBWSAgPSAweDUzLCAvKlNwZWMgMS4zKi8KPiArCU1JUElfRENTX0dFVF9D T05UUk9MX0RJU1BMQVkJPSAweDU0LCAvKlNwZWMgMS4zKi8KPiArCU1JUElfRENTX1dSSVRFX1BP V0VSX1NBVkUJPSAweDU1LCAvKlNwZWMgMS4zKi8KPiArCU1JUElfRENTX0dFVF9QT1dFUl9TQVZF CQk9IDB4NTYsIC8qU3BlYyAxLjMqLwo+ICsJTUlQSV9EQ1NfU0VUX0NBQkNfTUlOX0JSSUdIVE5F U1MgPSAweDVFLCAvKlNwZWMgMS4zKi8KPiArCU1JUElfRENTX0dFVF9DQUJDX01JTl9CUklHSFRO RVNTID0gMHg1RiwgLypTcGVjIDEuMyovCj4gIH07Cj4gIAo+ICAvKiBNSVBJIERDUyBwaXhlbCBm b3JtYXRzICovCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kg Q2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752228AbcC2MnZ (ORCPT ); Tue, 29 Mar 2016 08:43:25 -0400 Received: from mga04.intel.com ([192.55.52.120]:43991 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbcC2MnY convert rfc822-to-8bit (ORCPT ); Tue, 29 Mar 2016 08:43:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,410,1455004800"; d="scan'208";a="947196494" From: Jani Nikula To: Deepak M , plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Deepak M , David Airlie , Andrzej Hajda , Thierry Reding , Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 1/5] drm: Add new DCS commands in the enum list In-Reply-To: <1459157327-2443-1-git-send-email-m.deepak@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1459157327-2443-1-git-send-email-m.deepak@intel.com> User-Agent: Notmuch/0.21+91~gada1e33 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 29 Mar 2016 15:43:18 +0300 Message-ID: <87poud315l.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Mar 2016, Deepak M wrote: > Adding new DCS commands which are specified in the > DCS 1.3 spec related to CABC. > > v2: Sorted the Macro`s by value (Andrzej) Yeah, well, the *new* ones are now sorted, but I'm pretty sure Andrzej did mean to keep the whole enum sorted. While at it, the comment could be /* MIPI DCS 1.3 */ to be specific and useful. > > Cc: Andrzej Hajda > Cc: Thierry Reding > Cc: David Airlie > Cc: Ville Syrjälä > Cc: Daniel Vetter > Suggested-by: Jani Nikula > Signed-off-by: Deepak M > --- > include/video/mipi_display.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h > index ddcc8ca..6831c84 100644 > --- a/include/video/mipi_display.h > +++ b/include/video/mipi_display.h > @@ -117,6 +117,14 @@ enum { > MIPI_DCS_GET_SCANLINE = 0x45, > MIPI_DCS_READ_DDB_START = 0xA1, > MIPI_DCS_READ_DDB_CONTINUE = 0xA8, > + MIPI_DCS_SET_DISPLAY_BRIGHTNESS = 0x51, /*Spec 1.3*/ > + MIPI_DCS_GET_DISPLAY_BRIGHTNESS = 0x52, /*Spec 1.3*/ > + MIPI_DCS_WRITE_CONTROL_DISPLAY = 0x53, /*Spec 1.3*/ > + MIPI_DCS_GET_CONTROL_DISPLAY = 0x54, /*Spec 1.3*/ > + MIPI_DCS_WRITE_POWER_SAVE = 0x55, /*Spec 1.3*/ > + MIPI_DCS_GET_POWER_SAVE = 0x56, /*Spec 1.3*/ > + MIPI_DCS_SET_CABC_MIN_BRIGHTNESS = 0x5E, /*Spec 1.3*/ > + MIPI_DCS_GET_CABC_MIN_BRIGHTNESS = 0x5F, /*Spec 1.3*/ > }; > > /* MIPI DCS pixel formats */ -- Jani Nikula, Intel Open Source Technology Center