From: "Alex Bennée" <alex.bennee@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: mttcg@greensocs.com, Mark Burton <mark@greensocs.com>,
Paolo Bonzini <bonzini@gnu.org>,
alvise rigo <a.rigo@virtualopensystems.com>,
QEMU Developers <qemu-devel@nongnu.org>,
KONRAD Frederic <fred.konrad@greensocs.com>
Subject: Re: [Qemu-devel] MTTCG sync-up call today?
Date: Tue, 12 Jan 2016 17:05:35 +0000 [thread overview]
Message-ID: <87pox6d8yo.fsf@linaro.org> (raw)
In-Reply-To: <56952D38.40109@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 12/01/2016 17:32, Alex Bennée wrote:
>>> I need to look at the branch... The latest version I have here does
>>> not require tb_lock taken in tb_invalidate_phys_range.
>>
>> The tb_locks asserts where added in Fred's branch which makes sense as
>> we are going to mess with the translation block cache. Looking more
>> closely at tb_invalidate_phys_page_range I see it jumps through some
>> hoops when cpu == current_cpu == NULL.
>
> Does tb_invalidate_phys_page_range not take tb_lock itself?
You are right, I missed that when looking at the original code. I think
Fred was trying to push some of the locks up in his WIP branch causing
these problems.
I'll wait until his more complete branch is out.
>
> Paolo
--
Alex Bennée
next prev parent reply other threads:[~2016-01-12 17:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87r3hx6040.fsf@linaro.org>
[not found] ` <5695081C.1070101@greensocs.com>
2016-01-12 15:11 ` [Qemu-devel] MTTCG sync-up call today? Alex Bennée
2016-01-12 15:19 ` Paolo Bonzini
2016-01-12 16:13 ` Alex Bennée
2016-01-12 16:19 ` Paolo Bonzini
2016-01-12 16:32 ` Alex Bennée
2016-01-12 16:43 ` Paolo Bonzini
2016-01-12 17:05 ` Alex Bennée [this message]
2016-01-12 17:08 ` Paolo Bonzini
2016-01-12 17:08 ` Paolo Bonzini
2016-04-25 9:53 [Qemu-devel] MTTCG Sync-up " Alex Bennée
2016-04-25 10:32 ` alvise rigo
2016-04-25 10:33 ` Mark Burton
-- strict thread matches above, loose matches on Subject: below --
2016-05-09 11:56 Alex Bennée
2016-05-09 12:03 ` KONRAD Frederic
2016-05-09 12:11 ` alvise rigo
2016-05-09 12:41 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pox6d8yo.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=a.rigo@virtualopensystems.com \
--cc=bonzini@gnu.org \
--cc=fred.konrad@greensocs.com \
--cc=mark@greensocs.com \
--cc=mttcg@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.