From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmfIl-0001cZ-7O for qemu-devel@nongnu.org; Thu, 15 Oct 2015 05:58:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmfIi-0005Cr-1b for qemu-devel@nongnu.org; Thu, 15 Oct 2015 05:58:23 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:48160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmfIh-0005Cm-OY for qemu-devel@nongnu.org; Thu, 15 Oct 2015 05:58:19 -0400 From: OGAWA Hirofumi References: <87k2qp8yxv.fsf@mail.parknet.co.jp> <87fv1d8ywp.fsf@mail.parknet.co.jp> <87bnc18yvw.fsf_-_@mail.parknet.co.jp> <1444837495.4467.29.camel@redhat.com> <87y4f56lzu.fsf@mail.parknet.co.jp> <1444895333.24283.7.camel@redhat.com> <87a8rk7d5q.fsf@mail.parknet.co.jp> <1444900440.24283.18.camel@redhat.com> Date: Thu, 15 Oct 2015 18:58:17 +0900 In-Reply-To: <1444900440.24283.18.camel@redhat.com> (Gerd Hoffmann's message of "Thu, 15 Oct 2015 11:14:00 +0200") Message-ID: <87pp0g5u86.fsf@mail.parknet.co.jp> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann writes: >> > Also you don't need a init function, you can simply init the array with >> > c99 initializers: >> > >> > chtype vga_to_curses[256] = { >> > [0x04] = ACS_DIAMOND, >> > [ ... ] >> > }; >> >> This is not possible, because ACS_* is not constant (initialized by >> reading from termcap or such). > > Ah, ok. That isn't obvious from reading the code. Can you add a > comment please? Oh, sent updated patch already. I will resend a updated patch to this reply. -- OGAWA Hirofumi