From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35650)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZKLhu-00088e-Fu
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 03:23:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZKLhq-0000nr-Gg
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 03:23:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50011)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZKLhq-0000nj-Ar
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 03:23:14 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1437660098-4584-1-git-send-email-armbru@redhat.com>
	<1437660098-4584-7-git-send-email-armbru@redhat.com>
	<20150728113142.GE2247@work-vm>
Date: Wed, 29 Jul 2015 09:23:10 +0200
In-Reply-To: <20150728113142.GE2247@work-vm> (David Alan Gilbert's message of
	"Tue, 28 Jul 2015 12:31:43 +0100")
Message-ID: <87pp3bjuld.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v2 6/7] error: Revamp interface
	documentation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>, Luiz Capitulino <lcapitulino@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, pbonzini@redhat.com, lersek@redhat.com

"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:

> * Markus Armbruster (armbru@redhat.com) wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> ---
>>  include/qapi/error.h | 177 ++++++++++++++++++++++++++++++++++++---------------
>>  1 file changed, 127 insertions(+), 50 deletions(-)
>> 
>> diff --git a/include/qapi/error.h b/include/qapi/error.h
>> index 8c3a7dd..7d808e8 100644
>> --- a/include/qapi/error.h
>> +++ b/include/qapi/error.h
>> @@ -2,13 +2,75 @@
>>   * QEMU Error Objects
>>   *
>>   * Copyright IBM, Corp. 2011
>> + * Copyright (C) 2011-2015 Red Hat, Inc.
>>   *
>>   * Authors:
>>   *  Anthony Liguori   <aliguori@us.ibm.com>
>> + *  Markus Armbruster <armbru@redhat.com>
>>   *
>>   * This work is licensed under the terms of the GNU LGPL, version 2.  See
>>   * the COPYING.LIB file in the top-level directory.
>>   */
>> +
>> +/*
>> + * Error reporting system loosely patterned after Glib's GError.
>
> Excellent; it's great to have this documented.

Thanks!

> Do we have a note anywhere that says why we don't just use GError?

I'm not aware of such a note, and I don't know / remember why we didn't
use GError.  Perhaps one of the guys signing off the initial commit
does (cc'ing them):

    commit d5ec4f27c387c3b3200abb8656343b2519ea3047
    Author: Luiz Capitulino <lcapitulino@redhat.com>
    Date:   Wed Jun 1 12:14:49 2011 -0500

        Introduce the new error framework

        New error-handling framework that allows for exception-like error
        propagation.

        Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
        Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
        Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Here's a possible clue:

        GLib is an extremely common library that has a portable thread implementatiocommit e18df14185e817ba735bce57ecdef9a55fb3d093
    Author: Anthony Liguori <aliguori@us.ibm.com>
    Date:   Tue Jul 19 14:50:29 2011 -0500

        Add hard build dependency on glib
[...]
        Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
        Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
        Signed-off-by: Luiz Capitulino <lcapitulino@gmail.com>

Error predates our use of GLib.