From: "Alex Bennée" <alex.bennee@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: mttcg@greensocs.com, "Peter Maydell" <peter.maydell@linaro.org>,
"Mark Burton" <mark.burton@greensocs.com>,
"Alvise Rigo" <a.rigo@virtualopensystems.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Guillaume Delbergue" <guillaume.delbergue@greensocs.com>,
"KONRAD Frédéric" <fred.konrad@greensocs.com>
Subject: Re: [Qemu-devel] [RFC PATCH V2 2/3] cpus: add a tcg_executing flag.
Date: Mon, 13 Jul 2015 17:36:42 +0100 [thread overview]
Message-ID: <87pp3wj9ph.fsf@linaro.org> (raw)
In-Reply-To: <55A3E438.1010904@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 13/07/2015 18:10, Peter Maydell wrote:
>> (4) a few other things which are suspicious at best:
>> hw/intc/apic_common.c: volatile int a_i_d = apic_irq_delivered;
>
> This one has a comment above:
>
> /* Copy this into a local variable to encourage gcc to emit a plain
> * register for a sys/sdt.h marker. For details on this workaround, see:
> * https://sourceware.org/bugzilla/show_bug.cgi?id=13296
> */
>
>> hw/xen/xen_pt_msi.c: const volatile uint32_t *vec_ctrl;
>
> Seems to be MMIO (yes, really), so okay.
For some reason I don't find the use of the word "encourage" w.r.t
compiler behaviour particularly encouraging ;-)
--
Alex Bennée
next prev parent reply other threads:[~2015-07-13 16:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 16:08 [Qemu-devel] [RFC PATCH V2 0/3] Multithread TCG async_safe_work part fred.konrad
2015-07-10 16:08 ` [Qemu-devel] [RFC PATCH V2 1/3] cpus: protect queued_work_* with work_mutex fred.konrad
2015-07-10 16:08 ` [Qemu-devel] [RFC PATCH V2 2/3] cpus: add a tcg_executing flag fred.konrad
2015-07-13 15:56 ` Alex Bennée
2015-07-13 16:10 ` Peter Maydell
2015-07-13 16:15 ` Paolo Bonzini
2015-07-13 16:36 ` Alex Bennée [this message]
2015-07-15 8:40 ` Frederic Konrad
2015-07-10 16:08 ` [Qemu-devel] [RFC PATCH V2 3/3] cpus: introduce async_run_safe_work_on_cpu fred.konrad
2015-07-13 16:20 ` Alex Bennée
2015-07-13 22:56 ` Paolo Bonzini
2015-07-13 11:53 ` [Qemu-devel] [RFC PATCH V2 0/3] Multithread TCG async_safe_work part Paolo Bonzini
2015-07-13 15:50 ` Alex Bennée
2015-07-15 7:44 ` Frederic Konrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pp3wj9ph.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=a.rigo@virtualopensystems.com \
--cc=fred.konrad@greensocs.com \
--cc=guillaume.delbergue@greensocs.com \
--cc=mark.burton@greensocs.com \
--cc=mttcg@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.