From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755206AbbE2AoR (ORCPT ); Thu, 28 May 2015 20:44:17 -0400 Received: from ozlabs.org ([103.22.144.67]:43944 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754924AbbE2AoF (ORCPT ); Thu, 28 May 2015 20:44:05 -0400 From: Rusty Russell To: Peter Zijlstra Cc: kbuild test robot , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 00/10] latched RB-trees and __module_address() In-Reply-To: <20150528112002.GE3644@twins.programming.kicks-ass.net> References: <20150413141126.756350256@infradead.org> <87wq1fs9ha.fsf@rustcorp.com.au> <20150414064149.GM23123@twins.programming.kicks-ass.net> <87zj4pwj3e.fsf@rustcorp.com.au> <20150528112002.GE3644@twins.programming.kicks-ass.net> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Fri, 29 May 2015 09:19:41 +0930 Message-ID: <87pp5k9sa2.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra writes: > On Thu, May 28, 2015 at 11:37:17AM +0930, Rusty Russell wrote: >> That's rcu_read_lock_sched_held, not rcu_held_lock_sched_held(). >> >> Also, your unlikely is weird and backwards. >> >> I changed it as below, and folded. It's in modules-next. >> >> I'm now going to do some *actual* testing, and I'll go all Torvalds on >> you if this spews warnings... > > Fair enough, I did see the build robot fail on this. How come those only > showed up now? This patch has been in your git tree for a long time; you > picked up the rcu validation patches before the other ones. Indeed... Fengguang, is the kbuild test robot checking my pending-rebases tree? It's probably going to produce some noise (since that's where I drop unreviewed patches, too), but that's OK. Thanks, Rusty.