From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yqls5-0006ZL-SP for qemu-devel@nongnu.org; Fri, 08 May 2015 13:15:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yqls2-0001Ql-Dq for qemu-devel@nongnu.org; Fri, 08 May 2015 13:15:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yqls2-0001Qb-6o for qemu-devel@nongnu.org; Fri, 08 May 2015 13:15:30 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id AEC0E8E67C for ; Fri, 8 May 2015 17:15:29 +0000 (UTC) From: Markus Armbruster References: <1431021095-7558-1-git-send-email-jsnow@redhat.com> <1431021095-7558-2-git-send-email-jsnow@redhat.com> Date: Fri, 08 May 2015 19:15:27 +0200 In-Reply-To: <1431021095-7558-2-git-send-email-jsnow@redhat.com> (John Snow's message of "Thu, 7 May 2015 13:51:35 -0400") Message-ID: <87pp6b2dow.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 1/1] qtest: pre-buffer hex nibs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-devel@nongnu.org John Snow writes: > Instead of converting each byte one-at-a-time and then sending each byte > over the wire, use sprintf() to pre-compute all of the hex nibs into a > single buffer, then send the entire buffer all at once. > > This gives a moderate speed boost to memread() and memwrite() functions. > > Signed-off-by: John Snow Reviewed-by: Markus Armbruster