From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXmFd-000816-2V for qemu-devel@nongnu.org; Tue, 17 Mar 2015 03:49:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXmFZ-0004Tn-Tr for qemu-devel@nongnu.org; Tue, 17 Mar 2015 03:49:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXmFZ-0004Ti-Lo for qemu-devel@nongnu.org; Tue, 17 Mar 2015 03:49:17 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2H7nGQc016572 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 17 Mar 2015 03:49:17 -0400 From: Markus Armbruster References: <1426268589-14756-1-git-send-email-armbru@redhat.com> Date: Tue, 17 Mar 2015 08:49:14 +0100 In-Reply-To: <1426268589-14756-1-git-send-email-armbru@redhat.com> (Markus Armbruster's message of "Fri, 13 Mar 2015 18:43:09 +0100") Message-ID: <87pp88jc79.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kraxel@redhat.com Markus Armbruster writes: > Error classes are a leftover from the days of "rich" error objects. > New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f > added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. Forgot to spell it out: this needs to go into 2.3, because it fixes an external interface.