All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>,
	Damien Lespiau <damien.lespiau@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915/skl: Implement WaDisableHBR2
Date: Thu, 12 Mar 2015 20:36:22 +0200	[thread overview]
Message-ID: <87pp8ecbbt.fsf@intel.com> (raw)
In-Reply-To: <5501D88D.10707@virtuousgeek.org>

On Thu, 12 Mar 2015, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On 02/11/2015 09:43 AM, Damien Lespiau wrote:
>> v2: Use the recently introduced INTEL_REVID() and SKL_REVID defines
>>     (Nick Hoath)
>> 
>> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_dp.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> index d4c82d7..a7bc3e8 100644
>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -129,7 +129,10 @@ intel_dp_max_link_bw(struct intel_dp *intel_dp)
>>  	case DP_LINK_BW_2_7:
>>  		break;
>>  	case DP_LINK_BW_5_4: /* 1.2 capable displays may advertise higher bw */
>> -		if (((IS_HASWELL(dev) && !IS_HSW_ULX(dev)) ||
>> +		if (IS_SKYLAKE(dev) && INTEL_REVID(dev) <= SKL_REVID_B0)
>> +			/* WaDisableHBR2:skl */
>> +			max_link_bw = DP_LINK_BW_2_7;
>> +		else if (((IS_HASWELL(dev) && !IS_HSW_ULX(dev)) ||
>>  		     INTEL_INFO(dev)->gen >= 8) &&
>>  		    intel_dp->dpcd[DP_DPCD_REV] >= 0x12)
>>  			max_link_bw = DP_LINK_BW_5_4;
>> 
>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> Tested-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Potentially

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89554


> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-03-12 18:37 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 19:33 [PATCH 00/18] A few more workarounds Damien Lespiau
2015-02-09 19:33 ` [PATCH 01/18] drm/i915: Support not having an init clock gating function defined Damien Lespiau
2015-02-10  9:39   ` Daniel Vetter
2015-02-11 14:44   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 02/18] drm/i915/skl: Implement WaDisableHBR2 Damien Lespiau
2015-02-11 14:49   ` Nick Hoath
2015-02-11 17:43     ` [PATCH v2] " Damien Lespiau
2015-02-13  5:09       ` shuang.he
2015-03-12 18:18       ` Jesse Barnes
2015-03-12 18:36         ` Jani Nikula [this message]
2015-03-12 19:03           ` Jesse Barnes
2015-03-13  9:21             ` Daniel Vetter
2015-02-09 19:33 ` [PATCH 03/18] drm/i915/skl: Document the WM read latency W/A with its name Damien Lespiau
2015-02-11 14:51   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 04/18] drm/i915/skl: Provide a gen9 specific init_render_ring() Damien Lespiau
2015-02-11 14:52   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 05/18] drm/i915/skl: Make the init clock gating function skylake specific Damien Lespiau
2015-02-11 14:56   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 06/18] drm/i915/skl: Implement WaSetGAPSunitClckGateDisable Damien Lespiau
2015-02-11 14:56   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 07/18] drm/i915/skl: Implement WaSetDisablePixMaskCammingAndRhwoInCommonSliceChicken Damien Lespiau
2015-02-12 13:29   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 08/18] drm/i915/skl: Document that we implement WaRsClearFWBitsAtReset Damien Lespiau
2015-02-11 15:08   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 09/18] drm/i915/skl: Implement WaEnableLbsSlaRetryTimerDecrement Damien Lespiau
2015-02-12 15:09   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 10/18] drm/i915/skl: Implement WaDisableVFUnitClockGating Damien Lespiau
2015-02-11 15:21   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 11/18] drm/i915/skl: Introduce a SKL specific init_workarounds() Damien Lespiau
2015-02-11 15:24   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 12/18] drm/i915/skl: Implement WaDisablePowerCompilerClockGating Damien Lespiau
2015-02-11 15:29   ` Nick Hoath
2015-02-11 17:48     ` Damien Lespiau
2015-02-18  9:57       ` Nick Hoath
2015-02-23 16:31         ` Daniel Vetter
2015-02-09 19:33 ` [PATCH 13/18] drm/i915/skl: Implement WaDisablePartialResolveInVc Damien Lespiau
2015-02-11 15:31   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 14/18] drm/i915/skl: Implement WaDisableLSQCROPERFforOCL Damien Lespiau
2015-02-11 15:34   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 15/18] drm/i915/skl: Implement WaDisableHDCInvalidation Damien Lespiau
2015-02-11 15:39   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 16/18] drm/i915/skl: Implement WaDisableChickenBitTSGBarrierAckForFFSliceCS Damien Lespiau
2015-02-11 15:42   ` Nick Hoath
2015-02-11 16:04     ` Daniel Vetter
2015-02-09 19:33 ` [PATCH 17/18] drm/i915/skl: Implement WaCcsTlbPrefetchDisable:skl Damien Lespiau
2015-02-11 15:44   ` Nick Hoath
2015-02-09 19:33 ` [PATCH 18/18] drm/i915/skl: Implement WaBarrierPerformanceFixDisable Damien Lespiau
2015-02-10 14:02   ` shuang.he
2015-02-11 15:51   ` Nick Hoath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pp8ecbbt.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.