From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Subject: Re: [PATCH] drm/i915: fix failure to power off after hibernate Date: Thu, 26 Feb 2015 21:29:31 +0100 Message-ID: <87pp8w2z84.fsf@nemi.mork.no> References: <87bnkjcqjt.fsf@nemi.mork.no> <1424789904-26699-1-git-send-email-bjorn@mork.no> <1424794340.15554.3.camel@intel.com> <878ufnjfrr.fsf@nemi.mork.no> <1424889214.5991.4.camel@intel.com> <87bnkhqan8.fsf@nemi.mork.no> <1424976648.17078.1.camel@intel.com> <20150226200556.GF11371@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150226200556.GF11371@intel.com> ("Ville =?utf-8?B?U3lyasOk?= =?utf-8?B?bMOkIidz?= message of "Thu, 26 Feb 2015 22:05:56 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , stable@vger.kernel.org, intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4gd3JpdGVzOgoK Pj4gQEAgLTY1MSw3ICs2NTEsMTQgQEAgc3RhdGljIGludCBpOTE1X2RybV9zdXNwZW5kX2xhdGUo c3RydWN0IGRybV9kZXZpY2UgKmRybV9kZXYpCj4+ICAJfQo+PiAgCj4+ICAJcGNpX2Rpc2FibGVf ZGV2aWNlKGRybV9kZXYtPnBkZXYpOwo+PiAtCXBjaV9zZXRfcG93ZXJfc3RhdGUoZHJtX2Rldi0+ cGRldiwgUENJX0QzaG90KTsKPj4gKwkvKgo+PiArCSAqIER1cmluZyBoaWJlcm5hdGlvbiBvbiBz b21lIEdNNDUgcGxhdGZvcm1zIHRoZSBCSU9TIG1heSB0cnkgdG8gYWNjZXNzCj4+ICsJICogdGhl IGRldmljZSBldmVuIHRob3VnaCBpdCdzIGFscmVhZHkgaW4gRDMgYW5kIGhhbmcgdGhlIG1hY2hp bmUuIFNvCj4+ICsJICogbGVhdmUgdGhlIGRldmljZSBpbiBEMCBvbiB0aG9zZSBwbGF0Zm9ybXMg YW5kIGhvcGUgdGhlIEJJT1Mgd2lsbAo+PiArCSAqIHBvd2VyIGRvd24gdGhlIGRldmljZSBwcm9w ZXJseS4KPgo+IFBsZWFzZSBpbmNsdWRlIHRoZSBtb2RlbCBvZiB0aGUga25vd24gYmFkIG1hY2hp bmUgaW4gdGhpcyBjb21tZW50LCB0bwo+IGhlbHAgZnV0dXJlIGFyY2hhZW9sb2dpc3RzLgoKSGVy ZSBhcmUgc29tZSBkZXRhaWxzOgoKYmpvcm5AbmVtaTp+JCBncmVwIC4gL3N5cy9jbGFzcy9kbWkv aWQve2Jpb3MscHJvZHVjdH0qIDI+L2Rldi9udWxsIAovc3lzL2NsYXNzL2RtaS9pZC9iaW9zX2Rh dGU6MTIvMTkvMjAxMQovc3lzL2NsYXNzL2RtaS9pZC9iaW9zX3ZlbmRvcjpMRU5PVk8KL3N5cy9j bGFzcy9kbWkvaWQvYmlvc192ZXJzaW9uOjZFRVQ1NVdXICgzLjE1ICkKL3N5cy9jbGFzcy9kbWkv aWQvcHJvZHVjdF9uYW1lOjI3NzZMRUcKL3N5cy9jbGFzcy9kbWkvaWQvcHJvZHVjdF92ZXJzaW9u OlRoaW5rUGFkIFgzMDEKClBsZWFzZSBsZXQgbWUga25vdyBpZiB5b3UgbmVlZCBzb21lIG90aGVy IGRhdGEuCgoKQmrDuHJuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754064AbbBZU3t (ORCPT ); Thu, 26 Feb 2015 15:29:49 -0500 Received: from canardo.mork.no ([148.122.252.1]:34418 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753539AbbBZU3s convert rfc822-to-8bit (ORCPT ); Thu, 26 Feb 2015 15:29:48 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Imre Deak , linux-kernel@vger.kernel.org, Daniel Vetter , Jani Nikula , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: fix failure to power off after hibernate Organization: m References: <87bnkjcqjt.fsf@nemi.mork.no> <1424789904-26699-1-git-send-email-bjorn@mork.no> <1424794340.15554.3.camel@intel.com> <878ufnjfrr.fsf@nemi.mork.no> <1424889214.5991.4.camel@intel.com> <87bnkhqan8.fsf@nemi.mork.no> <1424976648.17078.1.camel@intel.com> <20150226200556.GF11371@intel.com> Date: Thu, 26 Feb 2015 21:29:31 +0100 In-Reply-To: <20150226200556.GF11371@intel.com> ("Ville =?utf-8?B?U3lyasOk?= =?utf-8?B?bMOkIidz?= message of "Thu, 26 Feb 2015 22:05:56 +0200") Message-ID: <87pp8w2z84.fsf@nemi.mork.no> User-Agent: Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.3.9 (canardo.mork.no [IPv6:2001:4641::1]); Thu, 26 Feb 2015 21:29:33 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ville Syrjälä writes: >> @@ -651,7 +651,14 @@ static int i915_drm_suspend_late(struct drm_device *drm_dev) >> } >> >> pci_disable_device(drm_dev->pdev); >> - pci_set_power_state(drm_dev->pdev, PCI_D3hot); >> + /* >> + * During hibernation on some GM45 platforms the BIOS may try to access >> + * the device even though it's already in D3 and hang the machine. So >> + * leave the device in D0 on those platforms and hope the BIOS will >> + * power down the device properly. > > Please include the model of the known bad machine in this comment, to > help future archaeologists. Here are some details: bjorn@nemi:~$ grep . /sys/class/dmi/id/{bios,product}* 2>/dev/null /sys/class/dmi/id/bios_date:12/19/2011 /sys/class/dmi/id/bios_vendor:LENOVO /sys/class/dmi/id/bios_version:6EET55WW (3.15 ) /sys/class/dmi/id/product_name:2776LEG /sys/class/dmi/id/product_version:ThinkPad X301 Please let me know if you need some other data. Bjørn