All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Todd Previte <tprevite@gmail.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm: Adding edp1.4 specific dpcd macros
Date: Fri, 20 Feb 2015 10:25:13 +0200	[thread overview]
Message-ID: <87pp952dna.fsf@intel.com> (raw)
In-Reply-To: <54E6217D.2000402@gmail.com>

On Thu, 19 Feb 2015, Todd Previte <tprevite@gmail.com> wrote:
> Just some formatting issues that need to be cleaned up. Otherwise the 
> definitions look correct according to the eDP 1.4 spec.

Actually the formatting seems to be in line with the rest of that
particular file.

BR,
Jani.

>
> -T
>
> On 2/19/15 12:46 AM, Sonika Jindal wrote:
>> Adding dpcd macros related to edp1.4 and link rates
>>
>> v2: Added DP_SUPPORTED_LINK_RATES macros
>>
>> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
>> ---
>>   include/drm/drm_dp_helper.h |    8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
>> index 11f8c84..77a55e2 100644
>> --- a/include/drm/drm_dp_helper.h
>> +++ b/include/drm/drm_dp_helper.h
>> @@ -92,6 +92,9 @@
>>   # define DP_MSA_TIMING_PAR_IGNORED	    (1 << 6) /* eDP */
>>   # define DP_OUI_SUPPORT			    (1 << 7)
>>
>> +#define DP_SUPPORTED_LINK_RATES			0x010 /*eDP 1.4*/
>> +#define DP_MAX_SUPPORTED_RATES			0x8
>> +
> Extra blank line
>>   #define DP_I2C_SPEED_CAP		    0x00c    /* DPI */
>>   # define DP_I2C_SPEED_1K		    0x01
>>   # define DP_I2C_SPEED_5K		    0x02
>> @@ -101,6 +104,7 @@
>>   # define DP_I2C_SPEED_1M		    0x20
>>
>>   #define DP_EDP_CONFIGURATION_CAP            0x00d   /* XXX 1.2? */
>> +# define DP_DPCD_DISPLAY_CONTROL_CAPABLE     (1 << 3) /* edp v1.2 or higher */
> Remove the space between # and define.
>>   #define DP_TRAINING_AUX_RD_INTERVAL         0x00e   /* XXX 1.2? */
>>
>>   /* Multiple stream transport */
>> @@ -221,6 +225,8 @@
>>   # define DP_UP_REQ_EN			    (1 << 1)
>>   # define DP_UPSTREAM_IS_SRC		    (1 << 2)
>>
>> +#define DP_LINK_RATE_SET			0x115
>> +
> Extra blank line
>>   #define DP_PSR_EN_CFG			    0x170   /* XXX 1.2? */
>>   # define DP_PSR_ENABLE			    (1 << 0)
>>   # define DP_PSR_MAIN_LINK_ACTIVE	    (1 << 1)
>> @@ -332,6 +338,8 @@
>>   # define DP_SET_POWER_D3                    0x2
>>   # define DP_SET_POWER_MASK                  0x3
>>
>> +#define DP_EDP_DPCD_REV                          0x700
>> +
> Extra blank line
>>   #define DP_SIDEBAND_MSG_DOWN_REQ_BASE	    0x1000   /* 1.2 MST */
>>   #define DP_SIDEBAND_MSG_UP_REP_BASE	    0x1200   /* 1.2 MST */
>>   #define DP_SIDEBAND_MSG_DOWN_REP_BASE	    0x1400   /* 1.2 MST */
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-02-20  8:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19  7:46 [PATCH] drm: Adding edp1.4 specific dpcd macros Sonika Jindal
2015-02-19 10:31 ` shuang.he
2015-02-19 17:46 ` Todd Previte
2015-02-20  8:25   ` Jani Nikula [this message]
2015-02-20 17:00     ` Todd Previte
2015-02-23 23:51       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pp952dna.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tprevite@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.