Re: [PATCH] Add ARCH_MIGHT_HAVE_VGA_CONSOLE

[Yoshinori Sato <ysato@users.sourceforge.jp>]

At Mon, 2 Feb 2015 09:10:06 +0100,
Geert Uytterhoeven wrote:
> 
> Hi Sato-san,
> 
> 
> On Mon, Feb 2, 2015 at 8:24 AM, Yoshinori Sato
> <ysato@users.sourceforge.jp> wrote:
> > The dependence of VGA_CONSOLE is complicated.
> > We need clean up.
> 
> Thanks!
> 
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> >
> > ---
> >  arch/alpha/Kconfig            | 1 +
> >  arch/arc/Kconfig              | 1 +
> >  arch/arm/Kconfig              | 1 +
> >  arch/c6x/Kconfig              | 1 +
> >  arch/hexagon/Kconfig          | 1 +
> >  arch/ia64/Kconfig             | 1 +
> >  arch/m32r/Kconfig             | 1 +
> >  arch/metag/Kconfig            | 1 +
> >  arch/microblaze/Kconfig       | 1 +
> >  arch/mips/Kconfig             | 1 +
> >  arch/nios2/Kconfig            | 1 +
> >  arch/openrisc/Kconfig         | 1 +
> >  arch/powerpc/Kconfig          | 1 +
> >  arch/s390/Kconfig             | 1 +
> >  arch/score/Kconfig            | 1 +
> >  arch/tile/Kconfig             | 1 +
> >  arch/um/Kconfig.common        | 1 +
> >  arch/unicore32/Kconfig        | 1 +
> >  arch/x86/Kconfig              | 1 +
> >  arch/xtensa/Kconfig           | 1 +
> 
> While I know you just kept the existing logic from
> drivers/video/console/kconfig,
> I doubt all of the architectures listed above do support VGA.
> I guest most of them were just too lazy to update the dependency list.
> 
> I think only alpha, arm, ia64, mips, powerpc, and x86 can have VGA.

Hmm...
If require, Add this flag.

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>

---
 arch/alpha/Kconfig            | 1 +
 arch/arm/Kconfig              | 1 +
 arch/ia64/Kconfig             | 1 +
 arch/mips/Kconfig             | 1 +
 arch/powerpc/Kconfig          | 1 +
 arch/um/Kconfig.common        | 1 +
 arch/x86/Kconfig              | 1 +
 drivers/video/console/Kconfig | 8 ++++----
 8 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/arch/alpha/Kconfig b/arch/alpha/Kconfig
index b7ff9a3..5940d83 100644
--- a/arch/alpha/Kconfig
+++ b/arch/alpha/Kconfig
@@ -27,6 +27,7 @@ config ALPHA
 	select MODULES_USE_ELF_RELA
 	select ODD_RT_SIGACTION
 	select OLD_SIGSUSPEND
+	select ARCH_MIGHT_HAVE_VGA_CONSOLE
 	help
 	  The Alpha is a 64-bit general-purpose processor designed and
 	  marketed by the Digital Equipment Corporation of blessed memory,
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 97d07ed..5662728 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -76,6 +76,7 @@ config ARM
 	select PERF_USE_VMALLOC
 	select RTC_LIB
 	select SYS_SUPPORTS_APM_EMULATION
+	select ARCH_MIGHT_HAVE_VGA_CONSOLE if ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER
 	# Above selects are sorted alphabetically; please add new ones
 	# according to that.  Thanks.
 	help
diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
index 074e52b..55e91d9 100644
--- a/arch/ia64/Kconfig
+++ b/arch/ia64/Kconfig
@@ -47,6 +47,7 @@ config IA64
 	select MODULES_USE_ELF_RELA
 	select ARCH_USE_CMPXCHG_LOCKREF
 	select HAVE_ARCH_AUDITSYSCALL
+	select ARCH_MIGHT_HAVE_VGA_CONSOLE
 	default y
 	help
 	  The Itanium Processor Family is Intel's 64-bit successor to
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 3289969..d921c4c 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -54,6 +54,7 @@ config MIPS
 	select CPU_PM if CPU_IDLE
 	select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
 	select ARCH_BINFMT_ELF_STATE
+	select ARCH_MIGHT_HAVE_VGA_CONSOLE
 
 menu "Machine selection"
 
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index a2a168e..4c2e2d2 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -152,6 +152,7 @@ config PPC
 	select DCACHE_WORD_ACCESS if PPC64 && CPU_LITTLE_ENDIAN
 	select NO_BOOTMEM
 	select HAVE_GENERIC_RCU_GUP
+	select ARCH_MIGHT_HAVE_VGA_CONSOLE if !4xx && !8xx
 
 config GENERIC_CSUM
 	def_bool CPU_LITTLE_ENDIAN
diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common
index d195a87..20cbd36 100644
--- a/arch/um/Kconfig.common
+++ b/arch/um/Kconfig.common
@@ -9,6 +9,7 @@ config UML
 	select GENERIC_IO
 	select GENERIC_CLOCKEVENTS
 	select TTY # Needed for line.c
+	select ARCH_MIGHT_HAVE_VGA_CONSOLE
 
 config MMU
 	bool
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index ba397bd..981c1a2 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -138,6 +138,7 @@ config X86
 	select HAVE_ACPI_APEI_NMI if ACPI
 	select ACPI_LEGACY_TABLES_LOOKUP if ACPI
 	select X86_FEATURE_NAMES if PROC_FS
+	select ARCH_MIGHT_HAVE_VGA_CONSOLE
 
 config INSTRUCTION_DECODER
 	def_bool y
diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
index fe1cd01..bd45569 100644
--- a/drivers/video/console/Kconfig
+++ b/drivers/video/console/Kconfig
@@ -2,14 +2,14 @@
 # Video configuration
 #
 
+config ARCH_MIGHT_HAVE_VGA_CONSOLE
+        bool
+
 menu "Console display driver support"
 
 config VGA_CONSOLE
 	bool "VGA text console" if EXPERT || !X86
-	depends on !4xx && !8xx && !SPARC && !M68K && !PARISC && !FRV && \
-		!SUPERH && !BLACKFIN && !AVR32 && !MN10300 && !CRIS && \
-		(!ARM || ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER) && \
-		!ARM64
+	depends on ARCH_MIGHT_HAVE_VGA_CONSOLE
 	default y
 	help
 	  Saying Y here will allow you to use Linux in text mode through a
-- 
2.1.4