All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled
Date: Thu, 15 Jan 2015 16:30:51 +0200	[thread overview]
Message-ID: <87ppagnmjo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <3155015.RnApTRDnnO@prime> (Simon Wunderlich's message of "Tue, 13 Jan 2015 12:04:36 +0100")

Simon Wunderlich <sw@simonwunderlich.de> writes:

>> I did not dig how the hw->conf.radar_enabled flag is set in monitor mode,
>> but if it is same as for master (i.e. set for DFS channels), then it would
>> be a better approach to prevent calling ath9k_dfs_process_phyerr()
>> altogether from ath9k_rx_skb_preprocess() if not set.
>
> Hm, you mean like - if radar_enabled then dfs_process, otherwise fft_process? 
> That would might be more elegant indeed ...
>
> The monitor mode does not have the radar flag enabled, 
> cfg80211_chandef_dfs_required() returns 0 in this case.

So are you going to send v2 or what's the plan? I didn't quite get the
conclusion from the discussion.

-- 
Kalle Valo

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: Zefir Kurtisi <zefir.kurtisi@neratec.com>,
	Arend van Spriel <arend@broadcom.com>,
	linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org,
	mathias.kretschmer@fokus.fraunhofer.de, stable@vger.kernel.org
Subject: Re: [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled
Date: Thu, 15 Jan 2015 16:30:51 +0200	[thread overview]
Message-ID: <87ppagnmjo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <3155015.RnApTRDnnO@prime> (Simon Wunderlich's message of "Tue, 13 Jan 2015 12:04:36 +0100")

Simon Wunderlich <sw@simonwunderlich.de> writes:

>> I did not dig how the hw->conf.radar_enabled flag is set in monitor mode,
>> but if it is same as for master (i.e. set for DFS channels), then it would
>> be a better approach to prevent calling ath9k_dfs_process_phyerr()
>> altogether from ath9k_rx_skb_preprocess() if not set.
>
> Hm, you mean like - if radar_enabled then dfs_process, otherwise fft_process? 
> That would might be more elegant indeed ...
>
> The monitor mode does not have the radar flag enabled, 
> cfg80211_chandef_dfs_required() returns 0 in this case.

So are you going to send v2 or what's the plan? I didn't quite get the
conclusion from the discussion.

-- 
Kalle Valo

  parent reply	other threads:[~2015-01-15 14:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 16:54 [ath9k-devel] [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled Simon Wunderlich
2015-01-09 16:54 ` Simon Wunderlich
2015-01-09 18:57 ` [ath9k-devel] " Arend van Spriel
2015-01-09 18:57   ` Arend van Spriel
2015-01-10 16:26   ` [ath9k-devel] " Simon Wunderlich
2015-01-10 16:26     ` Simon Wunderlich
2015-01-13 10:16     ` [ath9k-devel] " Zefir Kurtisi
2015-01-13 10:16       ` Zefir Kurtisi
2015-01-13 11:04       ` [ath9k-devel] " Simon Wunderlich
2015-01-13 11:04         ` Simon Wunderlich
2015-01-13 12:08         ` [ath9k-devel] " Zefir Kurtisi
2015-01-13 12:08           ` Zefir Kurtisi
2015-01-15 14:30         ` Kalle Valo [this message]
2015-01-15 14:30           ` Kalle Valo
2015-01-15 15:58           ` [ath9k-devel] " Simon Wunderlich
2015-01-15 15:58             ` Simon Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppagnmjo.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.