From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YB2HQ-0006KF-O5 for ath10k@lists.infradead.org; Tue, 13 Jan 2015 14:17:13 +0000 From: Kalle Valo Subject: Re: [PATCH 8/8] ath10k: fix error return code References: <1419872683-32709-1-git-send-email-Julia.Lawall@lip6.fr> <1419872683-32709-9-git-send-email-Julia.Lawall@lip6.fr> Date: Tue, 13 Jan 2015 16:16:40 +0200 In-Reply-To: <1419872683-32709-9-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Mon, 29 Dec 2014 18:04:43 +0100") Message-ID: <87ppai6a0n.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, netdev@vger.kernel.org Julia Lawall writes: > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > identifier ret; expression e1,e2; > @@ > ( > if (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > // > > Signed-off-by: Julia Lawall Thanks, applied to ath.git. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Tue, 13 Jan 2015 14:16:40 +0000 Subject: Re: [PATCH 8/8] ath10k: fix error return code Message-Id: <87ppai6a0n.fsf@kamboji.qca.qualcomm.com> List-Id: References: <1419872683-32709-1-git-send-email-Julia.Lawall@lip6.fr> <1419872683-32709-9-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1419872683-32709-9-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Mon, 29 Dec 2014 18:04:43 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, netdev@vger.kernel.org Julia Lawall writes: > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > identifier ret; expression e1,e2; > @@ > ( > if (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > // > > Signed-off-by: Julia Lawall Thanks, applied to ath.git. -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]:50211 "EHLO sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751271AbbAMOQv (ORCPT ); Tue, 13 Jan 2015 09:16:51 -0500 From: Kalle Valo To: Julia Lawall CC: , , , , Subject: Re: [PATCH 8/8] ath10k: fix error return code References: <1419872683-32709-1-git-send-email-Julia.Lawall@lip6.fr> <1419872683-32709-9-git-send-email-Julia.Lawall@lip6.fr> Date: Tue, 13 Jan 2015 16:16:40 +0200 In-Reply-To: <1419872683-32709-9-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Mon, 29 Dec 2014 18:04:43 +0100") Message-ID: <87ppai6a0n.fsf@kamboji.qca.qualcomm.com> (sfid-20150113_151732_243081_1AAB3BC3) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Julia Lawall writes: > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > identifier ret; expression e1,e2; > @@ > ( > if (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > // > > Signed-off-by: Julia Lawall Thanks, applied to ath.git. -- Kalle Valo