All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/mono: fixing wrong monolite library path
Date: Sun, 30 Nov 2014 23:52:30 +0100	[thread overview]
Message-ID: <87ppc4i9n5.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1417383666-23165-1-git-send-email-angelo.compagnucci@gmail.com> (Angelo Compagnucci's message of "Sun, 30 Nov 2014 22:41:06 +0100")

>>>>> "Angelo" == Angelo Compagnucci <angelo.compagnucci@gmail.com> writes:

 > Due to a bug in makefile logic, monolite libraries path will not
 > be selected when EXTERNAL_MCS parameter is specified.
 > Setting EXTERNAL_MCS to a non existent binary, makes the internal logic
 > to fallback to monolite, setting correctly both binary and
 > library paths.
 > This has the benefit to force host-mono to always use monolite as
 > bootstrap compiler also in case a mono compiler is already installed
 > on the system.

 > Fixes:
 > http://autobuild.buildroot.net/results/fc00952bef03cf3b4785be1a0d9c08dc84aa3f54/

 > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
 > ---
 >  package/mono/mono.mk | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/package/mono/mono.mk b/package/mono/mono.mk
 > index df67c33..d4beb5f 100644
 > --- a/package/mono/mono.mk
 > +++ b/package/mono/mono.mk
 > @@ -55,7 +55,7 @@ HOST_MONO_CONF_OPTS += \
 >  	--with-profile4=$(if $(BR2_PACKAGE_MONO_40),yes,no) \
 >  	--with-profile4_5=$(if $(BR2_PACKAGE_MONO_45),yes,no)
 
 > -HOST_MONO_MAKE_OPTS += EXTERNAL_MCS="$(@D)/mcs/class/lib/monolite/basic.exe"
 > +HOST_MONO_MAKE_OPTS += EXTERNAL_MCS=false 

Committed with reported-by added as suggested by Yann and a comment just
above this line explaining what it does, thanks.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2014-11-30 22:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-30 21:41 [Buildroot] [PATCH] package/mono: fixing wrong monolite library path Angelo Compagnucci
2014-11-30 22:41 ` Yann E. MORIN
2014-11-30 22:52 ` Peter Korsgaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-12-01 19:50 Rainer Berns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppc4i9n5.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.