From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48221)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XUa2o-0003pm-4K
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 07:38:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XUa2h-0003N3-Jw
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 07:38:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42886)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XUa2h-0003M7-CW
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 07:38:31 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8IBcPq3021898
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Thu, 18 Sep 2014 07:38:25 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1410881796-18452-1-git-send-email-kwolf@redhat.com>
	<1410881796-18452-2-git-send-email-kwolf@redhat.com>
	<87a95xw5on.fsf@blackfin.pond.sub.org>
Date: Thu, 18 Sep 2014 13:38:22 +0200
In-Reply-To: <87a95xw5on.fsf@blackfin.pond.sub.org> (Markus Armbruster's
	message of "Thu, 18 Sep 2014 13:04:24 +0200")
Message-ID: <87ppettaz5.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 1/6] block/qapi: Add cache information to
	query-block
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

Markus Armbruster <armbru@redhat.com> writes:

> Kevin Wolf <kwolf@redhat.com> writes:
[...]
>> @@ -335,6 +336,13 @@ void hmp_info_block(Monitor *mon, const QDict *qdict)
>>              continue;
>>          }
>>  
>> +        inserted = info->value->inserted;
>> +
>> +        monitor_printf(mon, "    Cache mode:       %s%s%s\n",
>> +                       inserted->cache->writeback ? "writeback" : "writethrough",
>> +                       inserted->cache->direct ? ", direct" : "",
>> +                       inserted->cache->no_flush ? ", ignore flushes" : "");
>> +
>
> If !inserted->cache->writeback && inserted->cache->direct, this prints
> "    Cache mode:       , writeback".

Nevermind, I can't read.

[...]