From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJIbg-00077s-8Y for qemu-devel@nongnu.org; Mon, 18 Aug 2014 04:48:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJIba-0006kJ-2W for qemu-devel@nongnu.org; Mon, 18 Aug 2014 04:48:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJIbZ-0006kB-PW for qemu-devel@nongnu.org; Mon, 18 Aug 2014 04:47:53 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7I8losl012320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 18 Aug 2014 04:47:51 -0400 From: Markus Armbruster References: <1407670353-14971-1-git-send-email-ghammer@redhat.com> <1407670353-14971-3-git-send-email-ghammer@redhat.com> <53E7AA72.6030204@redhat.com> <53E9CA22.8090300@redhat.com> <53F07AB2.4070601@redhat.com> Date: Mon, 18 Aug 2014 10:47:47 +0200 In-Reply-To: <53F07AB2.4070601@redhat.com> (Paolo Bonzini's message of "Sun, 17 Aug 2014 11:49:38 +0200") Message-ID: <87ppfy18wc.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Gal Hammer , qemu-devel@nongnu.org Paolo Bonzini writes: > Il 12/08/2014 10:02, Gal Hammer ha scritto: >> Hi, >> >> On 10/08/2014 20:22, Paolo Bonzini wrote: >> >>> Il 10/08/2014 13:32, Gal Hammer ha scritto: >>>> Based on Microsoft's sepecifications (paper can be dowloaded from >>>> http://go.microsoft.com/fwlink/?LinkId=260709), add a device >>>> description to the SSDT ACPI table. >>>> >>>> The GUID is set using a new "-vmgenid" command line parameter. >>>> >>>> Signed-off-by: Gal Hammer >>>> --- >>>> hw/i386/acpi-build.c | 23 +++++++++++++++++++++++ >>>> hw/i386/ssdt-misc.dsl | 33 +++++++++++++++++++++++++++++++++ >>>> qemu-options.hx | 9 +++++++++ >>>> vl.c | 11 +++++++++++ >>>> 4 files changed, 76 insertions(+) >>> >>> Please make this a new device (like pvpanic), instead of adding a new >>> command-line option. >> >> There is a problem with this request. I don't want to use ISA because it >> is obsolete, PCI is overkill for such a device and a SYSBUS (like HPET) >> device doesn't effect the command line options. >> >> Did I miss something in SYSBUS and that's was the reason it didn't >> appear in the "-device ?" list? > > For a sysbus device, you can override the > cannot_instantiate_with_device_add_yet field of DeviceClass in your > class_init function. Correct. Sysbus devices are not available with device_add / -device by default, because to actually work, they commonly require code to connect them to other devices. A sysbus device that doesn't need such connections can be made available with device_add / -device in the way Paolo described. [...]