From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2 v3] support/download: fix the git helper output file format
Date: Fri, 15 Aug 2014 19:22:19 +0200 [thread overview]
Message-ID: <87ppg11xdg.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <2205cccc9b1580208e604067224448da94599151.1407343550.git.yann.morin.1998@free.fr> (Yann E. MORIN's message of "Wed, 6 Aug 2014 18:47:53 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> The git helper uses gzip to compress the intermediate tarball. But gzip
> removes the source file, and create a new file named by appending .gz to
> the original file name.
> Thus, we end up with output.gz, while the download wrapper expects jsut
> output, and thus believes the downlaod failed.
> Fix that by storing the tar from git to a temporary file, then pipe this
> file to gzip's stdin, and redirect gzip's stdout to the output file.
> Reported-by: Graham Newton <gnewton@peavey-eu.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Peter Seiderer <ps.report@gmx.net>
> ---
> support/download/git | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/support/download/git b/support/download/git
> index d451530..ff6b5c3 100755
> --- a/support/download/git
> +++ b/support/download/git
> @@ -34,6 +34,6 @@ if [ ${git_done} -eq 0 ]; then
> fi
> GIT_DIR="${basename}" \
> -${GIT} archive --prefix="${basename}/" -o "${output}" --format=tar "${cset}"
> +${GIT} archive --prefix="${basename}/" -o "${output}.tmp" --format=tar "${cset}"
> -gzip "${output}"
> +gzip <"${output}.tmp" >"${output}"
Don't we then end up with a bunch of foo.tmp files?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2014-08-15 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 16:47 [Buildroot] [PATCH 0/2 v3] Fix git download helper (branch yem/download-fixes) Yann E. MORIN
2014-08-06 16:47 ` [Buildroot] [PATCH 1/2 v3] support/download: fix the git helper Yann E. MORIN
2014-08-06 16:47 ` [Buildroot] [PATCH 2/2 v3] support/download: fix the git helper output file format Yann E. MORIN
2014-08-15 17:22 ` Peter Korsgaard [this message]
2014-08-15 17:28 ` Yann E. MORIN
2014-08-15 22:18 ` Peter Korsgaard
2014-08-06 17:41 ` [Buildroot] [PATCH 0/2 v3] Fix git download helper (branch yem/download-fixes) Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppg11xdg.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.