From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH v13 4/8] powerpc: add pmd_[dirty|mkclean] for THP Date: Mon, 04 Aug 2014 16:20:07 +0530 Message-ID: <87ppggedgg.fsf@linux.vnet.ibm.com> References: <1405666386-15095-1-git-send-email-minchan@kernel.org> <1405666386-15095-5-git-send-email-minchan@kernel.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1405666386-15095-5-git-send-email-minchan@kernel.org> Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei , "Kirill A. Shutemov" , Minchan Kim , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org List-Id: linux-api@vger.kernel.org Minchan Kim writes: > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > overwrite of the contents since MADV_FREE syscall is called for > THP page. > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > support. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: "Aneesh Kumar K.V" > Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Minchan Kim > --- > arch/powerpc/include/asm/pgtable-ppc64.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/include/asm/pgtable-ppc64.h b/arch/powerpc/include/asm/pgtable-ppc64.h > index eb9261024f51..c9a4bbe8e179 100644 > --- a/arch/powerpc/include/asm/pgtable-ppc64.h > +++ b/arch/powerpc/include/asm/pgtable-ppc64.h > @@ -468,9 +468,11 @@ static inline pte_t *pmdp_ptep(pmd_t *pmd) > > #define pmd_pfn(pmd) pte_pfn(pmd_pte(pmd)) > #define pmd_young(pmd) pte_young(pmd_pte(pmd)) > +#define pmd_dirty(pmd) pte_dirty(pmd_pte(pmd)) > #define pmd_mkold(pmd) pte_pmd(pte_mkold(pmd_pte(pmd))) > #define pmd_wrprotect(pmd) pte_pmd(pte_wrprotect(pmd_pte(pmd))) > #define pmd_mkdirty(pmd) pte_pmd(pte_mkdirty(pmd_pte(pmd))) > +#define pmd_mkclean(pmd) pte_pmd(pte_mkclean(pmd_pte(pmd))) > #define pmd_mkyoung(pmd) pte_pmd(pte_mkyoung(pmd_pte(pmd))) > #define pmd_mkwrite(pmd) pte_pmd(pte_mkwrite(pmd_pte(pmd))) > > -- > 2.0.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp09.au.ibm.com (e23smtp09.au.ibm.com [202.81.31.142]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 174801A00EF for ; Mon, 4 Aug 2014 20:50:23 +1000 (EST) Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 4 Aug 2014 20:50:20 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 5EE883578054 for ; Mon, 4 Aug 2014 20:50:15 +1000 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s74AR7rd7274846 for ; Mon, 4 Aug 2014 20:27:08 +1000 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s74AoCsv029969 for ; Mon, 4 Aug 2014 20:50:13 +1000 From: "Aneesh Kumar K.V" To: Minchan Kim , Andrew Morton Subject: Re: [PATCH v13 4/8] powerpc: add pmd_[dirty|mkclean] for THP In-Reply-To: <1405666386-15095-5-git-send-email-minchan@kernel.org> References: <1405666386-15095-1-git-send-email-minchan@kernel.org> <1405666386-15095-5-git-send-email-minchan@kernel.org> Date: Mon, 04 Aug 2014 16:20:07 +0530 Message-ID: <87ppggedgg.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Cc: Jason Evans , Rik van Riel , Minchan Kim , Linux API , Hugh Dickins , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Zhang Yanfei , Michael Kerrisk , KOSAKI Motohiro , Johannes Weiner , "Kirill A. Shutemov" , linuxppc-dev@lists.ozlabs.org, Paul Mackerras , Mel Gorman List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Minchan Kim writes: > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > overwrite of the contents since MADV_FREE syscall is called for > THP page. > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > support. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: "Aneesh Kumar K.V" > Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Minchan Kim > --- > arch/powerpc/include/asm/pgtable-ppc64.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/include/asm/pgtable-ppc64.h b/arch/powerpc/include/asm/pgtable-ppc64.h > index eb9261024f51..c9a4bbe8e179 100644 > --- a/arch/powerpc/include/asm/pgtable-ppc64.h > +++ b/arch/powerpc/include/asm/pgtable-ppc64.h > @@ -468,9 +468,11 @@ static inline pte_t *pmdp_ptep(pmd_t *pmd) > > #define pmd_pfn(pmd) pte_pfn(pmd_pte(pmd)) > #define pmd_young(pmd) pte_young(pmd_pte(pmd)) > +#define pmd_dirty(pmd) pte_dirty(pmd_pte(pmd)) > #define pmd_mkold(pmd) pte_pmd(pte_mkold(pmd_pte(pmd))) > #define pmd_wrprotect(pmd) pte_pmd(pte_wrprotect(pmd_pte(pmd))) > #define pmd_mkdirty(pmd) pte_pmd(pte_mkdirty(pmd_pte(pmd))) > +#define pmd_mkclean(pmd) pte_pmd(pte_mkclean(pmd_pte(pmd))) > #define pmd_mkyoung(pmd) pte_pmd(pte_mkyoung(pmd_pte(pmd))) > #define pmd_mkwrite(pmd) pte_pmd(pte_mkwrite(pmd_pte(pmd))) > > -- > 2.0.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) by kanga.kvack.org (Postfix) with ESMTP id 64A6F6B0035 for ; Mon, 4 Aug 2014 06:50:24 -0400 (EDT) Received: by mail-pd0-f171.google.com with SMTP id z10so9434539pdj.16 for ; Mon, 04 Aug 2014 03:50:24 -0700 (PDT) Received: from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com. [202.81.31.148]) by mx.google.com with ESMTPS id xy5si17217309pbc.57.2014.08.04.03.50.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 04 Aug 2014 03:50:23 -0700 (PDT) Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 4 Aug 2014 20:50:20 +1000 Received: from d23relay07.au.ibm.com (d23relay07.au.ibm.com [9.190.26.37]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id D6FE22BB0047 for ; Mon, 4 Aug 2014 20:50:14 +1000 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay07.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s74AohOP16515072 for ; Mon, 4 Aug 2014 20:50:43 +1000 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s74AoCsr029969 for ; Mon, 4 Aug 2014 20:50:13 +1000 From: "Aneesh Kumar K.V" Subject: Re: [PATCH v13 4/8] powerpc: add pmd_[dirty|mkclean] for THP In-Reply-To: <1405666386-15095-5-git-send-email-minchan@kernel.org> References: <1405666386-15095-1-git-send-email-minchan@kernel.org> <1405666386-15095-5-git-send-email-minchan@kernel.org> Date: Mon, 04 Aug 2014 16:20:07 +0530 Message-ID: <87ppggedgg.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei , "Kirill A. Shutemov" , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Minchan Kim writes: > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > overwrite of the contents since MADV_FREE syscall is called for > THP page. > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > support. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: "Aneesh Kumar K.V" > Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Minchan Kim > --- > arch/powerpc/include/asm/pgtable-ppc64.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/include/asm/pgtable-ppc64.h b/arch/powerpc/include/asm/pgtable-ppc64.h > index eb9261024f51..c9a4bbe8e179 100644 > --- a/arch/powerpc/include/asm/pgtable-ppc64.h > +++ b/arch/powerpc/include/asm/pgtable-ppc64.h > @@ -468,9 +468,11 @@ static inline pte_t *pmdp_ptep(pmd_t *pmd) > > #define pmd_pfn(pmd) pte_pfn(pmd_pte(pmd)) > #define pmd_young(pmd) pte_young(pmd_pte(pmd)) > +#define pmd_dirty(pmd) pte_dirty(pmd_pte(pmd)) > #define pmd_mkold(pmd) pte_pmd(pte_mkold(pmd_pte(pmd))) > #define pmd_wrprotect(pmd) pte_pmd(pte_wrprotect(pmd_pte(pmd))) > #define pmd_mkdirty(pmd) pte_pmd(pte_mkdirty(pmd_pte(pmd))) > +#define pmd_mkclean(pmd) pte_pmd(pte_mkclean(pmd_pte(pmd))) > #define pmd_mkyoung(pmd) pte_pmd(pte_mkyoung(pmd_pte(pmd))) > #define pmd_mkwrite(pmd) pte_pmd(pte_mkwrite(pmd_pte(pmd))) > > -- > 2.0.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbaHDKuZ (ORCPT ); Mon, 4 Aug 2014 06:50:25 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:38453 "EHLO e23smtp05.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752370AbaHDKuX (ORCPT ); Mon, 4 Aug 2014 06:50:23 -0400 From: "Aneesh Kumar K.V" To: Minchan Kim , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei , "Kirill A. Shutemov" , Minchan Kim , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v13 4/8] powerpc: add pmd_[dirty|mkclean] for THP In-Reply-To: <1405666386-15095-5-git-send-email-minchan@kernel.org> References: <1405666386-15095-1-git-send-email-minchan@kernel.org> <1405666386-15095-5-git-send-email-minchan@kernel.org> User-Agent: Notmuch/0.18.1+51~gbbbdf04 (http://notmuchmail.org) Emacs/24.3.91.1 (x86_64-unknown-linux-gnu) Date: Mon, 04 Aug 2014 16:20:07 +0530 Message-ID: <87ppggedgg.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14080410-1396-0000-0000-000000084708 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Minchan Kim writes: > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > overwrite of the contents since MADV_FREE syscall is called for > THP page. > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > support. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: "Aneesh Kumar K.V" > Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Minchan Kim > --- > arch/powerpc/include/asm/pgtable-ppc64.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/include/asm/pgtable-ppc64.h b/arch/powerpc/include/asm/pgtable-ppc64.h > index eb9261024f51..c9a4bbe8e179 100644 > --- a/arch/powerpc/include/asm/pgtable-ppc64.h > +++ b/arch/powerpc/include/asm/pgtable-ppc64.h > @@ -468,9 +468,11 @@ static inline pte_t *pmdp_ptep(pmd_t *pmd) > > #define pmd_pfn(pmd) pte_pfn(pmd_pte(pmd)) > #define pmd_young(pmd) pte_young(pmd_pte(pmd)) > +#define pmd_dirty(pmd) pte_dirty(pmd_pte(pmd)) > #define pmd_mkold(pmd) pte_pmd(pte_mkold(pmd_pte(pmd))) > #define pmd_wrprotect(pmd) pte_pmd(pte_wrprotect(pmd_pte(pmd))) > #define pmd_mkdirty(pmd) pte_pmd(pte_mkdirty(pmd_pte(pmd))) > +#define pmd_mkclean(pmd) pte_pmd(pte_mkclean(pmd_pte(pmd))) > #define pmd_mkyoung(pmd) pte_pmd(pte_mkyoung(pmd_pte(pmd))) > #define pmd_mkwrite(pmd) pte_pmd(pte_mkwrite(pmd_pte(pmd))) > > -- > 2.0.0