From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38631)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1Wz3EM-0005wt-11
	for qemu-devel@nongnu.org; Mon, 23 Jun 2014 08:20:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1Wz3EH-0001wJ-6v
	for qemu-devel@nongnu.org; Mon, 23 Jun 2014 08:20:13 -0400
Received: from oxygen.pond.sub.org ([2a01:4f8:201:233:1::3]:59022)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1Wz3EG-0001vZ-Qn
	for qemu-devel@nongnu.org; Mon, 23 Jun 2014 08:20:09 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <cover.1403103678.git.maria.k@catit.be>
	<0d9b1e22db2b42ac007b4e0e5388b4dafaa18e2a.1403103678.git.maria.k@catit.be>
	<53A1B1C1.2020703@redhat.com>
Date: Mon, 23 Jun 2014 14:20:06 +0200
In-Reply-To: <53A1B1C1.2020703@redhat.com> (Eric Blake's message of "Wed, 18
	Jun 2014 09:35:29 -0600")
Message-ID: <87pphzizrd.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [RFC 2/3] image-fuzzer: Initial generator of qcow2
	fuzzed images
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, Maria Kustova <maxa@catit.be>, stefanha@redhat.com, Maria Kustova <maria.k@catit.be>

Eric Blake <eblake@redhat.com> writes:

> On 06/18/2014 09:29 AM, Maria Kustova wrote:
>> Qcow2 image generator is a python package providing create_image(img_path)
>> method required by the test runner.
>> It generates files containing fuzzed qcow2 image headers. Files are randomly
>> variable not only in fuzzed fields but in valid structure elements like image
>> and cluster size.
>> 
>> Signed-off-by: Maria Kustova <maria.k@catit.be>
>> ---
>>  tests/image-fuzzer/qcow2/__init__.py |   1 +
>>  tests/image-fuzzer/qcow2/fuzz.py | 271
>> +++++++++++++++++++++++++++++++++++
>>  tests/image-fuzzer/qcow2/layout.py   | 125 ++++++++++++++++
>>  3 files changed, 397 insertions(+)
>>  create mode 100644 tests/image-fuzzer/qcow2/__init__.py
>>  create mode 100644 tests/image-fuzzer/qcow2/fuzz.py
>>  create mode 100644 tests/image-fuzzer/qcow2/layout.py
>> 
>> diff --git a/tests/image-fuzzer/qcow2/__init__.py
>> b/tests/image-fuzzer/qcow2/__init__.py
>> new file mode 100644
>> index 0000000..e2ebe19
>> --- /dev/null
>> +++ b/tests/image-fuzzer/qcow2/__init__.py
>> @@ -0,0 +1 @@
>> +from layout import create_image
>> diff --git a/tests/image-fuzzer/qcow2/fuzz.py
>> b/tests/image-fuzzer/qcow2/fuzz.py
>> new file mode 100644
>> index 0000000..214dd7c
>> --- /dev/null
>> +++ b/tests/image-fuzzer/qcow2/fuzz.py
>> @@ -0,0 +1,271 @@
>> +# Fuzzing functions for qcow2 fields
>> +#
>> +# Copyright (C) 2014 Maria Kustova <maria.k@catit.be>
>> +#
>> +# This program is free software: you can redistribute it and/or modify
>> +# it under the terms of the GNU General Public License as published by
>> +# the Free Software Foundation, either version 3 of the License, or
>> +# (at your option) any later version.
>
> Won't work.  Qemu HAS to ship as GPLv2 because it contains some
> GPLv2-only code; GPLv3+ is incompatible with GPLv2.  You'll need to
> relax your license (GPLv2+ is ideal, but anything even looser, such as
> LGPLv2+ or BSD also works).

Please use GPLv2+ for new QEMU code, unless you have a really good
reason for something else, and can explain it.