From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxDY9-0001Hq-8K for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:57:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxDY3-0006ux-3k for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:57:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37587) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxDY2-0006up-Rp for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:56:59 -0400 From: Juan Quintela In-Reply-To: <20140618103649.GK29732@grmbl.mre> (Amit Shah's message of "Wed, 18 Jun 2014 16:06:49 +0530") References: <4ab8ba6bf5de4943288c1ddc565179c807f263e3.1403079139.git.amit.shah@redhat.com> <87mwdaldly.fsf@troll.troll> <20140618103649.GK29732@grmbl.mre> Date: Wed, 18 Jun 2014 12:56:54 +0200 Message-ID: <87ppi6qydl.fsf@troll.troll> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v4 01/18] migration: dump vmstate info as a json file for static analysis Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu list , Markus Armbruster , Alexander Graf , "Dr. David Alan Gilbert" , Paolo Bonzini , Andreas =?utf-8?Q?F=C3=A4rber?= Amit Shah wrote: >> >> You can print always \n now, right? > > There's also a , there... > > This sequence was added recently (v2 onwards) for the ignoring of the > VMS_MUST_EXIST stuff. I knew it needed to be some reason for the ugliness :-() >> Same for the other places? Or I am missing something. >> >> I will even go that itwould be better to just left the \n on the (*), >> and just add this \n at the end of writing a subsection. >> >> >> > + fprintf(out_file, "\n%*s}", indent - 2, ""); >> >> And you remove it from here. > > I tried several things with the \n; the current setting is the best I > found. > > Of course, this is just pretty-printing, so I don't actually remember > all the details but I can look it up my git tree... ok, I retire the comment, and anyways, it is trivial to fix incrementally if you/anybody came with a clever idea. Reviewed-by: Juan Quintela