From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuzwP-0000Eu-M4 for qemu-devel@nongnu.org; Thu, 12 Jun 2014 04:01:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuzwF-0007q0-VI for qemu-devel@nongnu.org; Thu, 12 Jun 2014 04:00:57 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:56745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuzwF-0007on-0Z for qemu-devel@nongnu.org; Thu, 12 Jun 2014 04:00:47 -0400 Received: from /spool/local by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 12 Jun 2014 13:30:41 +0530 From: Nikunj A Dadhania In-Reply-To: <5398118E.2020206@ozlabs.ru> References: <1402387005-28901-1-git-send-email-nikunj@linux.vnet.ibm.com> <5398118E.2020206@ozlabs.ru> Date: Thu, 12 Jun 2014 13:30:15 +0530 Message-ID: <87ppieftgw.fsf@abhimanyu.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] spapr: add uuid/host details to device tree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, aik@au1.ibm.com Alexey Kardashevskiy writes: > On 06/10/2014 05:56 PM, Nikunj A Dadhania wrote: >> Useful for identifying the guest/host uniquely within the >> guest. Adding following properties to the guest root node. >> >> vm,uuid - uuid of the guest >> host-model - Host model number >> host-serial - Host machine serial number >> hypervisor type - Tells its "kvm" >> >> Signed-off-by: Nikunj A Dadhania >> --- >> hw/ppc/spapr.c | 19 +++++++++++++++++++ >> target-ppc/kvm.c | 42 ++++++++++++++++++++++++++++++++++++++++++ >> target-ppc/kvm_ppc.h | 12 ++++++++++++ >> 3 files changed, 73 insertions(+) >> >> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c >> index 57e9578..ff37319 100644 >> --- a/hw/ppc/spapr.c >> +++ b/hw/ppc/spapr.c >> @@ -313,6 +313,7 @@ static void *spapr_create_fdt_skel(hwaddr initrd_base, >> uint32_t interrupt_server_ranges_prop[] = {0, cpu_to_be32(smp_cpus)}; >> int i, smt = kvmppc_smt_threads(); >> unsigned char vec5[] = {0x0, 0x0, 0x0, 0x0, 0x0, 0x80}; >> + char char_buf[512]; >> >> fdt = g_malloc0(FDT_MAX_SIZE); >> _FDT((fdt_create(fdt, FDT_MAX_SIZE))); >> @@ -331,6 +332,24 @@ static void *spapr_create_fdt_skel(hwaddr initrd_base, >> _FDT((fdt_property_string(fdt, "model", "IBM pSeries (emulated by qemu)"))); >> _FDT((fdt_property_string(fdt, "compatible", "qemu,pseries"))); >> >> + if(kvm_enabled()) { > > s/if/if / here and after. > > You did not run checkpatch.pl, did you? :) Nope, will fix it. Nikunj